lr-mame2003 driver improvement and backport
-
@grant2258 said in lr-mame2003 driver improvement and backport:
line 561
Sorry I don't quite understand they have the same hash values as the parent and clone hydrap but marked as bad dump.
-
@riverstorm said in lr-mame2003 driver improvement and backport:
@grant2258 said in lr-mame2003 driver improvement and backport:
line 561
Sorry I don't quite understand they have the same hash values as the parent and clone hydrap but marked as bad dump.
its a hack to get it working because they dont have the good dumps thats why it says baddump on that particluar set
-
@grant2258 said in lr-mame2003 driver improvement and backport:
its a hack to get it working because they dont have the good dumps thats why it says baddump on that particluar set
I thought a game needed to verify the ROMs in the archive before launch? So the entries in the DAT for hydra2p (1037, 1038 and 1039) are extraneous and this clone will run with them removed from the DAT & ROM?
-
no its not this is what they done is say hey we have this rom but these ones are bad just use the good sound roms from the parent by adding the parents crc sha so we can play the game with the other different rom files we have that are working. its borrowing a good rom from parent to get the sound working. Its marked as bad because its not the original dump thats all so it technically is bad for that set. I hope im explaining this ok for you
-
@grant2258 said in lr-mame2003 driver improvement and backport:
no its not this is what they done is say hey we have this rom but these ones are bad just use the good sound roms from the parent by adding the parents crc sha so we can play the game with the other different rom files we have that are working. its borrowing a good rom from parent to get the sound working. Its marked as bad because its not the original dump thats all so it technically is bad for that set. I hope im explaining this ok for you
Yeah that makes sense but I only have one issue with it. RetroPie users mainly use Non-Merged sets so if I only want to play "hydrap2" and delete "hydra" I am missing the correct files to launch because we removed them from the DAT which removed them from the ROM set.
I built a DAT for arcadez original changes. When I used the drivers liked the example you showed me for a bad dump like that I would have cloned the information just as the driver shows but you removed them from the DAT.
If I am doing it wrong then this will help me understand quite a bit here.
-
I understand where you are coming from in this and its something that can be fixed. This problem is in the driver and can be addressed if people want it fixed as you can see though the author put a no dump in it that can be changed it is the correct behavior though a nodump shouldnt work. It should have been marked as unplayable or merged in properly. That what me and mark are doing at the moment we are fixing the drivers up or marking there status as not working
GAME( 1990, hydrap2, hydra, atarig1, hydra, hydrap, ROT0, "Atari Games", "Hydra (prototype 5/25/90)" )
it is a prototype ill see what mark thinks to do with this one it might not work at all ive never tried it tbh
-
Sorry, I am not questioning if it should be fixed. I was just questioning the removal of those 3 files from the DAT. You said the parent ROMs with the same name will work as a hack but if we removed them from the DAT how is it able to leverage using the parent ROMs when they are not in the archive?
-
they arent removed look in the zip hydrap2 is listed from 572 this is the only set they are removed in the code would need to be changed for this to fixed in this set. Your comparing two different sets
-
I am referring to the newly generated DAT where you said the errors have all been fixed this morning. Looking below they have been removed. I have both the original DAT and the new one with corrections being removed.
<game name="hydrap2" cloneof="hydra" romof="hydra"> <description>Hydra (prototype 5/25/90)</description> <year>1990</year> <manufacturer>Atari Games</manufacturer> <rom name="05c" size="65536" crc="531ebb3b" sha1="866de3e2c747bd272c5235f9717ebeaeca90735b" region="cpu1" offset="1"/> <rom name="05e" size="65536" crc="6d77b124" sha1="a485a783211a052ca01aa400b3c5e59a2dba6faa" region="cpu1" offset="0"/> <rom name="15c" size="65536" crc="2f823b49" sha1="db457b43e528a6d447802259707a00f02bf92f2e" region="cpu1" offset="20001"/> <rom name="15e" size="65536" crc="cfda9f58" sha1="7b2727751978f35b57f8a56d8db7d1cd9378f6af" region="cpu1" offset="20000"/> <rom name="20c" size="65536" crc="a501e37b" sha1="7cf9dbe19d305304543793045cf2da934ff34d1e" region="cpu1" offset="40001"/> <rom name="20e" size="65536" crc="f75541ca" sha1="c3f8756b25b0d9f4d2d0e51a2fcc23f5a158ff87" region="cpu1" offset="40000"/> <rom name="30c" size="65536" crc="89604306" sha1="ccac6eabb174903f4ee144fce53a169daa734e07" region="cpu1" offset="60001"/> <rom name="30e" size="65536" crc="25221b17" sha1="bb14117f256c3db6881bb91cace297d4c636e684" region="cpu1" offset="60000"/> <rom name="aud.1b" size="65536" crc="e1b5188a" sha1="e9f2a78df49fa085a9363ca194e2ceb5fa5409c4" region="cpu2" offset="10000"/> <rom name="hydr1017.bin" merge="hydr1017.bin" size="65536" crc="bd77b747" sha1="da57e305468c159ca3d2cfae807a85e643bbf053" region="gfx1" dispose="yes" offset="0"/> <rom name="hydr1018.bin" merge="hydr1018.bin" size="65536" crc="7c24e637" sha1="dd9fa8a59cbd692b0d8c0e452df4fa18d770c602" region="gfx1" dispose="yes" offset="10000"/> <rom name="hydr1019.bin" merge="hydr1019.bin" size="65536" crc="aa2fb07b" sha1="ed5aa82d5bac112f0507be3e4e2a5bad184eceeb" region="gfx1" dispose="yes" offset="20000"/> <rom name="hydr1020.bin" merge="hydr1020.bin" size="65536" crc="906ccd98" sha1="6c226a5058a7432a9fc6e82e0f0608a2ae1a0963" region="gfx1" dispose="yes" offset="30000"/> <rom name="hydr1021.bin" merge="hydr1021.bin" size="65536" crc="f88cdac2" sha1="891426db0078cda61ff6c8c4ac323cb541c260d8" region="gfx1" dispose="yes" offset="40000"/> <rom name="hydr1022.bin" merge="hydr1022.bin" size="65536" crc="a9c612ff" sha1="732d4b7dd6a181fe9a692858d2a72d8994e97829" region="gfx1" dispose="yes" offset="50000"/> <rom name="hydr1023.bin" merge="hydr1023.bin" size="65536" crc="b706aa6e" sha1="4a0b919668047c24db77b6602edd67bf62e35464" region="gfx1" dispose="yes" offset="60000"/> <rom name="hydr1024.bin" merge="hydr1024.bin" size="65536" crc="c49eac53" sha1="7b5634aaee20fa8b46de871c2dc3b380fb059449" region="gfx1" dispose="yes" offset="70000"/> <rom name="hydr1025.bin" merge="hydr1025.bin" size="65536" crc="98b5b1a1" sha1="dfee7d334c4541eb13ee96b43d4d3e1a3c8deb72" region="gfx1" dispose="yes" offset="80000"/> <rom name="hydr1026.bin" merge="hydr1026.bin" size="65536" crc="d68d44aa" sha1="8fc8b82f4f90515f2af93d3f2d6903a74aac0cc9" region="gfx1" dispose="yes" offset="90000"/> <rom name="hydr1027.bin" merge="hydr1027.bin" size="131072" crc="f9135b9b" sha1="48c0ad0d3e592d191d1385e30530bdb69a095452" region="gfx2" dispose="yes" offset="0"/> <rom name="079-1040.bin" merge="079-1040.bin" size="512" crc="43d6f3d4" sha1="a072099df1db8db3589130c67a86a362e03d70ff" region="proms" dispose="yes" offset="0"/> <rom name="079-1041.bin" merge="079-1041.bin" size="512" crc="341dc4bb" sha1="175143e29cf9e6a4cecb43b3801356085944d168" region="proms" dispose="yes" offset="200"/> <rom name="079-1042.bin" merge="079-1042.bin" size="512" crc="2e49b52e" sha1="f8abffbcafe2cba7d1410175bb75ec07faac3b47" region="proms" dispose="yes" offset="400"/> <chip type="cpu" name="68000" clock="14318180"/> <chip type="cpu" name="M6502" clock="1789500"/> <chip type="audio" name="YM2151" clock="3579000"/> <chip type="audio" name="MSM6295" clock="9037"/> <video screen="raster" orientation="horizontal" width="336" height="240" aspectx="4" aspecty="3" refresh="60.000000"/> <sound channels="1"/> <input players="1" control="stick" buttons="6" coins="3"/> <dipswitch name="Service Mode"> </dipswitch> <driver status="good" color="good" sound="good" palettesize="1280"/> </game> -
you not listening look at the code it says no dump the driver needs updated its a driver issue that all and it should they should be removed or the driver should be fixed to use wrong roms
-
@grant2258 said in lr-mame2003 driver improvement and backport:
you not listening look at the code it says no dump the dirver need updated it a driver issue
Yes I saw the code. You removed these 3 files from the DAT that are part of hydrap2.zip. If I build a Non-Merged set you're saying the game will still work with the 3 missing files from the game zip?
These 3 files were removed from the DAT.
<rom name="hydr1037.bin" merge="hydr1037.bin" size="65536" region="sound1" status="baddump" offset="0"/> <rom name="hydr1038.bin" merge="hydr1038.bin" size="65536" region="sound1" status="baddump" offset="10000"/> <rom name="hydr1039.bin" merge="hydr1039.bin" size="65536" region="sound1" status="baddump" offset="20000"/> -
no the game doesnt work the driver needs fixed up for to work tahts why we got bad merges
-
@grant2258 said in lr-mame2003 driver improvement and backport:
no the game doesnt work the driver needs fixed up for to work
So you just removed the 3 needed files from the DAT so we wouldn't see the errors when using ClrMamePro? After you fix the code you'll be adding them back in I assume?
-
no i didnt edit the file at all thats what mame spits out this driver needs fixed its not done right. This is the point in this all when we fix the driver it will fix the dat itself when we dump the xml
for all changes with the no dumps
-
I think we are just dancing now for the last several posts. I am not good enough of a programmer to make any more good points. All the files were removed from the DAT that caused any type of ClrMamePro warnings. Which did nothing except get rid of the errors for the end user when using ClrMamePro by mincing the DAT. So actually nothing was fixed. Most of them are harmless and only needed one answer to fix them all in one fell swoop the "Yes to All" option when prompted on the first profile load. One click. Then you showed me code and said it's a hack and the parent ROMs make the game work, then you said the game doesn't work, then you said the files weren't removed, then finally the driver needs fixed. I am not sure why the run around but if you need me to parse any DATs for testing let me know and I'll just let you do what you do.
-
@riverstorm said in lr-mame2003 driver improvement and backport:
I think we are just dancing now for the last several posts. I am not good enough of a programmer to make any more good points. All the files were removed from the DAT that caused any type of ClrMamePro warnings. Which did nothing except get rid of the errors for the end user when using ClrMamePro by mincing the DAT. So actually nothing was fixed. Most of them are harmless and only needed one answer to fix them all in one fell swoop the "Yes to All" option when prompted on the first profile load. One click. Then you showed me code and said it's a hack and the parent ROMs make the game work, then you said the game doesn't work, then you said the files weren't removed, then finally the driver needs fixed. I am not sure why the run around but if you need me to parse any DATs for testing let me know and I'll just let you do what you do.
I dont know how to explain this to you baddump is a different set from the nodump you where talking about that being bad trhen you jumped onto the nodumps. your implying the roms are missing on 2 sets they arent . its a bad driver romload (hydrap2) doesnt work right because its not implemented right to to be none merged properly . its easy fixed and is a romload issue. I didnt make the driver and hack it in like that and yes it does need fixed and yes the files arent there and it will be removed or patched to work right. It all part of the process of fixing things and its not the only game that is there check the changes
-
this is all the changed from the original mame2003+ and the changed 2003+ new dat they where removed
-
<rom name="hydr1001.bin" size="65536" region="gfx3" status="nodump" offset="1"/> -
<rom name="hydr1002.bin" size="65536" region="gfx3" status="nodump" offset="0"/> -
<rom name="hydr1003.bin" size="65536" region="gfx3" status="nodump" offset="20001"/> -
<rom name="hydr1004.bin" size="65536" region="gfx3" status="nodump" offset="20000"/> -
<rom name="hydr1005.bin" size="65536" region="gfx3" status="nodump" offset="40001"/> -
<rom name="hydr1006.bin" size="65536" region="gfx3" status="nodump" offset="40000"/> -
<rom name="hydr1007.bin" size="65536" region="gfx3" status="nodump" offset="60001"/> -
<rom name="hydr1008.bin" size="65536" region="gfx3" status="nodump" offset="60000"/> -
<rom name="hydr1009.bin" size="65536" region="gfx3" status="nodump" offset="80001"/> -
<rom name="hydr1010.bin" size="65536" region="gfx3" status="nodump" offset="80000"/> -
<rom name="hydr1011.bin" size="65536" region="gfx3" status="nodump" offset="a0001"/> -
<rom name="hydr1012.bin" size="65536" region="gfx3" status="nodump" offset="a0000"/> -
<rom name="hydr1013.bin" size="65536" region="gfx3" status="nodump" offset="c0001"/> -
<rom name="hydr1014.bin" size="65536" region="gfx3" status="nodump" offset="c0000"/> -
<rom name="hydr1015.bin" size="65536" region="gfx3" status="nodump" offset="e0001"/> -
<rom name="hydr1016.bin" size="65536" region="gfx3" status="nodump" offset="e0000"/> -
<rom name="hydr1037.bin" size="65536" region="sound1" status="nodump" offset="0"/> -
<rom name="hydr1038.bin" size="65536" region="sound1" status="nodump" offset="10000"/> -
<rom name="hydr1039.bin" size="65536" region="sound1" status="nodump" offset="20000"/>
i not sure what dat your comparing to to maybe that where the confusion is coming from
-
-
I don't believe I made any mention of "no dump" except to say I know the difference. Not anywhere in my posts, that I can think of, so that feels a bit of slight of hand on your part there to imply it. You're way to intelligent to not know what I was pointing out. I don't want to keep going on and on as I feel the productive part has been long done.
The thought was to make this the best it can be so people are eager to merge. It seems a lot of people are not "keen" to join this two branches because arcadez was, well he's a good guy but things were pretty messed up, kind of, things were quickly implemented, not fully tested, not documented, etc. I have nothing to bad to say about him as a person at all and I think he's incredibly intelligent.
I follow you guys on Github and see what you and Mark are doing is pretty in depth and takes some serious know how (love the tagging which is huge when using DatUtil) but without trust from the higher ups it's never going to happen and be branched off. As a solo project I am sure it would flourish because it can do all lr- can do plus more.
The thought is even these little errors and how they are handled I think are being watched with scrutiny and I was just trying to point things that seemed wrong in how they were handled. Make it proper vs a quick fix.
I have to say I have no hard feelings and will test whatever DAT you guys need but mum's the word, Sir Grant! ;)
-
@riverstorm said in lr-mame2003 driver improvement and backport:
@grant2258 said in lr-mame2003 driver improvement and backport:
you not listening look at the code it says no dump the dirver need updated it a driver issue
Yes I saw the code. You removed these 3 files from the DAT that are part of hydrap2.zip. If I build a Non-Merged set you're saying the game will still work with the 3 missing files from the game zip?
These 3 files were removed from the DAT.
<rom name="hydr1037.bin" merge="hydr1037.bin" size="65536" region="sound1" status="baddump" offset="0"/> <rom name="hydr1038.bin" merge="hydr1038.bin" size="65536" region="sound1" status="baddump" offset="10000"/> <rom name="hydr1039.bin" merge="hydr1039.bin" size="65536" region="sound1" status="baddump" offset="20000"/>sorry your right i meant bad dump i think your using a different dat file im just saying I would personally prefer to fix this core up properly and mame2003 weather they are separate or not. Im glad you are point this out and im trying to explain but our wires are getting crossed.
this info above points to the hydrap rom not hydrap2 well in the mame2003+ dats not sure what dats your comparing against
less mame2003-plus/mame2003.xml | grep "hydr" | grep baddump
<rom name="hydraa0.bin" merge="hydraa0.bin" size="65536" crc="619d7319" sha1="3c58f18ca5c93ae049bfca91043718fff43e674c" region="cpu2" status="baddump" offset="10000"/>
<rom name="hydr1037.bin" merge="hydr1037.bin" size="65536" crc="b974d3d0" sha1="67ecb17386f4be00c03661de14deff77b8ca85d0" region="sound1" status="baddump" offset="0"/>
<rom name="hydr1038.bin" merge="hydr1038.bin" size="65536" crc="a2eda15b" sha1="358888ffdeb3d0e98f59e239de6d7e1f7e15aca2" region="sound1" status="baddump" offset="10000"/>
<rom name="hydr1039.bin" merge="hydr1039.bin" size="65536" crc="eb9eaeb7" sha1="cd8e076b07588879f1a0e6c0fb9de9889480bebb" region="sound1" status="baddump" offset="20000"/>checked in the new dat as well does appear to be there
-
@grant2258 said in lr-mame2003 driver improvement and backport:
this info above points to the hydrap rom not hydrap2 well in the mame2003+ dats not sure what dats your comparing against
Sorry that was a wrong paste but was meant for illustrative purposes. Even though the no dump belongs to hydrap2 it effects hydrap too because ClrMamePro doesn't know what to do with them.
When I asked if you could create a non-merged set for hydrap2 and run it you know the answer was no it wouldn't work. It was there I figured you were just messing because you started pointing fingers at everything else. You wrote the code to remove the files which removed the errors. You can talk code all day but you know you have to add the files back after the fix at the end of the day or you'll be missing sound ROMs to work correctly. It seemed like a quick hack to make it look like things were fixed.
I am approaching from the end user building a set with the provided DAT but noticed several files were removed upon checking how it was fixed. I figured you having the bigger picture understanding as you say and would have said yep I removed the files to fix those errors and will add them later but until the code fix I hacked the DAT. That really doesn't sound very good. :) Anyway heading out for the day. Have a good evening.
My original statement kind of verifies what I was trying to say/asking in the beginning:
The other issue I see is the original DAT has hash collisions. Look at the 3 lines below. It's the same file from 3 games (1 is the parent and 2 are the clones). If you run this through ClrMamePro it will not process correctly due to insufficient information and create no entries in the parent. That's the error ClrMamePro is warning about. The lack of hash information in the "hydrap2" ROM treats it as a different hash when actually it's no hash.
Another way is when doing a merge set (not split) you would need to at least use the hash collision detection option which creates a whole other challenge of subdirectories of the hash collisions. Well actually all merge files and not just hash collisions. You can test this with the original DAT if you want to see it for yourself.
Your fix was to remove the offending files from the DAT so now you have an incomplete set that doesn't work but the warnings in ClrMamePro are fixed. The better fix seems to either fix the game and get the correct information or just entirely remove the clone because you already ripped 3 files to avoid the errors.
<rom name="hydr1037.bin" size="65536" crc="b974d3d0" sha1="67ecb17386f4be00c03661de14deff77b8ca85d0" region="sound1" offset="0"/> <rom name="hydr1037.bin" merge="hydr1037.bin" size="65536" crc="b974d3d0" sha1="67ecb17386f4be00c03661de14deff77b8ca85d0" region="sound1" status="baddump" offset="0"/> <rom name="hydr1037.bin" size="65536" region="sound1" status="nodump" offset="0"/>My questions are more about "quick" fixes don't seem correct to me vs. doing it right.
I see you removed "hydr1037.bin" from "hydrap2" (the one in question we been talking about) and of course the error is gone now. Is the game flagged as not working in the code? I guess my question is just removing it from the DAT to get rid of the error didn't really fix the issue? Basically the DAT created a non-working ROM set due to "hydrap2" now has missing ROMs? There was several ROMs in "hydrap2" with the same issue that were removed (1037, 1038, 1039, etc). I was just focusing on the first one in the set.
Here's how ClrMamePro see the errors for just this parent/clone set. Their are other sets but all errors are gone now. Notice how hyrdap "bad dump" ROMs are pulled down with the hydrap2 "no dump" ROM set.
Set: Hydra (prototype 5/14/90) Name: hydrap ROM: hydr1037.bin Issue: Can't merge set due to equal names for different hashes Clone files will be named differently if full merge mode is used. Set: Hydra (prototype 5/14/90) Name: hydrap ROM: hydr1038.bin Issue: Can't merge set due to equal names for different hashes Clone files will be named differently if full merge mode is used. Set: Hydra (prototype 5/14/90) Name: hydrap ROM: hydr1039.bin Issue: Can't merge set due to equal names for different hashes Clone files will be named differently if full merge mode is used. Set: Hydra (prototype 5/25/90) Name: hydrap2 ROM: hydr1001.bin Issue: Can't merge set due to equal names for different hashes Clone files will be named differently if full merge mode is used. Set: Hydra (prototype 5/25/90) Name: hydrap2 ROM: hydr1002.bin Issue: Can't merge set due to equal names for different hashes Clone files will be named differently if full merge mode is used. Set: Hydra (prototype 5/25/90) Name: hydrap2 ROM: hydr1003.bin Issue: Can't merge set due to equal names for different hashes Clone files will be named differently if full merge mode is used. Set: Hydra (prototype 5/25/90) Name: hydrap2 ROM: hydr1004.bin Issue: Can't merge set due to equal names for different hashes Clone files will be named differently if full merge mode is used. Set: Hydra (prototype 5/25/90) Name: hydrap2 ROM: hydr1005.bin Issue: Can't merge set due to equal names for different hashes Clone files will be named differently if full merge mode is used. Set: Hydra (prototype 5/25/90) Name: hydrap2 ROM: hydr1006.bin Issue: Can't merge set due to equal names for different hashes Clone files will be named differently if full merge mode is used. Set: Hydra (prototype 5/25/90) Name: hydrap2 ROM: hydr1007.bin Issue: Can't merge set due to equal names for different hashes Clone files will be named differently if full merge mode is used. Set: Hydra (prototype 5/25/90) Name: hydrap2 ROM: hydr1008.bin Issue: Can't merge set due to equal names for different hashes Clone files will be named differently if full merge mode is used. Set: Hydra (prototype 5/25/90) Name: hydrap2 ROM: hydr1009.bin Issue: Can't merge set due to equal names for different hashes Clone files will be named differently if full merge mode is used. Set: Hydra (prototype 5/25/90) Name: hydrap2 ROM: hydr1011.bin Issue: Can't merge set due to equal names for different hashes Clone files will be named differently if full merge mode is used. Set: Hydra (prototype 5/25/90) Name: hydrap2 ROM: hydr1012.bin Issue: Can't merge set due to equal names for different hashes Clone files will be named differently if full merge mode is used. Set: Hydra (prototype 5/25/90) Name: hydrap2 ROM: hydr1013.bin Issue: Can't merge set due to equal names for different hashes Clone files will be named differently if full merge mode is used. Set: Hydra (prototype 5/25/90) Name: hydrap2 ROM: hydr1014.bin Issue: Can't merge set due to equal names for different hashes Clone files will be named differently if full merge mode is used. Set: Hydra (prototype 5/25/90) Name: hydrap2 ROM: hydr1016.bin Issue: Can't merge set due to equal names for different hashes Clone files will be named differently if full merge mode is used. Set: Hydra (prototype 5/25/90) Name: hydrap2 ROM: hydr1038.bin Issue: Can't merge set due to equal names for different hashes Clone files will be named differently if full merge mode is used. Set: Hydra (prototype 5/25/90) Name: hydrap2 ROM: hydr1039.bin Issue: Can't merge set due to equal names for different hashes Clone files will be named differently if full merge mode is used.
Contributions to the project are always appreciated, so if you would like to support us with a donation you can do so here.
Hosting provided by Mythic-Beasts. See the Hosting Information page for more information.