lr-mame2003 driver improvement and backport
-
@markwkidd Can you confirm that samples are working for you ?
-
Yes that is the correct location for samples. I just downloaded from source today. I recently switched over to Arcade and run everything from there. I built my inputs around MAME and had a heck of a time figuring out how to override all/retroarch.cfg for FBA keyboard/IPAC only while keeping everything else the same including controllers but I did finally get everything working.
So that left the mame-libretro folder open for testing mame2003-plus without overwriting my working set but I have to override everything for mame2003-plus. I dumped about 20 games and found several issues.
- svc - crashes to the menu
- svcboot - crashes to menu
- Depth Charge - no sound
- Donkey Kong - half sound, missing several pieces
- Zaxxon - no sound
The sounds all work perfectly in lr-mame2003. Several sounds do work correctly but out of the handful I tested I had several errors. It's going to take a whole group of testers to really test all these ROMs.
I had to prompt 'ok' on some ROMs things you can bypass with lr-mame2003 core options like
mame2003-skip_warnings = "enabled" -
@markwkidd said in lr-mame2003 driver improvement and backport:
PS I'm not sure if the double listings hurts anything, although it might. I will probably find out when I finally get around to setting up my brother's X-Arcade Tankstick to work with Lakka.
In brief, you need to have a custom retroarch.cfg mame2003-plus that unmaps all of the 'conflicting' keys listed here: https://docs.libretro.com/guides/retroarch-keyboard-controls/Thanks Mark I will look into it for sure. I don't think it does hurt anything but I would love to see that fixed or at least a clean input screen. If only disabling inputs temporarily to get them clean.
When I used a mouse left click I get something like this "RETROPAD1 LEFT MOUSE RETROPAD2 LEFT MOUSE RETROPAD3 LEFT MOUSE RETROPAD4 LEFT MOUSE. That's from one key press.
It's a real pain as every options shows '...' because the input strings are SO long. Thanks for the links I will check it out. After I disabled everything in Retroarch keys like Z & S were still having "ghost" inputs but couldn't quite figure out where they were defined as everything
all/retroarch.cfgwere commented out and alsoarcade/retroarch.cfghad nothing. -
Instead of commenting out those lines in the
retroarch.cfg, could you try to set them to"nul"?such as:
input_rewind = "nul" -
@markwkidd said in lr-mame2003 driver improvement and backport:
Instead of commenting out those lines in the
retroarch.cfg, could you try to set them to"nul"?such as:
input_rewind = "nul"Ah ok, nice, thanks Mark yeah that makes sense. I think it's more cosmetic and a real pain for viewing inputs at a glance but last night I was able to get a completely clean default.cfg for MAME and was close on <game>.cfg overrides for like pinball, etc. that make more sense with the left/right shoulders or triggers, etc. until I crashed it by getting delete happy with some needed files. I will try again tonight and hunt down those scraggler Retroarch settings. :)
-
@markwkidd just to add to that with what you said everything just became crystal clear. Those few left over keys that are still in use.
When I disable Retroarch settings it's only temporary as once things are setup I re-enable all the inputs and everything works fine and looks correct. Then I backup my default.cfg between updates so it only needs to be done once.
What prompted me to do is when I started setting up inputs for players 2, 3 and 4 I have assigned all the alphabet keys and of course more virtual pad inputs started making strings even longer so I thought why not clean it up.
Also it seems the Pause key disappeared from lr-mame2003 TAB input I just noticed last night. I have to check mame2003-plus tonight and see if it's there as I left my SD card at home after lunch when testing a few games.
-
@riverstorm said in lr-mame2003 driver improvement and backport:
So that left the mame-libretro folder open for testing mame2003-plus without overwriting my working set but I have to override everything for mame2003-plus. I dumped about 20 games and found several issues.
- svc - crashes to the menu
- svcboot - crashes to menu
- Depth Charge - no sound
- Donkey Kong - half sound, missing several pieces
- Zaxxon - no sound
@markwkidd This confirms that the samples in the samples directory are not being played.
'svcboot.zip' works fine on mine, I built from source this morning and manually generated the datfile. Are you sure you have the right roms ?
'svc.zip' has corrupted graphics.
-
@maxbeanz said in lr-mame2003 driver improvement and backport:
@markwkidd This confirms that the samples in the samples directory are not being played.
Some do actually play fine so not all are broke for example these were all working fine Shark Attack, Q-bert, Bosconian, Carnival, Xevious, Wizard of Wor, etc.
I built from source this morning and manually generated the datfile. Are you sure you have the right roms ?
I was just looking at the DAT and I see I forgot to dump the neogeo.zip into the folder, will do tonight and retest.
-
@riverstorm said in lr-mame2003 driver improvement and backport:
Also it seems the Pause key disappeared from lr-mame2003 TAB input I just noticed last night. I have to check mame2003-plus tonight and see if it's there as I left my SD card at home after lunch when testing a few games.
"MAME pause" is now gone from mame2003 but "libretro pause" is still there (and uses the same code). You should use the retroarch pause hotkey.
This pause change will eventually happen to mame2003-plus once I get time to sync the two cores up better. Maybe late April or May.
-
@markwkidd said in lr-mame2003 driver improvement and backport:
"MAME pause" is now gone from mame2003 but "libretro pause" is still there (and uses the same code). You should use the retroarch pause hotkey.
This pause change will eventually happen to mame2003-plus once I get time to sync the two cores up better. Maybe late April or May.Thanks Mark yeah I do use the Retroarch pause. I prefer the lr-mame pause but for some reason it would always pause as a blank screen and Retroarch doesn't.
What I try and do is match AdvMAME & mame4all (any non lr- cores) to the lr-cores so they are seamless but a few keys like pause is different. Select+p for lr- vs. p for AdvMAME.
Is there any chance of fixing the XBOX silver home button in the center down the road? I really like using that button for pulling up the MAME TAB menu in AdvMAME and mame4all. It would be handy to do the same in the lr- cores.
-
@riverstorm said in lr-mame2003 driver improvement and backport:
@markwkidd said in lr-mame2003 driver improvement and backport:
"MAME pause" is now gone from mame2003 but "libretro pause" is still there (and uses the same code). You should use the retroarch pause hotkey.
This pause change will eventually happen to mame2003-plus once I get time to sync the two cores up better. Maybe late April or May.Thanks Mark yeah I do use the Retroarch pause. I prefer the lr-mame pause but for some reason it would always pause as a blank screen and Retroarch doesn't.
What I try and do is match AdvMAME & mame4all (any non lr- cores) to the lr-cores so they are seamless but a few keys like pause is different. Select+p for lr- vs. p for AdvMAME.
Is there any chance of fixing the XBOX silver home button in the center down the road? I really like using that button for pulling up the MAME TAB menu in AdvMAME and mame4all. It would be handy to do the same in the lr- cores.
What happens when you use the MAME Tab menu to try to map the Xbox button? Does it not show up at all?
-
@maxbeanz and @Riverstorm do you mind communicating directly with @arcadez on this samples issue over in github? https://github.com/arcadez/mame2003-plus-libretro/issues/18#issuecomment-379105149
While I'm traveling there are some things I'm good at keeping up with but this samples thing is a good example of something that's difficult for me to track when I'm moving around from place to place.
-
@markwkidd said in lr-mame2003 driver improvement and backport:
What happens when you use the MAME Tab menu to try to map the Xbox button? Does it not show up at all?
Nothing happens. It basically sits and waits for input. It's like your pressing no keys when you press the XBOX home button.
Yeah I will post over there and let arcadez know. Also I am getting the same as Max now that I have the neogeo BIOS in place. svcboot works perfect and svc works but the graphics are all garbled.
-
@riverstorm @markwkidd I checked a lot of games that use samples and none of the samples play. The sample support must be broken. @Riverstorm Note: some of the games have sound because it's not using a WAV sample, for instance, 'dkong' uses samples for jump run & stomp, 'bosco' uses them for fire and explosion. There is no speech in 'Gorf', 'Wizard of Wor', 'Shark Attack' etc.
When the sample support is fixed we'll need to use the 'dkong' samples from Twistys 'older samples' as that contains the missing 'effect00, effect01, effect02'. You may wan't to edit your Github post :)
-
@maxbeanz said in lr-mame2003 driver improvement and backport:
he sample support is fixed we'll n
updated the dat today in case people dont about the xml generator damn i just woke up and read this again lol fixed
-
@maxbeanz said in lr-mame2003 driver improvement and backport:
some of the games have sound because it's not using a WAV sample, for instance, 'dkong' uses samples for jump run & stomp, 'bosco' uses them for fire and explosion. There is no speech in 'Gorf', 'Wizard of Wor', 'Shark Attack' etc.
That makes sense. I knew they could be hybrid but it's been years since I really spent time thinking about samples. I've been using the same canned set in mame4all for years and with the newest set you don't really need to process samples.
When I played bosco I flew around and fired but didn't actually blow up a space station. Part of the audio is from ROMs and part is from samples. You're getting partial sound? Same for Gorf. Zaxxon and Depth Charge must be 100% samples hence no sound at all.
I would still opt for the enhanced sounds. What I do is overwrite the older samples with the new enhanced ones (4 new total) but the DAT is missing the effect wav's so they get ripped right back out of the sample set. You need effect00.wav, effect01.wav & effect02.wav for the girder stomp in the intro, etc.
-
@maxbeanz - Here's a DAT of only new and updated ROMs in mame2003_plus_libretro. It's created as Non-Merged due to ROM dependencies would make the list much larger or you would get many ClrMamePro errors leaving out the dependencies of a split or merge set.
If you overwrite your lr-mame2003 set (also needs to be non-merged) it will be identical to mame2003_plus_libretro. There's two exceptions that only exist in lr-mame2003 listed below. That can be manually removed or run through ClrMamePro to auto remove them. I wouldn't recommend doing it to your archive set though but to a new directory or when building up RetroPie.
The size is 1.52GB which is much smaller than storing the entire set. Also it allows you to test the new and updated games only or the entire set while saving space. You can use the Arcade folder and leave your lr-mame2003 folder without changes.
I am doing it the other way around. I have everything in Arcade (lr-mame2003, lr-fbalpha & AdvMAME) and then use the mame-libretro folder using mame2003_plus_libretro set as default for testing. That way I don't need to modify my current set but can add any new games that mame2003_plus_libretro support.
If they are ever able to "ignore" the Retroarch abstraction layer inputs when in the MAME TAB menu and restore them upon exit. I might fully convert over! ;)
Only exist in lr-mame2003:
• Cabal (US set 2) (cabal2)
• Urashima Mahjong (urashima)ROM Count:
Total ROMs - 4810
Duplicate ROMs - 4687
New ROMs - 92
Updated ROMs - 31 -
@riverstorm Thanks, but I already added all the new games to my collection a week ago. I'm currently using mame2010 until they sort out the broken samples in 2003plus and if Arcadez can get the Bally games working.
-
@maxbeanz said in lr-mame2003 driver improvement and backport:
@riverstorm Thanks, but I already added all the new games to my collection a week ago. I'm currently using mame2010 until they sort out the broken samples in 2003plus and if Arcadez can get the Bally games working.
Time flies, sorry, I didn't realize a week had passed since you asked last. As long as you have a system that works. I know Zuppa said he had tested most of them already on Friday too. I wasn't quite sure where you guys were getting your lists. I know the whatsnew.txt shows 111 games but a binary compare actually shows 123 games have been added/updated. My goal was create a set that could supplement lr-mame2003 that is 100% accurate but I see they outdated the list already within 24 hours which is great to see the new updates. ;) As long as you go through the commits occasionally you should have it.
-
Just wanted to say again that all the testing is a major help.
Contributions to the project are always appreciated, so if you would like to support us with a donation you can do so here.
Hosting provided by Mythic-Beasts. See the Hosting Information page for more information.