Request: Add an Instant Transition [SOLVED]
-
@cafarellidigital so your not really asking for a new transition at all, you still want some elements to transition, you just want some elements static and not to be effected by the transition.
-
@TMNTturtlguy correct. At first thought the idea of a new "instant" transition was great, then as I thought about it, I realized what I really wanted was a new function/tag that elements could have. So I guess I hijacked the thread a bit didn't I?
-
@cafarellidigital Hijack away! It's the same goal in the end.
-
@Capeman Would you be interested in testing ?
I have pushed changes correspoding to No Transition/Animation to my repo:
Sent from 20,000 leagues under the sea.
Powersaver Emulation station : https://github.com/hex007/EmulationStation
ES dev script : https://github.com/hex007/es-dev/blob/master/es-tests.sh -
@Hex can you provide me with some more information on what is in your build? How up to date is it with the main ES build? Thanks
-
As of now it is 4 commits behind. Those commits were pushed today i guess.
The build is optimised for Pi zero and 1. Has problems with video as the program sleeps till user input.
Has music player incorporated for which you have to follow some instructions to get running. If you are testing on Linux and not Pi then you will have to change "audio-server/player.py" file to change music directory.
I have added None as a Transition today.
Thats all
Sent from 20,000 leagues under the sea.
Powersaver Emulation station : https://github.com/hex007/EmulationStation
ES dev script : https://github.com/hex007/es-dev/blob/master/es-tests.sh -
@Hex Right now all of my gamelists have video, should i avoid testing at this point?
-
@TMNTturtlguy You can test it. Just that I dont know how it might behave. Only two options either the video continues playing or it stops after some time. It certainly wont crash or damage your lists/data
On the plus side if it works I will put it on the Readme that videos work
Sent from 20,000 leagues under the sea.
Powersaver Emulation station : https://github.com/hex007/EmulationStation
ES dev script : https://github.com/hex007/es-dev/blob/master/es-tests.sh -
@Hex I just ran through your build. I have to say the theme transition NONE, is pretty slick. My only question is if it would be possible to allow the carousel to still transition. I like the static background, but and the carousel images pop up really fast, so it isn't an issue, but i think it would look really cool if the carousel logos could slide or fade over the static backdrop. As for videos, the videos played for 2 seconds and just paused. No other performance issues, they just paused.
I would seriously consider making a branch of the main ES Build and only incorporating the NONE transition into it. Like I said, if he carousel could still transition, it would be perfect. If you isolate this update and submit a PR, a lot of people would be really excited about it.
Thanks for the awesome work
-
@Hex would you consider bringing your changes over to the main repository? The optimizations could come either as a compilation option (if compiled on a pi zero or 1), emulationstation option (for users to select) and/or command line option (and have RetroPie Setup add that option on a pi zero or 1 to the emulationstation startup script).
The rest could come as normal options for everyone.
I suspect that'd be the best to avoid fragmentation, bring your work to a wider audience and bring another good emulationstation developer to the project.
Do consider that. Happy to help.
Also, you could certainly make videos work by forcing the screen to refresh in the video view only, which I agree isn't needed for anywhere else on emulationstation as everything is static.
Oh, and that won't be an issue with OMX player, as rendering is handled in a separate process.
Still, good work!
-
@TMNTturtlguy I will try that tomorrow. Also read ahead.
@pjft If you have a Pi Zero or 1, I would appreciate if you can measure CPU consumption of Emulation station (mine and stock) when doing nothing on Carousel.
ssh into Pi
topI noticed a constant ~60% usage on the stock on pi zero
Sent from 20,000 leagues under the sea.
Powersaver Emulation station : https://github.com/hex007/EmulationStation
ES dev script : https://github.com/hex007/es-dev/blob/master/es-tests.sh -
@Hex I don't have one, but I notice similar regular CPU consumption (unsure if at 60%, but certainly not idle) when emulationstation is idle. I haven't read your code but from what you described you're avoiding refreshing the screen - including reading and processing the textures - unless there's an input. That's a wise change, as very little of it is animated. You probably have a few seconds of buffer to accommodate animations, inferring from the fact that videos play for a few seconds.
The reasons video views would need to be refreshed is because they are rendered in a normal texture, so if emulationstation doesn't refresh the screen it won't render more frames.
But for the time being that's the only exception that comes to mind.
-
@pjft said in Request: Add an Instant Transition:
@Hex would you consider bringing your changes over to the main repository? The optimizations could come either as a compilation option (if compiled on a pi zero or 1), emulationstation option (for users to select) and/or command line option (and have RetroPie Setup add that option on a pi zero or 1 to the emulationstation startup script).
The rest could come as normal options for everyone.
I suspect that'd be the best to avoid fragmentation, bring your work to a wider audience and bring another good emulationstation developer to the project.
Do consider that. Happy to help.
Also, you could certainly make videos work by forcing the screen to refresh in the video view only, which I agree isn't needed for anywhere else on emulationstation as everything is static.
Oh, and that won't be an issue with OMX player, as rendering is handled in a separate process.
Still, good work!
@pjft Can you update the clone and test it? I have set it to disable powersavings if Videos are present.
-
@Hex I haven't tested it yet, but I don't think the power saver flag is going to work properly. On startup,
getGameListViewis called for each system and the view is cached. As implemented, I believe the power saver flag will be set based on the last view created vs. the current view. Instead of setting and returning a boolean, you could test the name ofmCurrentViewto see if it isvideo. -
@TMNTturtlguy I agree changing the view transition style shouldn't effect the animation in the carousel itself.
-
@jdrassa Can you test it. I dont have Videos so i cant test it. I will change the implementation if it doesn't work
Sent from 20,000 leagues under the sea.
Powersaver Emulation station : https://github.com/hex007/EmulationStation
ES dev script : https://github.com/hex007/es-dev/blob/master/es-tests.sh -
@Hex I will try to get it tested in the next couple of days will report back.
-
@Hex did you make changes to the carousel transition or just the video playback? Thanks
-
@TMNTturtlguy power savings is suspended if Game lists have video. I also want to see what jdrassa meant that all views are cached.
Sent from 20,000 leagues under the sea.
Powersaver Emulation station : https://github.com/hex007/EmulationStation
ES dev script : https://github.com/hex007/es-dev/blob/master/es-tests.sh -
@Hex I just reinstalled your ES build and did not notice much a change in the video. It may play for about a second longer than it did before, but it still stalls out after 2-3 seconds. Thanks
Contributions to the project are always appreciated, so if you would like to support us with a donation you can do so here.
Hosting provided by Mythic-Beasts. See the Hosting Information page for more information.