ES themes ready for favorite, all games, recently played and custom-collections

TMNTturtlguy

@pjft just an FYI, it is very easy for theme makers to change the folder name. Changing the folder name is a simple click and rename of the folder and then uploading that change to github. If the themes uses github desktop this whole charge is about 4 clicks of a button.

Changing the system logo art is of course more work, but I don't see a need for that in any of your request.

If you want to test this out you can renam the theme folders within the ComicBook theme however you like and see how everything works.

alphatoanant

@pjft I agree with @TMNTturtlguy thoughts on this as well. Its easy/quick to update a folder name on the theme side.

Are these are the aspects?

the name of the folder:
From a theme maker perspective this can be changed easily. Any of the folder name options presented above would be fine
the logo:
This would be up to a theme maker to decide what is displayed in the image so I think this is ok as well
the text that displays if there is no logo defined for the theme (e.g. what shows for logoText element):
The proposed options are "My Collections", "Collections" and "Custom Collections" right?
If so I like the simplicity of "Collections".

HurricaneFan

@alphatoanant @pjft I also like the minimal term "Collections".

dmmarti

Since I personally don't usually rearrange my es_systems.cfg .. it doesn't bother me so much where ES displays it in the menu. But, I could see where the folks that do...it might bug 'em.

As for renaming the new theme subfolder from "custom-collections" to something else, as the others have said, easy peasy. My only thoughts about that would be, if folks have already installed a few themes that use that folder name, then update their RetroPie install ... just need to make sure they also update their themes too (if the theme author made the change to the different name).

dmmarti

@cyperghost --- real quick, my recent theme called "Showcase" has full support of the 4 virtual systems .... if you wanna throw it in the chart above.....thanks

cyperghost

done added Showcase theme @dmmarti

nestor1924

Hi, im kind of confused... so foe this to work i have to do editinga of my own? I mean, it cant be done the normal way but just going into the menu???... i just updated emulation estation scrips too, o get the option but keeps saying that the theme is not compatible....

pjft

@nestor1924 what theme are you using?

You shouldn't have to edit anything, it's all done inside Emulationstation. The custom collections aren't available yet, though, only in the development build.

@dmmarti it's not really about changing anything in that file, but rather there'll be an option to sorry the custom collections with the existing systems. That's where it manifests itself as if it's sorted, users in the carousel will go from C to My Collections and then to D.

Omnija

@cyperghost Even though "Metro Theme" is still WIP/Demo and unfinished, it supports all 4 to add to the list.
https://github.com/Omnija/es_theme_metro

fastlowrex

@cyperghost --- real quick, my recent theme called "Magazine Madness" has full support of the 4 virtual systems .... if you wanna throw it in the chart above.....thank you very much :)

pjft

@alphatoanant @TMNTturtlguy Thanks for the replies.

The aspects are really mostly #1 and #2 in your list - I'm not that concerned with what text displays if there's no logo.

The thing is, if users choose to sort all systems and collections, the names they'll see (because of the logo being displayed) will be off, depending on whether theme creators named it "My Collections" or "Custom Collections".

After thinking a bit about it, I'm kind of liking it being just "Collections", and keeping the folder custom-collections.

Would anyone have strong concerns with that? It makes the name smaller, so that's a plus in my book.

The only problem would be that every theme would need to adjust the logos to name it collections...

Before anyone does anything, though, I'd certainly like to hear others' opinions on what you feel would be a good system name for the group of collections users can create, and then we can close that. Currently under consideration:

Custom Collections
My Collections
Game Collections
Collections

Thank you all, and happy Sunday.

cyperghost

@fastlowrex said in ES themes ready for favorite, all games, recently played and custom-collections:

@cyperghost --- real quick, my recent theme called "Magazine Madness" has full support of the 4 virtual systems .... if you wanna throw it in the chart above.....thank you very much :)

Done Magazine Madness added

HurricaneFan

@pjft I like "Collections".

ohmycommodore

agreed, "Collections" seems the most tidy

alphatoanant

+1 for Collections

paffley

The collections....How is the process going to work? Looking very forward to this I must admit :) keep up the great work!

nestor1924

Updated all recent themes compatible to it, they do accept the collection option but once i set up any of them it show only the text, no icons at all... i already updated retro pie or emulation station unless i did it wrong...

lostless

Im trying to get my theme working, but having no luck. I made the folder called it custom-collections, added the xml, logos etc. and its acting like its not there. Is there something special in the xml i have to add?
Also this version messes up my custom order of systems. Is this intentional or a bug?

TMNTturtlguy

@lostless I have no clue what your first question about your theme is. The second part, in the start menu turn of the sort option for collections.

lostless

@tmntturtlguy basically I'm saying i added the custom collections folder to my theme, but emulation station is acting as if does not exist. It's showing the custom collections, but its not themed. Don't get why.