RetroPie forum home
    • Recent
    • Tags
    • Popular
    • Home
    • Docs
    • Register
    • Login

    Mausberry Shutdown Script Doesn't Save Metadata

    Scheduled Pinned Locked Moved ControlBlock, PowerBlock & Co.
    mausberry
    251 Posts 10 Posters 95.8k Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • cyperghostC
      cyperghost
      last edited by cyperghost

      @barrymossel I knew I made promise do not interact with this code by maybe you can try this one 1.57b - it's just a dirty workaround!

      Feel free to test!

      @meleu
      I don't getting it why it does not work.
      In generell I would try to detect PPID and then use ps command to find all PIDs stared by PPID.

      meleuM B 2 Replies Last reply Reply Quote 0
      • meleuM
        meleu @cyperghost
        last edited by

        @cyperghost I think pgrep scummvm (without -f) would be more effective thant that.

        • Useful topics
        • joystick-selection tool
        • rpie-art tool
        • achievements I made
        cyperghostC 1 Reply Last reply Reply Quote 1
        • B
          barrymossel @cyperghost
          last edited by

          @cyperghost said in Mausberry Shutdown Script Doesn't Save Metadata:

          @barrymossel I knew I made promise do not interact with this code by maybe you can try this one 1.57b - it's just a dirty workaround!

          Feel free to test!

          I just started a massive scrape, so I won't turn the RPi off now. Depending on when the scrape ends I will try it later or tomorrow evening.

          1 Reply Last reply Reply Quote 0
          • cyperghostC
            cyperghost @meleu
            last edited by cyperghost

            @meleu said in Mausberry Shutdown Script Doesn't Save Metadata:

            @cyperghost I think pgrep scummvm (without -f) would be more effective thant that.

            OUTDATED !!

            Yes... but I'm finished with that code. But I think using ps as entry to extract PPID should work. So this is a sniplet coded yesterday with annother intention....
            Thank you :)

            What does happen if you use killall command instead of kill -9 or use killall in general?

            @barrymossel

            as meleu alread said pgrep would be the smarter approach!
            I just want to create failsafe methods but they aren't effective in CPU load :)

            so you have to change code line
            [[ "$(pgrep scummvm)" ]] && pkill scummvm
            or if you are just a killer without p
            [[ "$(pgrep scummvm)" ]] && kill "$(pgrep scummvm)"

            Sorry for being inconvinient

            cyperghostC 1 Reply Last reply Reply Quote 0
            • cyperghostC
              cyperghost @cyperghost
              last edited by cyperghost

              @meleu @barrymossel @lostless
              I think that's it

              [[ "$(pgrep -P $emupid)" ]] && kill $(pgrep -P $emupid)

              So I would push to v1.58 give this a try! I tested with a bash that called a bash.... It worked great so far!

              I also updated the ES PID detector. It shows emulator call PID, PID of child processes and ES PID! @barrymossel You can use the PID detector to proof if all PIDs will be proper detected!

              So go... kill'em all (METALLICA??)

              B 1 Reply Last reply Reply Quote 1
              • B
                barrymossel @cyperghost
                last edited by

                @cyperghost said in Mausberry Shutdown Script Doesn't Save Metadata:

                @meleu @barrymossel @lostless
                I think that's it

                [[ "$(pgrep -P $emupid)" ]] && kill $(pgrep -P $emupid)

                So I would push to v1.58 give this a try! I tested with a bash that called a bash.... It worked great so far!

                I also updated the ES PID detector. It shows emulator call PID, PID of child processes and ES PID! @barrymossel You can use the PID detector to proof if all PIDs will be proper detected!

                So go... kill'em all (METALLICA??)

                Will try tonight, when I find the time...! :)

                meleuM 1 Reply Last reply Reply Quote 0
                • meleuM
                  meleu @barrymossel
                  last edited by

                  @barrymossel please test this one: https://ghostbin.com/paste/adsrw

                  It has the same logic as the solution above by @cyperghost , I just cleaned up the code. He will update his post soon.

                  • Useful topics
                  • joystick-selection tool
                  • rpie-art tool
                  • achievements I made
                  1 Reply Last reply Reply Quote 1
                  • cyperghostC
                    cyperghost
                    last edited by cyperghost

                    @meleu I agree - I think version 1.59 is a final version now.
                    But please correct your ghostbin bash... there are small errors in... $emucall isn't definated - it should rather be $emupid

                    @barrymossel It doesn't matter if you use 1.58 or 1.59. The logic is the same only the style of coding is different.

                    Feel free to upgrade to v1.59 -- Final version

                    meleuM 1 Reply Last reply Reply Quote 0
                    • meleuM
                      meleu @cyperghost
                      last edited by

                      @cyperghost said in Mausberry Shutdown Script Doesn't Save Metadata:

                      please correct your ghostbin bash... there are small errors in... $emucall isn't definated - it should rather be $emupid

                      fixed! thanks!

                      emucall is emucall and emupid is emupid. ;-)

                      • Useful topics
                      • joystick-selection tool
                      • rpie-art tool
                      • achievements I made
                      cyperghostC 1 Reply Last reply Reply Quote 1
                      • cyperghostC
                        cyperghost @meleu
                        last edited by cyperghost

                        @meleu
                        No problem brother. I corrected it but used only emupid as variable :)
                        But it is better to repost code according to your latest changes. So there is one version 1.59 around

                        About using variables? You see I'm avoiding these and use just a bunch of them...
                        Is there any difference? Speed up? Memory usage?

                        I know it's better for clear code reading.... but is that effcient?

                        1 Reply Last reply Reply Quote 0
                        • B
                          barrymossel
                          last edited by

                          Sorry guys, I was busy drinking last night so I didn't test yet. Probably won't this evening. Will test later this weekend, but I am sure it works with the two of you working on it :)

                          1 Reply Last reply Reply Quote 0
                          • B
                            barrymossel
                            last edited by barrymossel

                            Yup, seems to work. Thanks guys!

                            1 Reply Last reply Reply Quote 2
                            • lostlessL
                              lostless
                              last edited by

                              @meleu @cyperghost Hey, somthing has happened. The script no longer works in retroarch. This is recent as I just updated and a week ago it worked. so Kodi it kills, and will shutdown emulation station properly if its open, but will no longer kick retroarch back to emulation station to exit. It just says terminated and shuts down without saving meta data. Looks like it just gives up and does the old way of shutting down. also @cyperghost , my reset on my nespi no longer works with retro arch, kodi is fine, because of what ever has happened. WHY DID I UPDATE!!!!! LOL

                              meleuM 1 Reply Last reply Reply Quote 0
                              • meleuM
                                meleu @lostless
                                last edited by

                                @lostless can you please try this approach here?: https://retropie.org.uk/forum/topic/12895/ensuring-es-gracefully-finish-and-save-metadata-in-every-system-shutdown

                                • Useful topics
                                • joystick-selection tool
                                • rpie-art tool
                                • achievements I made
                                lostlessL 1 Reply Last reply Reply Quote 0
                                • lostlessL
                                  lostless @meleu
                                  last edited by lostless

                                  @meleu I’ll take a look when I get home. Just To Verify, this is what I have running in my script. Is this the most up to date?

                                  #!/bin/bash
                                  # Terminate any emulatorcall!
                                  # This works just for RetroPie!
                                  
                                   emucall="$(sed -n 4p /dev/shm/runcommand.info | tr -d '\\"' | tr '^$[]*.()|+?{}' '.')"
                                          if [[ -n "$emucall" ]]; then
                                              emupid="$(pgrep -f "$emucall")" 
                                              pkill -P "$emupid"
                                              kill "$emupid"
                                              sleep 4
                                          fi    
                                  
                                  cyperghostC meleuM 2 Replies Last reply Reply Quote 0
                                  • cyperghostC
                                    cyperghost @lostless
                                    last edited by

                                    @lostless Please use the approach @meleu posted...
                                    The coding is the same but you don't need to modify the shutdown script itself!

                                    1 Reply Last reply Reply Quote 0
                                    • meleuM
                                      meleu @lostless
                                      last edited by

                                      @lostless please, when posting a code like that put it beetween codeblocks. More info here: http://commonmark.org/help/

                                      • Useful topics
                                      • joystick-selection tool
                                      • rpie-art tool
                                      • achievements I made
                                      lostlessL 1 Reply Last reply Reply Quote 0
                                      • lostlessL
                                        lostless
                                        last edited by

                                        Looks like I’m missing the “wait”at the end compared to the script I use for the reset button. I’ll add it in and see if it helps. The issue I’m having though is not meta data related. As I said. When in ES, it funtions fine. It’s just when in retroarch that it no longer exits back to ES. Kodi is fine. It was working fine until yesterday.

                                        1 Reply Last reply Reply Quote 0
                                        • lostlessL
                                          lostless @meleu
                                          last edited by

                                          @meleu heres the script im using now, same issue

                                          #!/bin/bash
                                          # Terminate any emulatorcall!
                                          # This works just for RetroPie!
                                          emucall="$(sed -n 4p /dev/shm/runcommand.info | tr -d '\\"' | tr '^$[]*.()|+?{}' '.')"
                                          # If there's an emulator running, we need to kill it and go back to ES
                                          if [[ -n "$emucall" ]]; then
                                              emupid="$(pgrep -f "$emucall")" 
                                              pkill -P "$emupid"
                                              kill "$emupid"
                                              wait "$emupid"
                                              sleep 5 # maybe it can be lesser
                                          fi    
                                          

                                          and errors im getting trying to exit out of retroarch

                                          pkill: killing pid 1 failed: Operation not permitted
                                          pkill: killing pid 2 failed: Operation not permitted
                                          ./exit.sh: line 9: kill: `': not a pid or valid job spec
                                          ./exit.sh: line 10: wait: `': not a pid or valid job spec
                                          
                                          meleuM 1 Reply Last reply Reply Quote 0
                                          • meleuM
                                            meleu @lostless
                                            last edited by

                                            @lostless are you able to access your raspi via SSH while running an emulator?

                                            If yes, I would like to ask you to do this:

                                            1. launch a game.

                                            2. access your raspi via SSH.

                                            3. perform this command:

                                            bash -x /path/to/the/emulator/killer/script.sh 2> debug.txt
                                            
                                            1. The command above generates the debug.txt file. Post this file on ghostbin or something similar.

                                            Thanks.

                                            • Useful topics
                                            • joystick-selection tool
                                            • rpie-art tool
                                            • achievements I made
                                            lostlessL 1 Reply Last reply Reply Quote 0
                                            • First post
                                              Last post

                                            Contributions to the project are always appreciated, so if you would like to support us with a donation you can do so here.

                                            Hosting provided by Mythic-Beasts. See the Hosting Information page for more information.