Long standing ES bugs

[jdrassa]

@ruckage Thanks for the screenshots. I have fixes for the horizontalMargin and lineSpacing issues, but still need to look into the scaling issue.

For the horizontalMargin, The end of the name may still get chopped off, but it is now consistent. The beginning will always be visible, regardless of alignment, and only the end will be cut off is there is not enough space.

[ruckage]

@jdrassa said in Long standing ES bugs:

@ruckage Thanks for the screenshots. I have fixes for the horizontalMargin and lineSpacing issues, but still need to look into the scaling issue.

For the horizontalMargin, The end of the name may still get chopped off, but it is now consistent. The beginning will always be visible, regardless of alignment, and only the end will be cut off is there is not enough space.

That's great :). The end being chopped off is fine as you can obviously only display as many characters that will fit. I'm not sure I mentioned this originally but will it scroll the text now if the end is chopped off? With the bug it sometimes wouldn't scroll the name even if it was chopped off as it seemed to think that the name was fully displayed if that makes sense (I'm guessing it was only considering the full width of the textlist without accounting for the margins reducing the available width.)

[jdrassa]

@ruckage Yes it will still scroll the text when the end is chopped off. I did see that bug where it wouldn't scroll sometimes and fixed it. Your guess is correct, it was only considering the full width.

[ruckage]

@jdrassa said in Long standing ES bugs:

@ruckage Yes it will still scroll the text when the end is chopped off. I did see that bug where it wouldn't scroll sometimes and fixed it. Your guess is correct, it was only considering the full width.

Thanks. I really appreciate you fixing this, I wasn't expecting anything so quickly.
Any idea when these fixes will appear in retropie itself as I know the line spacing bug fix will definitely break my themes as I modified a font to specifically work around it?

[jdrassa]

@ruckage No timeframe yet. Unless it gives me trouble, I was hoping to fix the scaling issue and submit them all together. If you prefer, I can submit the first 2 fixes sooner. Regardless, I will make sure to post a build beforehand so that you can test it out with your theme.

[ruckage]

@jdrassa said in Long standing ES bugs:

@ruckage No timeframe yet. Unless it gives me trouble, I was hoping to fix the scaling issue and submit them all together. If you prefer, I can submit the first 2 fixes sooner. Regardless, I will make sure to post a build beforehand so that you can test it out with your theme.

No need to rush, it's been a problem for a long while so it's just nice to know that it's going to be fixed.
I'll definitely give the fixed build a test though when it's ready, keep us posted.

[jdrassa]

@ruckage I think I have the scaling issue fixed. I need to clean up the code some and I will get a build for you to test.

[ruckage]

@jdrassa
That's great :). I'd be happy to test it.

[jdrassa]

Fixes are ready for testing.

I tested it against all of themes that are currently installable through RetroPie-Setup. There are a few that have the side effect of the last entry being cut off slightly. Before I submit this I plan to go through and submit the necessary fixes for those themes.

Code is here:
https://github.com/jrassa/EmulationStation/tree/gamelist-fixes

Windows build can be downloaded here:
https://ci.appveyor.com/api/buildjobs/yolhkm014epxeqpk/artifacts/EmulationStation-Win32.zip

[ruckage]

@jdrassa
Fantastic, I'm downloading it now to test, I'll let you know how it goes. I'm expecting my themes to break due to the font hack I'm currently using but that should be an easy fix (just a font change).

[ruckage]

@jdrassa
Sadly seems to have broken my theme. The text now lines up and is spaced exactly as you would expect based on what's in the xml so that's good but the selector bar itself is huge. I've attached a screenshot, before the selector bar would fit within the boxes in the background but now it's much higher than the text and overhangs by a huge margin.

[pjft]

@ruckage Complete tangent on this topic, but your theme looks really good!

[jdrassa]

@ruckage I saw that same behavior. I believe the issue is with your font. The font you are using appears to have a some empty space below the actual characters. I assumed that this is what you had to do to work around the bugs. You mentioned this above.

@ruckage said in Long standing ES bugs:

I know the line spacing bug fix will definitely break my themes as I modified a font to specifically work around it

I disabled your custom font and with a little tweaking to the font size and line spacing I got the following.

[ruckage]

@jdrassa said in Long standing ES bugs:

@ruckage I saw that same behavior. I believe the issue is with your font. The font you are using appears to have a some empty space below the actual characters. I assumed that this is what you had to do to work around the bugs. You mentioned this above.

@ruckage said in Long standing ES bugs:

I know the line spacing bug fix will definitely break my themes as I modified a font to specifically work around it

I disabled your custom font and with a little tweaking to the font size and line spacing I got the following.

Hi, the original font was shifted down below the baseline to make it line up with the selector bar however the screenshot I posted above was with the unedited font. The fonts were designed in bitfontmaker2 which is an online tool for designing pixel fonts.
Obviously I need that font as my theme relies on keeping that particular look. Previously the selector bar was the correct size with my font, it just didn't line up with if I altered the line spacing.

[jdrassa]

@ruckage If you can post a link to the unedited font, I can test it out and see what I can come up with. Currently, the height of the selector bar is 1.5 times the size of the text. This corresponds to the default line spacing. Worst case scenario, I may just need to add an additional theme option to make the selector bar size configurable.

[ruckage]

@jdrassa said in Long standing ES bugs:

@ruckage If you can post a link to the unedited font, I can test it out and see what I can come up with. Currently, the height of the selector bar is 1.5 times the size of the text. This corresponds to the default line spacing. Worst case scenario, I may just need to add an additional theme option to make the selector bar size configurable.

Thanks. Heres a link to the font : http://www.pentacom.jp/pentacom/bitfontmaker2/gallery/?action=dl&id=2639

I actually think having the ability to define the selector bar height would be a real bonus if you could add it - along with an option to change the 'y offset' so that it's vertical position in relation to the text could be set as well. The more we can edit ourselves the better, gives us more freedom with design options.

[jdrassa]

@ruckage I have added <selectorScale>and <selectorOffsetY> options to the textlist. Default values are 1.5 and 0. '<selectorOffsetY>' works like size and position where it is a fractional value based on the screen size.

Updated Windows build:
https://ci.appveyor.com/api/buildjobs/m089lslea07kxe1i/artifacts/EmulationStation-Win32.zip

[ruckage]

@jdrassa said in Long standing ES bugs:

<selectorOffsetY>

Thanks, those new options work brilliantly - perfect, I love it. It's really nice to have that extra control.

Are the <horizontalMargin> fixes in this build as well? I only ask because when the name scrolls it's still not scrolling enough to show the end of the game name.

Are the scaling fixes in place as well? If so I'll test that next.

Thanks again.

@pjft said in Long standing ES bugs:

@ruckage Complete tangent on this topic, but your theme looks really good!

Sorry for not replying sooner. Thank you, it's really nice to know people like it. It's been far more popular than I expected. It was made for personal use originally and only covered, nes and gameboy but has grown dramatically.

[jdrassa]

@ruckage The build should have had fixes for all 3 of the issues that you called out, but I retested and you are correct that it still wasn't scrolling enough. I have a new build running and will post a link when it is done.

[ruckage]

@jdrassa
Thanks.
I'll check the scaling next then and give feedback on how that's working.