Request: Add an Instant Transition [SOLVED]

Hex

@jdrassa said in Request: Add an Instant Transition:

@Hex I haven't tested it yet, but I don't think the power saver flag is going to work properly. On startup, getGameListView is called for each system and the view is cached. As implemented, I believe the power saver flag will be set based on the last view created vs. the current view. Instead of setting and returning a boolean, you could test the name of mCurrentView to see if it is video.

Now I understand what you mean. Currently my setup is such that if you have even a single video then the power saver is not implemented. I am not going to mess with video back-end as they are implementing OMX player support.

I am trying to figure out where power saver needs to be disable for proper functionality.

jdrassa

@Hex I would try to enable it here:
https://github.com/hex007/EmulationStation/blob/master/es-app/src/views/ViewController.cpp#L118

That is where the current view is set. The tricker part if figuring out if mCurrentView is a video view. You should be able to check using getName, but you will need to cast it first.

You will also want to set mPowerSaver to false here, since SystemView does not have video.
https://github.com/hex007/EmulationStation/blob/master/es-app/src/views/ViewController.cpp#L75

Hex

@jdrassa This was really helpful. I have implemented the changes here.

https://github.com/hex007/EmulationStation/commit/fd613418a04630c64a0e3e58170202f7dafcef9c

mCurrentView is instance of GuiComponent which doesnt have getName()
getGameListView(system) returns IGameListView (Child of GuiComponent) which does.

@TMNTturtlguy Thanks for all the help, now you can test what mode it is on in Menu where it shows ES version

Hex

@Capeman I apologise for hijacking your thread like this.

I have finished incorporating what you wanted. Looks like this

robertybob

@Hex love it!

TMNTturtlguy

@hex - nice work! The video is now playing perfectly. The Instant and None transitions are realy cool and they both work so well. I am excited to try to build a new theme based on this.

You may want to look into the screensaver on your build. They are not currently working.

Thanks so much for coming up with the new transitions. I now this takes a lot of time. Again, if you have the time and desire, it would be really cool if you submitted a PR to the man branch to incorporate the "instant" and "none" transitions. I know they would be really well recieved by the community.

Great work and have a good weekend. Keep me posted on if you every need any help testing your builds, i have you in my es-tests script, so it is easy for me to do.

pjft

@TMNTturtlguy @Hex I agree, as well as the remaining changes as compiler, command line or menu options.

It's always great to have more talented developers around, and if you're keen on optimizing emulationstation, there's quite a few people here who are looking into similar problems so the more the merrier!

Also, for the Pi 0 and 1, we'll hopefully have OMX player as an option for videos on the main branch, so that should interest you!

Hex

@TMNTturtlguy @pjft The only thing stopping me from submitting a PR is not knowing how to. My branch is several commits ahead. I have minimal exp with git.

Also do you know of any OMX build. I would like to incorporate that over the weekend.

pjft

@Hex I do. You can cherry pick my 2 last commits from my RetroPie OMX player branch (something like that).

Sure, happy to help with that. I don't have a lot of experience with git either, but I'm happy to help you with a scrappy-and-completely-unofficial-and-hacky guide to making things happen in git.

Maybe I'll write a small post here in the forums with what I've learned so far, hoping it helps. I hope it won't come across as preachy or make people think I know best or more than others, as that's both false and I'm far from an authority in anything!

That being said, if it'd help (and if it won't damage people from hearing things done by someone who doesn't know much about git) I'll try to do it in the coming days.

EDIT:

And, by cherry pick, I literally mean you should checkout my repository and try that.

Or alternatively you can fork it, and then submit a PR from it to your own repository?

Keeping the original commits is nice for authorship and tracking changes. In this case, the bulk of the work was done by @fieldofcows - I just worked on top of it to fix a few things and then worked further on the video screensaver front (which is not yet available, but should be soon).

That being said, my strong recommendation is to try to push things to the main repository, where they make sense.

Hex

@TMNTturtlguy said in Request: Add an Instant Transition:

@hex - nice work! The video is now playing perfectly. The Instant and None transitions are realy cool and they both work so well. I am excited to try to build a new theme based on this.

You may want to look into the screensaver on your build. They are not currently working.

I am looking into screersaver support.

Hex

Due to popular demand I have sent a Pull Request for Instant and None transitions. Its all upto @BuZz now.

Capeman

@Hex said in Request: Add an Instant Transition:

@Capeman I apologise for hijacking your thread like this.

I have finished incorporating what you wanted. Looks like this

That is EXACTLY what i was looking for! WOW that's great! Thanks for working on that!!

Hex

@Capeman Let me know if you have any more ideas

Capeman

@Hex said in Request: Add an Instant Transition:

@Capeman Let me know if you have any more ideas

I had this one, but nobody seemed to interested, haha. It is a pretty niche idea with limited applications, but i could see where it could be useful.

https://retropie.org.uk/forum/topic/10505/request-option-to-disable-carousel-in-es-ui-options

Hex

@Capeman This would be easy to implement. I shall post comments in that thread

Syhles

@Hex
I have a request, currently with metadata we have the option to use md_image, md_marquee(not sure of the code lol), and md_video(same). It would be nice if we could also use the marquee on the detailed view, also I would love to have a md_snapshot or md_screenshot.

I feel like that would slightly open up what kinds of themes are possible.

But, I neither code or understand how ES handles images, so I'm not sure of the feasibility of this. These are just my requests/opinions of someone who fiddles with themeing occasionally.

Hex

@Syhles I am not into theme development on ES side. If you can show me what you mean using figures I might be able to help

AlexMurphy

@Capeman Hey, I actually think that is a very good idea. There really is no need for each system to have its' own "Front door", as such. You are right, it's eye candy. People like candy though, you should ask my dentist...

Syhles

@Hex
I'm not at a computer right now so I'll try my best to explain it more clearly and with more detail.

As far as I know at this time in the detailed view of ES we can use an md_image which is a metadata image, typically when your games are scrapped it will be the boxart or cover for the game.

In video view you have two metadata tags you can use md_marquee and md_video I'm not sure if those are the correct tags via XML. But regardless the md_marquee is typically an image of the games logo (see hyperspin's wheel) this as far as I know can only be used in video view I would like to also be able to use it in the detailed view. The video tag is fine staying in the video view, if it was able to be used in the detailed view it would make the video view pointless.

The screenshot thing I was talking about, think of the back of a video game case usually the little images of in-game scenes (essentially a screenshot) I would like to be able to use something like md_screenshot in my theme XML to have in-game images show up if I have them.

Currently when in ES you can edit a games metadata, at the bottom of the list there are like 4-8 fields of images plus 1 video field that can be used for each game, at this time even though those fields are there only the video field and two of the image fields can be used. In the Detailed view only one image field actually works. It would be great if they all actually displayed images.

Ideally to me ES would eventually allow themers to make their own views via XML with access to all of the metadata fields available to us.

Hope this was easier to follow if you need clarification on anything feel free to ask, I'll try to explain to the best that I can. Thanks for hearing me out even if nothing comes from this discussion.

Hex

@Syhles Please open a new thread for this and post all the explanation there thus keeping things clean