Would you like to play Nokia (J2ME) games on Retropie?

[recompile]

@hex said in Would you like to play Nokia (J2ME) games on Retropie?:

Firstly I am adding rotation support for frames.

That's fine, I'm just not sure why we'd want/need it? Not very many games detect orientation, but those that do base it on the screen resolution and detect those changes by overriding the sizeChanged method on Displayable. (It's the only way to detect orientation changes.) Changing orientation, then, requires changing resolution. Changing resolution means killing sdl_interface and starting it again, so we wouldn't need to rotate there anyway.

@hex said in Would you like to play Nokia (J2ME) games on Retropie?:

Another thing to note is these joysticks are capable of moving in two dimensions so will fire two events if moved diagonally.

Yep. If you press up/left you'll generate an "up pressed" and a "left pressed". If the user slides their thumb so they're only moving up, you'll fire a "left released" The games don't know about gamepads, so J will convert those to the relevant key events.

[Hex]

I downloaded a game with landscape resolution and it still displays as portrait but is to be viewed from the left. This is for games made for devices with unconventional screen placements. It is quite easy and handled by SDL.

Regarding the joystick , it might take some time (20 mins). I am looking at how ES handles these things so if the code is usable I will just copy and modify that.

[recompile]

@hex said in Would you like to play Nokia (J2ME) games on Retropie?:

I downloaded a game with landscape resolution and it still displays as portrait

I have a few games like that. Rotating the image, however, won't make any difference. From the games perspective, nothing has changed.

The only way to tell the game that the device is on its side is to change the resolution. J2ME doesn't have a concept of 'orientation'. As I explained above, games that want to watch for orientation changes must override the Displayable sizeChanged method and infer orientation based on changes to the display resolution.

If you're running a game in 240x320, and the game expects landscape, the only way to change that is to change the resolution to 320x240.

I appreciate that it's easy to add rotation, but it's not going to add any value. Remember, the game has no idea that the image is being rotated. You can see this for yourself by rotating frames from J 90 degrees. If the game was in portrait, it will still be in portrait, just rotated 90 degrees. Running a landscape game in 240x320 rotated 90 degrees will still look the same, it'll just be on its side.

[Hex]

@recompile I have got all events to be binary now including the joysticks. I will tidy up the code and let you know once it is ready.

I will be testing the rotation too. Now that i have a sample if it works then its in as a feature else i will just discard that code.

[recompile]

@hex Out of curiosity, what is the game you want rotated?

[Hex]

@recompile Asphalt6 (480x800)

Rotation is proving to be much difficult that anticipated. Working on this till I get controller back

Also I lost the Xbox controller. Cant have it back till the little bro finishes playing Minecraft :|

[recompile]

@hex I see what you mean now. Rotation makes sense for those cases.

[Hex]

@recompile Can we change the parameter to not need the file:// part ?

So you could have -f ./Asphalt6.jar
else -u http://.....

[recompile]

@hex Probably, but the only people who will see it are you and I. Everyone else will launch games from ES. Are you just looking to use relative paths, or are you just sick of typing the whole path every time?

[Hex]

@recompile Sick of typing. File:// does not auto complete so while trying different games for testing i have to copy paste or type very carefully. defeats the purpose of running it from terminal.

suggested changes would be much better. Very few will leverage "-u" option anyways so it will make testing easier.

[recompile]

@hex I just use a shell script:

#!/bin/sh
java -jar freej2me-rpi.jar file:/home/pi/RetroPie/roms/j2me/ShadoWalker.jar 240 320

I have nine or so named like test.sh, test2.sh, nokia.sh, etc. for whatever I'm looking to check at the moment. It saves a lot of time and typing.

Also, pressing up on the command line will scroll through previous commands. Very handy.

I like simple.

[Hex]

Can it be please modified to take shell paths like /home/hex/a.jar or ./a.jar or a.jar

Syntax wise I am thinking this

java -jar freej2me.jar file/url W H [-r 90] [-i interpolation]

[recompile]

@hex Yes, but it adds a lot of unnecessary complexity, can be very fragile, and still ambiguous. Is the path intended to be relative to the current working directory or the location of the jar file?

I like simple. I see this as adding complexity without adding any value.

Simplicity is actually the reason why it takes a url instead of a 'normal' path. It was simpler to implement and required less code.

To your specific problem: It looks like you just want to reference a file in the current directory. Here's how you do that:

java -jar freej2me.jar file:./a.jar

@hex said in Would you like to play Nokia (J2ME) games on Retropie?:

Syntax wise I am thinking this

That's fine. How do you want to receive it on the C side? Just W H R I?

[Hex]

@recompile Got xbox controller back. Updated C sources. Check it out and let me know if it works as expected or creates any unexpected errors.

[Hex]

@recompile said in Would you like to play Nokia (J2ME) games on Retropie?:

That's fine. How do you want to receive it on the C side? Just W H R I?

W H I [R]

R is optional

@recompile said in Would you like to play Nokia (J2ME) games on Retropie?:

Is the path intended to be relative to the current working directory or the location of the jar file?

Always relative to working directory

~/ > ls
--> jsdl/    games/    music/    videos/     roms/

~/ > java -jar jsdl/freej2me.jar games/Asphalt.jar W H 

[recompile]

@Hex A couple things:

Most importantly, it doesn't compile on my pi3.

sdl_interface.cpp: In function ‘void removeJoystick(SDL_JoystickID)’:
sdl_interface.cpp:60:10: error: ‘axisIt’ does not name a type
    auto axisIt = mPrevAxisValues.find(joyId);
         ^
sdl_interface.cpp:61:14: error: ‘axisIt’ was not declared in this scope
    delete[] axisIt->second;
             ^
sdl_interface.cpp:65:10: error: ‘joyIt’ does not name a type
    auto joyIt = mJoysticks.find(joyId);
         ^
sdl_interface.cpp:66:8: error: ‘joyIt’ was not declared in this scope
    if(joyIt != mJoysticks.end())
       ^

Still important, it's over-complicated. You've made things more difficult for yourself.

Why are you storing the previous axis value and not the previous normalized value? It makes things much more complicated than they need to be. By storing the normalized value, you won't need 'deadzone' at all. Try something like this:

// Normalize
normValue = 0; 
if(event.jaxis.value > 0)
{
   normValue = 1;
}
else if (event.jaxis.value < 0)
{
     normValue = -1;
}

Next, you can compare your normalized values to the ones previously stored. How you store them is up to you, but it will affect how you compare them later.

Keeping things similar to how you're doing things already, let's assume you'll store them like this after the compare:

mPrevAxisValues[event.jaxis.which][event.jaxis.axis] = normValue; 

Comparing the old value to the new value to send pressed and released events:

// Remember that the UD axis is 0, LR is 1 
// axisShift will let us pack UDLR neatly in to the event key value
// resulting i: UP - 8, Down - 4, Left - 2, Right - 1
axisShift = event.jaxis.axis * 2;

oldValue = mPrevAxisValues[event.jaxis.which][event.jaxis.axis];
if(oldValue != normValue)
{
    // DPad Button Released
    if(oldValue ==   1) { sendKey(4, 2<<axisShift); } // Up, Left
    if(oldValue ==  -1) { sendKey(4, 1<<axisShift); } // Down, Right
    // DPad Button Pressed
    if(normValue ==  1) { sendKey(5, 2<<axisShift); } // Up, Left
    if(normValue == -1) { sendKey(5, 1<<axisShift); } // Down, Right
}

My example uses a simplified Send Key:

void sendKey(int eventType, int key)
{
 unsigned char bytes [5];
 bytes[0] = (char) eventType;
 bytes[1] = (char) (key >> 24);
 bytes[2] = (char) (key >> 16);
 bytes[3] = (char) (key >> 8);
 bytes[4] = (char) (key);
 fwrite(&bytes, sizeof(char), 5, stdout);
}

Smaller is not always better. I tend to put readability over compactness. I've never regretted those decisions, but I have lots of regrets related to those times when I put compactness over readability.

[Hex]

@recompile You can use this flag while compiling -std=c++11. My gcc supports is automatically. On pi you might need to add that flag.

I copied code from ES. Even if i changed it later the output would remain same hence i did not optimize then (2am)

void sendKey(int key, bool pressed, bool joystick)
{
	unsigned char bytes [5];
	bytes[0] = (char) 2 * joystick + pressed;

Is quite self explanatory

Byte shifting is not easily visualisable for me.

I shall make the changes but I will keep the send key. I am thinking of changing the following line

bytes[0] = (char) 2 * joystick + pressed;
to
bytes[0] = (char) (joystick << 16) + pressed;

so we have
00,01,10,11

Should that be ok?

[Hex]

@recompile said in Would you like to play Nokia (J2ME) games on Retropie?:

Why are you storing the previous axis value and not the previous normalized value? It makes things much more complicated than they need to be. By storing the normalized value, you won't need 'deadzone' at all. Try something like this:

deadzone will always be needed as it is a cutoff threshold. If we dont have a cutoff even slight movement of analog stick will spew unnecessary events.

[Hex]

@recompile said in Would you like to play Nokia (J2ME) games on Retropie?:

// DPad Button Released
if(oldValue ==   1) { sendKey(4, 2<<axisShift); } // Up, Left
if(oldValue ==  -1) { sendKey(4, 1<<axisShift); } // Down, Right
// DPad Button Pressed
if(normValue ==  1) { sendKey(5, 2<<axisShift); } // Up, Left
if(normValue == -1) { sendKey(5, 1<<axisShift); } // Down, Right

I dont understand why you are ending 4 and 5

[Hex]

@recompile I have updated the source. Can you update it.

To compile :
g++ -std=c++11 -lSDL2 -lpthread -o sdl_interface sdl_interface.cpp