Mausberry Shutdown Script Doesn't Save Metadata

cyperghost

@meleu Ready for quick'n'dirty coding? :)

what about a kill $(expr $emupid + "1")
of course you check before if pid is active :)

meleu

@cyperghost that behavior reported by @barrymossel was the reason why I was killing the emulator with -9 (SIGKILL). When you kill a bash script with SIGKILL it kills all its child processes.

But I realized that this isn't a good approach for retroarch, because it wouldn't save the .srm file...

Looks like there are room for more improvements on that script. Will post something soon. (edit: or maybe you can do it yourself: just check if the first string on that 4th line is bash, if yes, kill the process with -9)

barrymossel

Ehm, I was wondering: does it even matter that ScummVM doesn't exit to ES before shutdown? Is there any ScummVM meta data anyway? Or wouldn't meta data from games you played before ScummVM be saved either?

meleu

@barrymossel said in Mausberry Shutdown Script Doesn't Save Metadata:

Or wouldn't meta data from games you played before ScummVM be saved either?

Yes for this question.

cyperghost

@meleu Hmm... and if you make case selection?
Are you sure there are no other caveeats? I must admit I'm not very common with the how to kill-a-process method.

okay... I will try :)
It's not tested, i have no access to my Pi now... So just coded out of brain (Please make the code look better... I use lot's of ifs.... much to much!)

emupid="$(sed -n 4p /dev/shm/runcommand.info | tr -d '\\"' | tr '^$[]*.()|+?{}' '.')"
emu_com="$("${emupid%% *}")"
emupid="$(pgrep -f "$emupid")" 

if [[ "$emu_com" == "bash" ]] && [[ "$emupid" ]]; then
    kill -9 $emupid && sleep 4
fi

You've to check also the PID.... because runcommand.info isn't deleted in ES caroussel mode after emulator is running :)

cyperghost

@barrymossel That's the question. You will losse all your progress in metadata saving if anything goes wrong.

But to be true.... I'm satisfied with 1.56 - the rest are rare usecases (imho)

cyperghost

@meleu
Annother suggestion

[[ "$(ps -p $(expr $emupid + "1") -o comm=)" == "scummvm" ]] && kill $(expr $emupid + "1")

That's the way I would do... this is just an idea...
I tested this ... worked to kill one additional process with name "scummvm" but I'm not sure if this will always work!

meleu

@barrymossel Can you please test this script here: https://ghostbin.com/paste/a29wx

edit: I mean, test with ScummVM. ;-)

barrymossel

@meleu said in Mausberry Shutdown Script Doesn't Save Metadata:

@barrymossel Can you please test this script here: https://ghostbin.com/paste/a29wx

edit: I mean, test with ScummVM. ;-)

Nope, didn't exit to ES and did not save lastplayed from game I started before.

cyperghost

@barrymossel I knew I made promise do not interact with this code by maybe you can try this one ~~1.57b - it's just a dirty workaround!~~

Feel free to test!

@meleu
I don't getting it why it does not work.
In generell I would try to detect PPID and then use ps command to find all PIDs stared by PPID.

meleu

@cyperghost I think pgrep scummvm (without -f) would be more effective thant that.

barrymossel

@cyperghost said in Mausberry Shutdown Script Doesn't Save Metadata:

@barrymossel I knew I made promise do not interact with this code by maybe you can try this one 1.57b - it's just a dirty workaround!

Feel free to test!

I just started a massive scrape, so I won't turn the RPi off now. Depending on when the scrape ends I will try it later or tomorrow evening.

cyperghost

@meleu said in Mausberry Shutdown Script Doesn't Save Metadata:

@cyperghost I think pgrep scummvm (without -f) would be more effective thant that.

OUTDATED !!

Yes... but I'm finished with that code. But I think using ps as entry to extract PPID should work. So this is a sniplet coded yesterday with annother intention....
Thank you :)

What does happen if you use killall command instead of kill -9 or use killall in general?

@barrymossel

as meleu alread said pgrep would be the smarter approach!
I just want to create failsafe methods but they aren't effective in CPU load :)

so you have to change code line
[[ "$(pgrep scummvm)" ]] && pkill scummvm
or if you are just a killer without p
[[ "$(pgrep scummvm)" ]] && kill "$(pgrep scummvm)"

Sorry for being inconvinient

cyperghost

@meleu @barrymossel @lostless
I think that's it

[[ "$(pgrep -P $emupid)" ]] && kill $(pgrep -P $emupid)

So I would push to v1.58 give this a try! I tested with a bash that called a bash.... It worked great so far!

I also updated the ES PID detector. It shows emulator call PID, PID of child processes and ES PID! @barrymossel You can use the PID detector to proof if all PIDs will be proper detected!

So go... kill'em all (METALLICA??)

barrymossel

@cyperghost said in Mausberry Shutdown Script Doesn't Save Metadata:

@meleu @barrymossel @lostless
I think that's it

[[ "$(pgrep -P $emupid)" ]] && kill $(pgrep -P $emupid)

So I would push to v1.58 give this a try! I tested with a bash that called a bash.... It worked great so far!

I also updated the ES PID detector. It shows emulator call PID, PID of child processes and ES PID! @barrymossel You can use the PID detector to proof if all PIDs will be proper detected!

So go... kill'em all (METALLICA??)

Will try tonight, when I find the time...! :)

meleu

@barrymossel please test this one: https://ghostbin.com/paste/adsrw

It has the same logic as the solution above by @cyperghost , I just cleaned up the code. He will update his post soon.

cyperghost

@meleu I agree - I think version 1.59 is a final version now.
But please correct your ghostbin bash... there are small errors in... $emucall isn't definated - it should rather be $emupid

@barrymossel It doesn't matter if you use 1.58 or 1.59. The logic is the same only the style of coding is different.

Feel free to upgrade to v1.59 -- Final version

meleu

@cyperghost said in Mausberry Shutdown Script Doesn't Save Metadata:

please correct your ghostbin bash... there are small errors in... $emucall isn't definated - it should rather be $emupid

fixed! thanks!

emucall is emucall and emupid is emupid. ;-)

cyperghost

@meleu
No problem brother. I corrected it but used only emupid as variable :)
But it is better to repost code according to your latest changes. So there is one version 1.59 around

About using variables? You see I'm avoiding these and use just a bunch of them...
Is there any difference? Speed up? Memory usage?

I know it's better for clear code reading.... but is that effcient?

barrymossel

Sorry guys, I was busy drinking last night so I didn't test yet. Probably won't this evening. Will test later this weekend, but I am sure it works with the two of you working on it :)