Chicuelo Theme

movisman

Nice! That looks great too, better than mine (which is just a rework of that other PNG we both had). Maybe you could put 'alpha' on a separate line to make the logo more square so it fits better within the theme?

chicuelo

@movisman
I thought about it, but the word alpha will become HUGE and I think the logo will become bold as fuck :P

movisman

@chicuelo

Hmmm, i'm not too sure what you mean? So just placing the word Alpha underneath, on the same SVG, same size as it is now? Not sure on position though, either the word "alpha" in the centre or right justified underneath. Unless i'm confused it should look ok? Are you suggesting the logo would become too large because it's square?

This is where a maximum height in theme.xml comes in, which is what i've adjusted on my local copy (which is also on that video preview I sent). It reduces the size of square logos like Master System which look a bit too big at the moment, but keeps the width of the wider ones.

However, all that being said, all on one line is still likely to display fine (and looks better in general), as a lot of other systems are a similar width and they look ok. Have you got the SVG handy and I can install it?

Cheers!

chicuelo

@movisman said in Chicuelo Theme:

ither the word "alpha" in the centre or right justified underneath. Unless i'm confused it should look ok? Are you suggesting the logo would become too large because it's square?
This is where a maximum height in theme.xml comes in, which is what i've adjusted on my local copy (which is also on that video preview I sent). It reduces the size of square logos like Master System which look a bit too big at the moment, but keeps the width of the wider ones.
However, all that being said, all on one line is still likely to

What I want to mean is that the Alpha word would be super big under the final burn text, so the logo will be a little bit heavy as a logo. If you prefer I can send you the SVG file and you make the proportions you want

movisman

@chicuelo

Ah ok, so what I meant is the same as the image you posted but with the 'alpha' the same size as 'final burn'. With my modified theme.xml it should not appear too large but would need to try it.

I am happy with whatever logo you choose for FBA - it's your theme of course and you are much better at design than I am!! :) the original one on a single line will look fine i'm sure. I am just happy to contribute where I can to help complete some of the other systems and tidy up the XML where possible.

How would you like me to provide all the logos I created? Do you want me to email them to you or post up a download? Or raise a PR on github? I also have a slightly modified theme.xml which makes my 'no-margin' logos appear nicely.

Thanks!

chicuelo

@movisman
We can make a PR via GitHub. If you want, get the latest version and then apply your changes so I can pull them again.
You will find the new FBA logo if you update your branch

cosmo0

@chicuelo @movisman
I love these new logos :) I was planning to make a pull request to add the MAME and FBA logos, I'm glad people with better design skill than me got to it :)

On a very personal note, I would also love to have different images for the various arcade emulators :)
On a pi, I have heard FBA is best for most shmups and fighting games, whereas MAME is better to emulate 80's arcade.
So, I would put Ryu as the FBA character, and Donkey Kong as the MAME character.

Ryu : here with many more here.
DK : here, here or here

I would do them myself, but I clearly don't have the skill to integrate the characters as well as you do with the background, and the other images.

chicuelo

@cosmo0
For mame what do you think about sunset riders, Cadillacs and dinosaurs or ghouls and ghosts? I thinks they are going to fit better with the theme due the background posibilities.

cosmo0

Ghouls and Ghosts would be nice :)
SR and C&D are more FBA-type games I think.

movisman

@cosmo0

I loved Cadillacs and Dinosaurs - great game and a definite vote from me for FBA :)

@chicuelo

I will raise a PR for my changes, just trying to learn some basic github command line stuff, will create a branch, put all my changes in and raise the PR for you to inspect.

Cheers!

cosmo0

@movisman said in Chicuelo Theme:

I will raise a PR for my changes, just trying to learn some basic github command line stuff, will create a branch, put all my changes in and raise the PR for you to inspect.

From the top of my head:

git remote add source urlofchicuelogit
git fetch source
git rebase source/master

Sorry but I can't add the URL of the Chicuelo git or my post is flagged as spam.
This adds the Chicuelo git repository as a "remote" (a server), then fetches and reapplies all modifications made to it, then reapplies your modifications

git checkout --branch nameofyourbranch

This creates a branch for you to work on.
Then do your modifications.

git add .
git commit -m "your commit message"
git push -u origin nameofyourbranch

This adds all files to the commit (staging area), commits it, then pushes it to your Github repository. The -u is shorthand for --set-upstream and lets you just "git push" next time witout specifying the remote and branch names.

Then create your pull request in Github.

Hope this helps :)

movisman

@cosmo0

Hey, thanks a lot for that - most useful! I wish I had seen some of this an hour ago as been reading how to do it via command line, and in fairness, I have pretty much exactly done exactly the above, with the exception of the first bit. I cloned the repository from my fork, then added Chicuelo's master as upstream.

I then created a branch called updates, switched to that, copied my changes in, and now i've pushed those to the remote. I was just about to raise a PR now.

Sound about right?

I didn't do the git rebase stuff, what is the benefit of using this?

Cheers!

movisman

@chicuelo

Okay! So you should have a PR now here:
https://github.com/chicueloarcade/es-theme-Chicuelo/pull/4

The description contains all details about files changed.

Hope you can merge this into master, then I will delete this branch.

Thanks!

cosmo0

@movisman said in Chicuelo Theme:

@cosmo0
Sound about right?

Yep, with git there are multiple ways to achieve the same result, yours is fine too.

I didn't do the git rebase stuff, what is the benefit of using this?

I was assuming you already had cloned the repository and made changes. Fetch/rebase (or pull) get the latest commits from a remote and apply them to your local copy.

movisman

@cosmo0

Gotcha, thanks for this - still learning Git basics locally as the changes I made before regarding the videos were made via copying in the revised XML to my fork directly on the Github website, and then raising a PR accordingly.

I wanted to get a local clone all sorted so it was easier to work on changes while still being able to pull latest commits, etc, etc. I think i'm there now though. This guide was pretty useful when I was first reading up as it sticks to basics:
https://codeburst.io/a-step-by-step-guide-to-making-your-first-github-contribution-5302260a2940

I'll do a bit more reading about rebase/merge/fetch/pull etc etc to understand some of the differences. Looks like a rebase would be a good command to use.

Cheers for the help!

cosmo0

Git can be pretty intimidating at first, and it's very complicated (even when you've learned a lot :D ).
But it's very powerful, and once you enter the "git mindset", you find simpler versionning systems (like SVN) too limiting.

chicuelo

@cosmo0 @movisman
Done the merge,
What do you think about FBA and mame?
I have a doubt, for libretto emulator, the corresponding image is mame or just arcade?

I am working on a fba version with Cadillacs and dinosaurs but there are few images so I have to draw my own character. I will upload soon for you to tell which is better

Mame

FBA

movisman

@chicuelo

Wow, those look incredible! Really, really great work. So clean. Very much looking forward to seeing a Cadillacs and Dinosaurs image!

So regarding your question about Arcade/MAME, etc.

Arcade is a special folder, which people can use to avoid having several menus for different arcade emulators - essentially all arcade-based ROMs can be placed in the arcade ROM folder and ran from there, which is what I currently do.

I would suggest the following image requirement for each ROM folder/menu/theme.xml for arcade games:

arcade = arcade logo and arcade character image
mame-libretro, mame-mame4all, mame, mame-advmame = mame logo and mame character image
fba = fba logo and fba character image
neogeo = neogeo logo and neogeo character image

Does that make any sense? Not sure if I have explained too well.

Cheers

P.S. Thanks for merging my changes, will update my copy when I get home and check it out.

cosmo0

@chicuelo wow. So awesome <3 The Ghouls & Ghosts image is incredibly gorgeous. Seriously. I love it.

cosmo0

@movisman said in Chicuelo Theme:

mame-libretro, mame-mame4all, mame = mame logo and mame character image
mame-advmame = advmame logo (needs creating), and maybe a new advmame image - or just the mame character image if not

You would split mame-advmame and the other mame-s? Why is that?