OXM Player"s origin-x locked to 0.5?

pjft

@wildwolfofmibu uploading it to GitHub or to a Dropbox/Google drive folder and sharing try is probably the best way.

WildWolfOfMibu

https://www.dropbox.com/s/5i7f9hfhu2cczf0/ww-theme.zip?dl=1

pjft

I can't replicate it. Things work fine for me in both OMX and VLC. I'll take some screenshots later.

These are my debug logs, for the same videos, on both OMX and VLC, both show up fairly similar. I tested it on GBA, GB and GBC.

I'm starting to think it's down to your videos. Can you re-encode one of them and test them? There is a difference in VLC and OMX Player in regards to aspect ratios - VLC will do pixel for pixel, I believe, whereas OMX Player will respect the aspect ratio. That's not going to create a big difference in the rendering, but it may make videos look slightly different. It shouldn't affect their position, though, certainly not what you show in your screenshots.

By the way, the theme looks great!

lvl0: 	Position: x: 1488 - y: 176.04
lvl0: 	Origin: x: 1 - y: 0
lvl0: 	Size: x: 496.8 - y: 496.8
lvl0: 	Position: x: 1488 - y: 176.04
lvl0: 	Origin: x: 1 - y: 0
lvl0: 	Size: x: 496.8 - y: 496.8


lvl0: 	Position: x: 1728 - y: 176.04
lvl0: 	Origin: x: 1 - y: 0
lvl0: 	Size: x: 745.5 - y: 497
lvl0: 	Position: x: 1728 - y: 176.04
lvl0: 	Origin: x: 1 - y: 0
lvl0: 	Size: x: 745.2 - y: 496.8

lvl0: 	Position: x: 1488 - y: 176.04
lvl0: 	Origin: x: 1 - y: 0
lvl0: 	Size: x: 496.8 - y: 496.8
lvl0: 	Position: x: 1488 - y: 176.04
lvl0: 	Origin: x: 1 - y: 0
lvl0: 	Size: x: 496.8 - y: 496.8
lvl0: 	Position: x: 1488 - y: 176.04
lvl0: 	Origin: x: 1 - y: 0
lvl0: 	Size: x: 496.8 - y: 496.8

EDIT: I'll test the PC Engine one later.

pjft

I didn't manage to test it further yet, but I'd ask you for something if you have the ability to test it.

I put together a test build for this specific issue a few weeks back. Could I ask you to test it and send over the logs? They'll be similar to the ones I just shared. The repository is

https://github.com/pjft/EmulationStation/tree/omx-coordinates

But you can install it and test it by exiting ES and following these instructions from the command line:

git clone --recursive https://github.com/pjft/EmulationStation ES-pjft
cd ES-pjft
git checkout omx-coordinates
cmake .
make
./emulationstation

and then test one of those scenarios with both VLC and OMX Player, both with screenshots so I can try to understand what may be happening.

Thanks.

pjft

Ok. Your PC Engine theme section does exhibit such a behavior. Thanks.

I'll try to dig into it.

pjft

Ok, so here's the thing:

After thoroughly testing this and going through some debugging efforts, I see what you mean. Unfortunately, you won't be able to use OMXPlayer with maxSize and an origin other than center.

https://elinux.org/Omxplayer

The only two options that can really be used here are letterbox (i.e. centered) and stretch (take up the entire designated area). There's no setting for origin there.

The reason why you see the video moving is exactly because you have a wide area designated for the video to be rendered on, and it'll be centered if you use OMX Player.

My recommendation would be, like in other themes, to pick the right video area depending on the expected aspect ratio of the different systems. That shouldn't be hard to get asides from the Arcade videos, which can be more finicky.

Alternatively - or in conjunction - you can use a black area like the Artbook theme uses as a background for the video area so that, even if the video has a different size, it'll always look "consistent" rendered in the center with the black area to make up for it (as a letterboxed movie). Or use "size" instead of maxsize and pick aspect ratios/dimensions that better match the system you're going for, once again.

Apologies for the answer here, but that's really all there is to it in this case.

Best of luck with the theme, though - it's looking really great!

WildWolfOfMibu

Thanks for the info, I guess I was right in my first diagnosis about the origin being locked to the center after all SMH.

This sounds like one of those issues that's a "bug" if you're an end-user and a "design limitation" if you're a developer. At the least, I think it should be noted in the emulationstation themes documentation on github.

I'll start by setting my videos to just have an origin on 0.5,0.5 so that the OMXPlayer and the VLC Player are at least consistent. Then I'll try to figure out if there's a more elegant solution later on.

Best of luck with the theme, though - it's looking really great!

Thanks, but like I said, I'm just tinkering with the layout of the defunct Cygnus theme, so I really can't take credit for 95% of it (you can see that I haven't touched the credits in the header comments in the common.xml file).