[Theme] gameOS for Pegasus

fastpop72

@PlayingKarrde For the video preview i have some vertical aligned videos (240x320) and i'd like to have a vertical scanline overlay during video preview in the theme for these videos.

It's possible to retrieve the height/width of the current mp4 and select a horizontal or vertical overlay png?

Something like this:

Image
  {
    id: overlay
    anchors.top: parent.top
    anchors.left: parent.left
    source: if (???????.videos.heigth > ????????.videos.width) {"./assets/images/scanlines-vert.png"
            } else {"./assets/images/scanlines.png"
            }
    sourceSize { width: 1920; height: 1080 }
    opacity: 0.3
    smooth: true
  }

PlayingKarrde

Yep that would be possible. The code would actually look a bit more like this though:

Image
  {
    id: overlay
    anchors.fill: parent
    source: (gameData.assets.videos[0].height > gameData.assets.videos[0].width) ? "../assets/images/scanlines-vert.png" : "../assets/images/scanlines.png"
    sourceSize { width: 1920; height: 1080 }
    opacity: 0.3
    smooth: true
  }

If you are ok to wait though I could probably just add this as a feature to the next release.

fastpop72

@PlayingKarrde I surely will wait for your next release! I love this theme! Meanwhile i'd like to tamper just in order to learn something...

I won't add any Pull Request to the original code!

I tried your suggestion for selecting vertical scanlines (scanlines-vert.png) when current video preview is vertical but doesn't work... it show me always the horizontal scanlines (scanlines.png). Any hint?

PlayingKarrde

@fastpop72 Yep I found the same thing when I tried to implement it just now. I will have to do some further digging to figure out why. It's possible it isn't reading gameData.assets.videos[0].height but I couldn't say for sure without some debugging.

fastpop72

@PlayingKarrde said in [Theme] gameOS for Pegasus:

@fastpop72 Yep I found the same thing when I tried to implement it just now. I will have to do some further digging to figure out why. It's possible it isn't reading gameData.assets.videos[0].height but I couldn't say for sure without some debugging.

Ok thank you, i will wait further testing.

PlayingKarrde

-edit- Am going to have to hold off on the update I just posted for now.

ryuuji

Nice update. But in my opinion the new details page for games does not suit the theme as good as the old one.

PlayingKarrde

@ryuuji Sorry to hear that. On the plus side, with the next major release you should be able to choose which one you like from within the theme itself.

PlayingKarrde

OK phew, finally got this stupid video thumbnail issue sorted out properly now. Performance should be a lot better in the current release and there should be much less visual issues. I think there could still be some general performance enhancements due to it being fairly messy code wise still, but in general I'm pretty happy with it.

Here's the full and proper updates for this incremental release:

v0.6.5

Greatly improved video thumbnail performance by rebuilding the entire system (thanks @waldnercharles for the tip on where to look)
Re-added video thumbnails by default
Cleaned up buttons for video preview on game details screen
Added better support for landscape boxart
Fix for misaligned platform selection text
Fix for platform selection not defaulting to selected view

fastpop72

Thank You Thank You Thank You!!! Your theme is going better every day!!

I think the new details screen is much better than previous, usually i don't like videosnaps at full screen but using the scanlines has been a touch of class!! The scanlines gives a retro CRT look even with low quality videosnaps (320x240) in full screen!!! The only little thing i miss is the vertical ones when videosnap is vertical.

The other thing i think would be great is reintroduce a white text in the main grid with the game title you are selecting...
Often happens on grids with hundred games that you can't spot the game you are searching because every rectangle is different (due to game art) and the game title under the box is very tiny.
I think an overlay with the game title (like the one used in the top section of the grid in the previous version) placed now at the bottom of the grid would be great and together with title you could restore the little gray boxes with "developer", "year", "number of players" that i can't say why but you removed it from the game details screen....

Keep on your great work @PlayingKarrde !!!

Malixx

Oh my god! I can't believe I missed on that, it's perfect! That is everything I've been looking for, very well done!
Is it possible to have an animated loading screen when launching a game?

PlayingKarrde

@Malixx do you mean a screen that displays as the game is loading in the background? I don't think that's possible (unless this is a retropie feature but I don't use the pi so couldn't say). Or do you mean just something that shows when it's launching a game?

Malixx

@PlayingKarrde I meant something that shows when it's launching a game, but not a still image, something like a video or maybe a gif

PlayingKarrde

@Malixx Yep that would be possible. I'll add it to the list.

HommeCrabe

Hi @PlayingKarrde! Thank you very much for your theme, I love it so far!
I'm trying to improve one thing which is to have the sound of the video even if I'm not in the Preview panel, both on the Grid and on the Details panel. I've set:

"muted" to "true" in GameDetails.qml
and "property bool muteVideo" to "true" in BackgroundImage.qml

It works great but if I go in the Detail panel, the video starts over and the sound of the Details video overlaps the sound of the Grid video. Is there any way to ensure continuity between the video being played on the Grid and the one in the Details panel? I mean:

on the Grid, the video starts with its audio
I press A
on the Details panel, video playback continues without interruption, not starting over

I hope my explanations are clear ^^ Thanks for your help!

PlayingKarrde

@HommeCrabe Unfortunately this is a known issue. I spent a bit of time last week trying to fix it but it wasn't immediately apparent why my fix wasn't working so I didn't put more time into it. It's still on my list of things to fix as I want that as an option for when theme options are ready, but unfortunately you will have to wait I'm afraid.

HommeCrabe

@PlayingKarrde Thank you for your reply. It's good to know you're aware of this ^^ I'll try to investigate it, but not sure I'll understand all the QML code. Good luck with all the stuff on your to-do-list :P

PlayingKarrde

@HommeCrabe I've actually just figured it out. It will be in the next update.

-edit- I guess I should say that I figured out the issue I was having which was the grid videos continuing to play when entering details (which in turn would cause the audio to continue playing if you unmuted it). Rereading what you are asking for this isn't exactly what you're requesting. For your solution it would require a bit more work and the ways I could think of doing it would not be very performant. I agree that would be nice but I will have to think on it some more to come up with a solution that is viable otherwise I don't think I'll add it (the theme is already heavy enough performance wise unfortunately - I don't want to add to it even more).

HommeCrabe

@PlayingKarrde Wow! Thank you! Stopping the Grid video in the background is already a nice feature. I understand that, to achieve what I'd like, you probably have to use the same video stream on the Grid and on the Details. Like opening Details makes the video fullscreen. But not sure this is feasible. Anyway, thank you very much, looking forward your next update :)

velkien

@PlayingKarrde Hello, sorry my bad english, I'm using a translator. I loved the theme, very beautiful and just wanted to put a background song to be playing in the menu. I wonder if there is such a possibility and how I could do it. I also wanted to know if you could put a video to start the frontend. Thanks.