new scriptmodules (lr-vice-xvic, gsplus, proper lr-mess integration!)

valerino

@roslof thanks for the addition, great!!! can you make me a pull request with all the emulators you added ?

Note: I also updated all of your scripts. They were breaking extensions and removing the name for each system in es-systems.cfg. Feel free to review them and take what you'd like. I added a couple more too. Eg. Vectrex, Oric Atmos.

btw, about the extension.... few commits ago i committed a fix to scriptmodules/helpers.sh. that was the culprit of adding one space more between the extension.
also the name removing bug should be fixed in all (yesterday) versions of the scripts.

EDIT: yep, i can confirm.
https://github.com/roslof/RetroPie-Setup/commit/ae10af7f118df140c76a3434708469ed67ad8831 (your changes)
https://github.com/valerino/RetroPie-Setup/blob/master/scriptmodules/libretrocores/lr-mess-dragon32.sh (one of my script)

you have somewhat outdated files, you probably took single files from my repo.
never do that if you want to help developing: clone my repo and always git pull then commit your stuff, then do me a pull request :)
this is because i also added stuff to retropie files helpers.sh and packages.sh, to avoid i.e. writing system name in multiple places (so that can be used in all scripts, not just lr-mess).
awaiting your proper pull request so, great work!

valerino

@CCFox you can use my RetroPie-Setup repo which have lr-vice-vic20 script.

alternatively, just copy https://github.com/valerino/RetroPie-Setup/blob/master/scriptmodules/libretrocores/lr-vice-xvic.sh to your RetroPie-Setup/scriptmodules folder and relaunch the setup.

UDb23

@valerino Does your script include the 3 options for launching vic-20 programs too?

valerino

@UDb23 looked into that post. unfortunately not.
it can be surely done in the same way i did for lr-mess (so doing a 'trampoline' script like run-mess.sh), as far as i see there's no way to add custom retroarch core options (as needed in lr-mess for every system, or as for these lr-vice options) directly from the installer using the default runcommand.sh.

this is the function which should be, imho, changed in retropie core scripts to support this in the proper way (so, without the need of something like my run_mess.sh):
https://github.com/RetroPie/RetroPie-Setup/blob/master/scriptmodules/helpers.sh#L1276

as a side note, this probably may be done also via custom scripts as described in https://github.com/retropie/retropie-setup/wiki/runcommand. but, this is something the user must do later, messing with scripts and stuff. i'd really prefer an as-much-as-possible 'readymade' solution directly from the setup script.

i think some core devs should jump in this thread, i can do these changes for sure .... but messing with the core script is more invasive than what i'm doing now, so i'd prefer to hear their opinion :)

valerino

added Acorn Electron

UDb23

@valerino Understood, thanks.

mth75

@valerino said in new scriptmodules (lr-vice-xvic, gsplus, proper lr-mess integration!):

added Coleco Adam

i really hope all this gets added to the retropie distribution ..... i'll add a bunch of other emulators (and try to fix bbcmicro), then i'll retry to submit a pull request :)

I for sure love your work. Missing emulators which can be added with lr-mess should be included (at least) in the retropie distro.

mth75

@valerino said in new scriptmodules (lr-vice-xvic, gsplus, proper lr-mess integration!):

@roslof thanks for the addition, great!!! can you make me a pull request with all the emulators you added ?

Note: I also updated all of your scripts. They were breaking extensions and removing the name for each system in es-systems.cfg. Feel free to review them and take what you'd like. I added a couple more too. Eg. Vectrex, Oric Atmos.

btw, about the extension.... few commits ago i committed a fix to scriptmodules/helpers.sh. that was the culprit of adding one space more between the extension.
also the name removing bug should be fixed in all (yesterday) versions of the scripts.

EDIT: yep, i can confirm.
https://github.com/roslof/RetroPie-Setup/commit/ae10af7f118df140c76a3434708469ed67ad8831 (your changes)
https://github.com/valerino/RetroPie-Setup/blob/master/scriptmodules/libretrocores/lr-mess-dragon32.sh (one of my script)

you have somewhat outdated files, you probably took single files from my repo.
never do that if you want to help developing: clone my repo and always git pull then commit your stuff, then do me a pull request :)
this is because i also added stuff to retropie files helpers.sh and packages.sh, to avoid i.e. writing system name in multiple places (so that can be used in all scripts, not just lr-mess).
awaiting your proper pull request so, great work!

Isn't the Ti99 now added to the master?

valerino

@mth75 not yet, i'm waiting for @roslof proper pull request. adding stuff manually to repos is the way to break things :)

roslof

@valerino working on this now.

CCFox

@valerino

Thank you for your reply.

I still can't get the xvic to work....This is what I have done:

I have copied vice_xvic_libretro.so to the /opt/retropie/libretocores/lr-vice folder.

I then copied the c64 emulator config file and replaced the c64 instruction with this:

lr-vice = "/opt/retropie/emulators/retroarch/bin/retroarch -L /opt/retropie/libretrocores/lr-vice/vice_xvic_libretro.so --config /opt/retropie/configs/vic20/retroarch.cfg %ROM%"

default = "lr-xvic"

and saved it as vic20 and placed in a folder called vic20 in the /opt/retropie/configs folder

I then copied the c64 entry and changed the details for the vic20 in the es_systems.cfg file:

<system>
<name>vic20</name>
<fullname>Commodore VIC-20</fullname>
<path>/home/pi/RetroPie/roms/vic20</path>
<extension>.crt .prg .tap .zip .CRT .PRG .TAP .ZIP</extension>
<command>/opt/retropie/supplementary/runcommand/runcommand.sh 0 SYS vic20 %ROM%</command>
<platform>vic20</platform>
<theme>vic20</theme>
</system>

I took out the unrelated c64 rom extensions.

And still no joy...Any further pointers?

Thank you for your previous help

CCF

valerino

@CCFox why dont you simply use my script? clone my repo replacing RetroPie-Setup folder completely, then install lr-vice-xvic as normal.

CCFox

Valerino

I did copy the lr-vice-xvic.sh and relaunched the setup but I couldn't see the option for lr-vice-xvic.

I looked in the experimental etc and it wasn't there....What am I doing wrong?

Very new to this.

roslof

@CCFox

1. Exit RetroPie Setup
2. Be sure that lr-vice-xvic.sh is located in ~/RetroPie-Setup/scriptmodules/libretrocores
3. Restart RetroPie Setup
4. Manage Packages
5. exp
6. Scroll the list until you spot the package

Per Valerino, just clone his repo :)

valerino

@roslof @CCFox it will not work, you will run in the missing system names/extensions. you need other updated files (scriptmodules/packages.sh and packages/helpers.sh).

it's really easier if you clone my repo....

CCFox

Valerino

I followed your instructions and successfully installed xvic and xplus4. xplus 4 works and loads games however xvic does not. When I launch a VIC-20 game it does state the lr-xvic emulator is the default emulator. I noticed that the es_systems.cfg file has updated to reflect the 2 new systems. Is there anything else I need to do?

Rgds

CCF

valerino

@CCFox

When I launch a VIC-20 game it does state the lr-xvic emulator is the default emulator. I noticed that the es_systems.cfg file has updated to reflect the 2 new systems. Is there anything else I need to do?

what happens ? due to what is mentioned in the post referenced here some carts may not work (emulator runs but game not start).
i may fix it later as i said in https://retropie.org.uk/forum/post/217729.
for now, my goal is to have the most possible emulators starting and running games with the default options.
can you confirm that the emulator starts but do not load game ? if so it's probably to the problem mentioned. try other games, i.e. tapes, other carts. they will work for sure.

CCFox

@valerino

Thank you for your reply.

I've tried around 30 games at random and it gets to the blue screen with the emulator box then goes back to emulation station. Doesn't even get to the ready screen.

Rgds

CCF

valerino

@CCFox said in new scriptmodules (lr-vice-xvic, gsplus, proper lr-mess integration!):

I've tried around 30 games at random and it gets to the blue screen with the emulator box

can you be more clear about that ?
anyway, it seems you have something weird.

can you verify all of this and tell me if there's any differences ? thanks!

~/RetroPie-Setup(master) » ls -l /opt/retropie/libretrocores/lr-vice-xvic                                                                                               total 3052
-rw-r--r--  1 root root   17989 Apr 20 10:17 COPYING
drwxr-xr-x 14 root root    4096 Apr 20 10:17 data
-rw-r--r--  1 root root      60 Apr 20 10:17 retropie.pkg
-rwxr-xr-x  1 root root 3095296 Apr 20 10:17 vice_xvic_libretro.so

~/RetroPie-Setup(master) » cat /opt/retropie/configs/vic20/emulators.cfg                                                                                                
lr-vice-xvic = "/opt/retropie/emulators/retroarch/bin/retroarch -L /opt/retropie/libretrocores/lr-vice-xvic/vice_xvic_libretro.so --config /opt/retropie/configs/vic20/retroarch.cfg %ROM%"
default = "lr-vice-xvic"

and the following in /etc/emulationstation/es_systems.cfg:

CCFox

Hello again Valerino

Working!!!

the es_systems file matches so that is OK.

The files were all lr-vice-xvic folder.

However the emulators.cfg didn't match what you had posted. So I cut and pasted what you had put and wahey it works!!!

The information in the emulators.cfg file was a mixture of my earlier mistake and the commands that was generated by your quite excellent script.

I will now backup everything you have said.

Once again thank you very much for your help.

Kind Regards

CCF