[SOFT] New Scraper in the works

kiro

@Folly :-) I should've put --relativepaths, good sight !

Anyway , I tried one rom in system path, one rom in subfolder and one rom in both, and it seems to work?

I'll see if the git version is the latest one...it is... hmmm can you try --debug and see if something shows up?

Folly

I updated the script on my pi4 and it worked correctly showing the games in the script output when using a subfolder.

I did the same on my VM.
The first time it did not display the games when using a subfolder.
The next tries were always successful so I can't reproduce the error any more so I can't use --debug anymore.
I had a generated file from my script 0 rom-index 0 in the roms folder, this could have had some influence, but moving it back and it still worked fine so I doubt it.

Let's say it's solved for now.
If it comes back again we can have a second look.

Btw. the pc_mario.mp4 works as expected on the pi4 ;-) (video and sound OK)

Folly

@kiro

Hi,

Here you can read about using folders in gamelists using descriptions and media :
https://github.com/RetroPie/EmulationStation/blob/master/GAMELISTS.md

I did a quick test and it's not only restricted to :

name - string, the displayed name for the folder.
desc - string, the description for the folder.
image - image_path, the path to an image to display for the folder.
thumbnail - image_path, the path to a smaller image to display for the folder.

Quick example :

<folder>
		<rating></rating>
		<name>subfolder</name>
		<marquee>./marquees/pc_1942.png</marquee>
		<image>./images/pc_1942.png</image>
		<video>./videos/pc_mario.mp4</video>
		<path>./more</path>
		<thumbnail/>
		<desc>description</desc>
</folder>

Looks like this :

kiro

@Folly thanks for that, although I'm not sure what would be the use for that in an automatic scraping... I mean, the folder tag could be created automatically, but what about description and image and the rest? Fill this info based on what exactly? Something to think about...

Folly

@kiro

I agree, it's not something to implement directly into the script.
I only mention it because you questioned why a folder looked the way it did.
So it's only for the knowledge.

Folly

@kiro

Just want to say :
I really appreciate the effort you putting in it.
Keep up the good work ;-)

kiro

@Folly Thanks, this is just my way to give back something to the retro community for all the fun over the years! even if it is just a silly scraper :-)

kiro

@Folly just wanted to give you a quick update, I'm still in the process of converting problematic videos, not easy with over 40k to go over (even being a script), will keep you posted. Take care!

Folly

@kiro

That's quite a lot.
How long does it take, do you think.
Just curious.

kiro

@Folly, well it depends on the number of videos that actually need conversion (impossible to estimate), but it also depends on me doing the script right the first time and not having to launch it over and over, the internet going off just in the middle of the process which means I need to restart all over, you know, the usual stuff... if everything goes ok it should be fine by this evening or tomorrow morning the latest. Luckily once the conversion is done, it should be fine. Funny thing: most of the videos not working seem to have been captured with mame, go figure :-) And, this means other databases will probably have the same issue.

Folly

@kiro

Nice to know.
I will see the result in time ;-)
Good luck !

kiro

@Folly Oh, BTW, I started playing around with a script for retropie-setup, it is in the git repository and it is a copy of another scraper's script. It works as far as the installation and running of the scraper goes. If you want to play with it, put it in ~/RetroPie-Setup/scriptmodules/supplementary and it should appear under the optional modules of retropie-setup. Just added the system selection option to rsetup ;-) ... videos still going ...

kiro

@Folly Hi, good news, the script for the videos is done, all videos should be working (at least those with a similar problem as pc-mario).

Folly

@kiro

Great !
Will test it this evening on my pi4.

I already see the improvement on my VM.
There are less errors reported after closing emulationstation.
Superb ;-)

kiro

@Folly thanks! In the meantime I've updated the retroscraper.sh script, seems to be working quite well, although it needs some cleaning and ironing, but functionality wise it seems to be ok.

kiro

I've almost completed the retroscraper.sh script that would allow for seamless integration with retropie_setup script.

https://github.com/zayamatias/retroscraper-rpie/blob/main/retroscraper.sh

If you copy under the ~/RetroPie-Setup/scriptmodules/supplementary/ directory, you should see it under the optional packages:

Install it from source, once done go to configurations / options

Choose your preferences, decide wether to scan everything or just some system(s):

And let it run!

Let me know how it works!

Next steps, polish it a bit and hopefully integrate it with retropie?

Folly

@kiro

Had a quick look at the script.
Was wondering where the dependencies were installed.
Saw that you used su $user so obviously it's installed in the same path /home/pi/.local/bin .
So you made it uniform with the normal install, great !

Will have a look at the menu later.

kiro

@Folly the dependencies are basically a couple of python modules, not much more now, If I remember correctly. Still I have to improve the install/update script so things like pip dies not get installed everytime and checking that the modules are already installed. Retroscraoer itself will install in /opt/retropie/supplementary as every other tool from within retropie_setuo

Folly

@kiro

Indeed, you should implement checks so things will not install every time.
Are you planning to do it with checksums or checking files/versions ?

Btw.
Is a pip install as dependency not an option ?
(as apt install from the function depends)

kiro

@Folly pip could be installed by apt, but I've had bad experiences with the pip install from the distribution, not always being the latest version. I ws planing to check if running pip would succeed and if not install it. And the. Checking if the dependencies are there (or even asking to install, since it's just a couple of modules and the installation is faulty quick) I will see what's the least cumbersome option.