Skyscraper is back! (v3.13)

Lolonois

Version 3.10.0 is out.

One of the changes which may be beneficial for you is the added bash completion:

For example: Start typing Skyscraper - then Tab twice will give you all options, if you continue with Skyscraper -- then Tab twice you get only the long options. From there if you continue to type Skyscraper --c then Tab twice, you get Skyscraper --cache completed, if you again press Tab twice you get all cache options listed.

Same goes for the main options -p and -s. Type Skyscraper -p a Tab twice will give you for example ags amiga apple2 arcade atari2600 atari800 as completion options. Once only one option is left, it is fully expanded and you can continue with more options as outlined above.

And one important note: If you changed your local peas.json you may check the addition to peas.json.rp-dist in ~/.skyscraper/. In essence this this line has changed. You may want to add that to your peas.json. (see also previous posts on this change).

As always, all additions of this release are summarized here.

Clyde

Thanks from a long-term Linux user to whom Tab completion is as natural as breathing. 😉

sleve_mcdichael

@Lolonois said in Skyscraper is back! (v3.10.0):

Version 3.10.0 is out.

One of the changes which may be beneficial for you is the added bash completion:

This isn't working for me. Updated Ss (binary) via RP-Setup. I am running v3.10.0 as reported by --version. I have the ~/.bash_completion.d/Skyscraper.bash file. I even rebooted the RPi4.

Skyscraper --c[TAB][TAB]
Skyscraper -p sn[TAB][TAB]
/opt/retropie/supplementary/skyscraper/Skyscraper -p snes -s scr[TAB][TAB]
# etc.

...does nothing.

My RP-Setup is current, but underlying Raspbian Buster is not (251 packages can be upgraded. "If it ain't broke, don't fix it.") Should that make a difference?

Lolonois

@sleve_mcdichael this one is on me: I forgot to add a symlink command in the scriptmodule.

sudo ln -sf "/opt/retropie/supplementary/skyscraper/Skyscraper" "/usr/local/bin/Skyscraper" should remediate the situation.

I will file a PR soon for the scriptmodule.

sleve_mcdichael

@Lolonois I have that symlink too:

$ ls -l /usr/local/bin/Skyscraper 
lrwxrwxrwx 1 root root 49 Sep 27 21:41 /usr/local/bin/Skyscraper -> /opt/retropie/supplementary/skyscraper/Skyscraper

(Edit: to clarify, the Skyscraper command works fine, and has been, it's the tab-completion that doesn't seem to do anything.)

mitu

@sleve_mcdichael It works for me, so could be a local config issue. Can you post your skyscraper.ini, removing any personal/password fields ?

sleve_mcdichael

@mitu

[main]

;; define paths
; inputFolder="/home/pi/RetroPie/roms"
gameListFolder="/home/pi/.emulationstation/gamelists"
mediaFolder="/home/pi/.emulationstation/downloaded_media"
; cacheFolder="/home/pi/.skyscraper/cache"
; importFolder="/home/pi/.skyscraper/import"

;; cache settings
; cacheCovers="true"
; cacheScreenshots="true"
; cacheWheels="true"
cacheMarquees="false"
cacheTextures="false"

;; video settings
videos="true"
videoSizeLimit="42"
videoConvertCommand="videoconvert.sh %i %o"
videoConvertExtension="mp4"
symlink="true"

;; artwork
; artworkXml="artwork-wide.xml"
artworkXml="artwork-cover.xml"

;; generic
relativePaths="true"
brackets="false"
subdirs="false"
theInFront="true"
unattendSkip="true"
maxLength="10000"

[arcade]
; artworkXml="artwork-tall.xml"

[gb]
; artworkXml="artwork-tall.xml"
;; allow gbc titles in gb folder
addExtensions="*.gbc"

[gba]
; artworkXml="artwork-wide.xml"

[gbc]
; artworkXml="artwork-tall.xml"

[genesis]
;; allow sega cd titles in genesis folder
addExtensions="*.iso *.cue *.chd"

[pcengine]
;; use 'tg16' folders for pce titles
;; (deprecated - use custom system in peas.json/platforms_idmap.csv instead)
;inputFolder="/home/pi/RetroPie/roms/tg16"
;gameListFolder="/home/pi/.emulationstation/gamelists/tg16"
;mediaFolder="/home/pi/.emulationstation/downloaded_media/tg16"
;cacheFolder="/home/pi/.skyscraper/cache/tg16"
;importFolder="/home/pi/.skyscraper/import/tg16"

[screenscraper]
;; userCreds="user:pass"
userCreds="[user]:[pass]"

[esgamelist]
;; import customized ES textual data
cacheRefresh="true"
unattend="true"
videos="false"
cacheCovers="false"
cacheScreenshots="false"
cacheWheels="false"
cacheMarquees="false"

[import]
cacheRefresh="true"

mitu

@sleve_mcdichael Hm, it doesn't seem related to the config file.
Are you sure that the bash completion file is loaded ? Can you try running source $HOME/.bash_completion.d/Skyscraper.bash and try again ?

sleve_mcdichael

@mitu said in Skyscraper is back! (v3.10.0):

Can you try running source $HOME/.bash_completion.d/Skyscraper.bash and try again ?

Yes, this works. Only until I log off and back on again (SSH), then it not longer works again.

Do you suppose it's related to one of them 251 packages, or why else won't this file be loading?

@sleve_mcdichael said in Skyscraper is back! (v3.10.0):

My RP-Setup is current, but underlying Raspbian Buster is not (251 packages can be upgraded. "If it ain't broke, don't fix it.") Should that make a difference?

https://pastebin.com/KGfQri07

mitu

@sleve_mcdichael said in Skyscraper is back! (v3.10.0):

Do you suppose it's related to one of them 251 packages, or why else won't this file be loading?

No, I don't thinks so. Do you have the bash-completion package installed ?

sleve_mcdichael

@mitu yep:

$ apt list bash-completion 
Listing... Done
bash-completion/oldoldstable,now 1:2.8-6 all [installed]

mitu

@sleve_mcdichael then it's bug in the installation instructions - I think it's not working also on my system OOB.

@Lolonois are you sure that using $HOME/.bash_completion.d is the right place to copy user-defined Bash completion files ? It doesn't seem to sourced automatically by bash_completion.

Lolonois

Do you have a ~/.bash_completion @sleve_mcdichael ?

If not create one to pick the Skyscraper bash completion up:

cat <<'EOF' >~/.bash_completion
for bcfile in ~/.bash_completion.d/* ; do
    [ -f "$bcfile" ] && source "$bcfile"
done
EOF

Another bash -i should give you the completion and also this should survive reboots.

Apperently I forgot that I did this ~/.bash_completion creation for another bash completion already back in December 2021. :-/

However, I am still puzzled why the symlink noted above is already on your system @sleve_mcdichael as it is not created with the current skyscraper.sh scriptmodule, but is needed also for bash completion.

mitu

@Lolonois said in Skyscraper is back! (v3.10.0):

Apperently I forgot that I did this ~/.bash_completion creation for another bash completion already back in December 2021. :-/

Then maybe is better to install the completion file system-wide (/etc/bash_completion.d/ ?) if there's no standard user defined location for completion files.

Lolonois

@mitu ok for me to put it in the global /etc/bash_completion.d/ when you maintainers are. This reduces the logic in the scriptmodule where to put the completion file and do additional actions, depending on bash completion version and XDG compliant setups.

There is a lot of context here, FWIW.

mitu

@Lolonois said in Skyscraper is back! (v3.10.0):

There is a lot of context here, FWIW.

Oh, no, not the XDG_ police !

Lolonois

@mitu No worries. I will happily put it below /etc... to keep the XDG police / policy out. :-D

sleve_mcdichael

@Lolonois said in Skyscraper is back! (v3.10.0):

However, I am still puzzled why the symlink noted above is already on your system @sleve_mcdichael as it is not created with the current skyscraper.sh scriptmodule,

I have manually added this symlink a long time ago, as suggested in the CLIHELP.md document.

If you've installed Skyscraper through the RetroPie-Setup script, it is recommended to create a symbolic link to the executable. Do this by running sudo ln -s /opt/retropie/supplementary/skyscraper/Skyscraper /usr/local/bin/Skyscraper. This will allow you to just type Skyscraper when running it from command line.

sleve_mcdichael

@mitu @Lolonois seems to work if placed here, with no other modifications on my part:

~/.local/share/bash-completion/completions/Skyscraper.bash

Edit: https://github.com/RetroPie/RetroPie-Setup/pull/3872 is working for me (but am I understanding this might be system-dependent for different people?)

mitu

@sleve_mcdichael let's do the system install option.