Updated EmulationStation for Windows

f.caruso

@jero said in Updated EmulationStation for Windows:

I hope you can understand what I mean.

Sorry, I don't really understand your explanations... ( Do you use a translator ? ) Maybe post screenshots before/after...
Also the clock is customizable, see the 3 themes on my git for samples ( element <text name="clock"> that has to be described in a <view name="screen"> )

Tromzy

Hi @f-caruso ,

I use your fork on ArchLinux, I used to compile it from git and it worked, but since a few days I get this error when compiling :

[ 18%] Building CXX object es-core/CMakeFiles/es-core.dir/src/ThemeData.cpp.o
Dans le fichier inclus depuis /home/tromzy/EmulationStation/es-core/src/components/VideoComponent.h:6,
depuis /home/tromzy/EmulationStation/es-core/src/components/VideoVlcComponent.h:5,
depuis /home/tromzy/EmulationStation/es-core/src/ThemeData.cpp:6:
/home/tromzy/EmulationStation/es-core/src/components/ImageGridComponent.h: Dans la fonction membre « void ImageGridComponent<T>::updateTileAtPos(int, int, bool, bool) »:
/home/tromzy/EmulationStation/es-core/src/components/ImageGridComponent.h:803:100: erreur: « PLACEHOLDER » n'a pas été déclaré dans cette portée
803 | >getType() == 2 || (mEntries.at(imgPos).object->getType() == PLACEHOLDER && mEntries.at(imgPos).object->getPath() == ".."))
| ^~~~~~~~~~~

/home/tromzy/EmulationStation/es-core/src/ThemeData.cpp: Dans la fonction membre statique « static const std::shared_ptrThemeData::ThemeMenu& ThemeData::getMenuTheme() »:
/home/tromzy/EmulationStation/es-core/src/ThemeData.cpp:399:15: attention: retourne une référence vers un temporaire [-Wreturn-local-addr]
399 | return std::shared_ptrThemeData::ThemeMenu(new ThemeMenu(&emptyData));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/tromzy/EmulationStation/es-core/src/ThemeData.cpp: Dans la fonction membre « void ThemeData::parseViewElement(const pugi::xml_node&) »:
/home/tromzy/EmulationStation/es-core/src/ThemeData.cpp:610:41: erreur: impossible de lier la référence d'une l-valeur non constante de type « std::pair<std::__cxx11::basic_string<char>, ThemeData::ThemeView>& » à une r-valeur de type « std::pair<std::__cxx11::basic_string<char>, ThemeData::ThemeView> »
610 | ThemeView& view = mViews.insert(std::pair<std::string, ThemeView>(viewKey, ThemeView())).first->second;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Dans le fichier inclus depuis /home/tromzy/EmulationStation/es-core/src/ThemeData.cpp:1:
/home/tromzy/EmulationStation/es-core/src/ThemeData.h:342:119: note: initialisation de l'argument 1 de « std::pair<__gnu_cxx::__normal_iterator<std::pair<std::__cxx11::basic_string<char>, ThemeData::ThemeView>*, std::vector<std::pair<std::__cxx11::basic_string<char>, ThemeData::ThemeView> > >, bool> ThemeData::UnsortedViewMap::insert(std::pair<std::__cxx11::basic_string<char>, ThemeData::ThemeView>&) »
342 | >::iterator, bool> insert(std::pair<std::string, ThemeView>& item)
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~

/home/tromzy/EmulationStation/es-core/src/ThemeData.cpp: Dans la fonction membre « void ThemeData::parseCustomView(const pugi::xml_node&, const pugi::xml_node&) »:
/home/tromzy/EmulationStation/es-core/src/ThemeData.cpp:769:39: erreur: impossible de lier la référence d'une l-valeur non constante de type « std::pair<std::__cxx11::basic_string<char>, ThemeData::ThemeView>& » à une r-valeur de type « std::pair<std::__cxx11::basic_string<char>, ThemeData::ThemeView> »
769 | ThemeView& view = mViews.insert(std::pair<std::string, ThemeView>(viewKey, ThemeView())).first->second;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Dans le fichier inclus depuis /home/tromzy/EmulationStation/es-core/src/ThemeData.cpp:1:
/home/tromzy/EmulationStation/es-core/src/ThemeData.h:342:119: note: initialisation de l'argument 1 de « std::pair<__gnu_cxx::__normal_iterator<std::pair<std::__cxx11::basic_string<char>, ThemeData::ThemeView>*, std::vector<std::pair<std::__cxx11::basic_string<char>, ThemeData::ThemeView> > >, bool> ThemeData::UnsortedViewMap::insert(std::pair<std::__cxx11::basic_string<char>, ThemeData::ThemeView>&) »
342 | >::iterator, bool> insert(std::pair<std::string, ThemeView>& item)
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~

make[2]: *** [es-core/CMakeFiles/es-core.dir/build.make:258: es-core/CMakeFiles/es-core.dir/src/ThemeData.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:218: es-core/CMakeFiles/es-core.dir/all] Error 2
make: *** [Makefile:152: all] Error 2

Any idea ? Thanks !

f.caruso

@Tromzy said in Updated EmulationStation for Windows:

Yes. PLACEHOLDER has to be replaced with 3, I didn't commit it yet...

Tromzy

@f-caruso OK ! I'll just wait, then. Thanks for your great work !

lopapa

@f-caruso
Hello,

Is there any way to configure a retroarch platform with more than one core, for example MAME --> mame, mame087 and apart, another external emulator such as dolphin?
So in the emulationstation menu you can select emulate with a retroarch emulator and be able to select the core I want to use or select a standalone emulator that is not retroarch.

I haven't been able to see how to do it.

(I know it may make little sense to put MAME with Dolphin, but it's the first thing that came into my head)

Thank you!

jero

@lopapa In this link is the information on how to use several cores. Get down a little with the mouse and in "Changes in my branch", this is what you are looking for.

https://github.com/fabricecaruso/EmulationStation

@f-caruso said in Updated EmulationStation for Windows:

@jero said in Updated EmulationStation for Windows:

I hope you can understand what I mean.

Sorry, I don't really understand your explanations... ( Do you use a translator ? ) Maybe post screenshots before/after...
Also the clock is customizable, see the 3 themes on my git for samples ( element <text name="clock"> that has to be described in a <view name="screen"> )

It was just my problem, I wasn't doing something right hehehe

jero

This post is deleted!

lopapa

@jero
Thanks but the cores of the same emulator for retroarch already work for me correctly thanks to the manual that you indicate of the web page. The problem I pose is to configure a standalone emulator independent of retroarch and at the same time a retroarch emulator with its cores.
Having only one tag <command> I don't know how to make the call discriminating

f.caruso

@lopapa Yes you can override the main command :

<emulators>
      <emulator name="libretro">
        <cores>
          <core>flycast</core>
          <core>reicast</core>
        </cores>
      </emulator>
      <emulator name="redream" command="%HOME%\redream\redream.exe -fullscreen %ROM%"/>
    </emulators>

lopapa

@f-caruso

Thanks f-caruso! Works like a charm!

CarissaIsWierd

@f-caruso

I have some feature requests if you ever run out of things to do >_>

Option that can hide and unhide systems from within EmulationStation. Kind of like a checklist similar to game collections. It'd be an alternative to having to comment and uncomment systems in the es_systems file. (I have a lot of systems with 10 or less games that I normally don't want visible.) Games from hidden systems should still be visible in game collections.
Add theme properties to show metadata on each game in grid view, rather than always being located in one spot. It could be like "gridtile.favorite" and "gridtile.favorite:selected" are with the favourite badge. Also maybe a way to show game titles on one line with scrolling for long titles. Here's how I have a theme for Kodi modified and here's the best I can get with ES.
Add colour properties to "gameImage" and "folderImage" under imagegrid. (To allow for different colours per system with a variable, or just to recolour an image without editing it.)
Add a scrollSound property for selecting systems from carousel view, rather than just gamelist view. (And have them separate.)

:)?

f.caruso

@CarissaIsWierd Interesting I'll think about it.

Always being located in one spot

You can already set the pos/size of the text to align it at bottom. It's just not auto-scrollable.
I'm also interested in having a link to the theme you build ;-)

LiveFreeDead

@f-caruso Your Continuous Master build has failed, no precompiled .exe's have been available for the last 22 hours or so.

LiveFreeDead

@LiveFreeDead Fixed now, guess it was a github issue.

CarissaIsWierd

@f-caruso

I'm also interested in having a link to the theme you build ;-)

Hmm, am I allowed to share it if it's a mod of another theme (spaceoddity)? It also has optional assets from even more themes and edited artwork I've found elsewhere. All I've kept the same is the carousel view (for the most part.) It's so pretty though @_@..

I found "gridtile.overlay" in one of your edited themes, but I can't get the game title to appear on top of it, even using zIndex. I'm trying to add a shadow image (which barely shades just the bottom) from the Kodi screenshot I shared, so I can position the title at the bottom and have it clearly readable without glowColor. Example of it underneath the overlay.

duiz

Is there a way to set screenscraper to only search for games with missing metadata? TheGamesDB is down for the forseeable future and when updating games it makes me rescrape every game.

LiveFreeDead

@duiz It actually has in the Scrapers Filter (top option when you pick Scrape Now), the reason it scrapes all games instead of ones without media is either it doesn't have a description for the game, you have Scrape Ratings enabled or you use a different tool to scrape the existing Meta Data - I found if I use Skraper that if I then use EmulationStation to re-scrape over the top, it would get ALL the games again regardless of the filter choice and place the new meta data (screen shots, videos) in the current ROMS\Images, ROMS\Videos sub folders, once they were placed there it would skip existing properly.

Hope this helps.

f.caruso

@CarissaIsWierd

I found "gridtile.overlay" in one of your edited themes, but I can't get the game title to appear on top of it

Overlay as its names says displays over others components. I have no zIndex management in gridview child components.
The shadow can be realized using imagegrid.padding ( which can take 4 values, left/top/right/bottom ) & using the background as a ninepatch using gridtile.backgroundImage with a gridtile.backgroundCornerSize (where values have to be >= 1 to define shadow + border size in px )

EDIT : The padding was only a 2 value. I extended it to accept 4 values & tested it - you'll have to download the latest build. See what it looks like using a png with the shadow & <padding>4 4 14 14</padding><backgroundCornerSize>32 32</backgroundCornerSize>

@duiz Yes, see the "only missing medias" option. "The reason it scrapes all games" is that the only way to know which medias you are missing is to ask the server its list of medias. As the option name says : Using this option, only missing medias are downloaded.

CarissaIsWierd

@f-caruso That's all a bit confusing to me. Can you paste it as working code, or edit one of your themes?

f.caruso

@CarissaIsWierd

<gridtile name="default">
      <backgroundImage>./art/tileshadow.png</backgroundImage>
      <padding>4 4 14 14</padding>           
      <backgroundCornerSize>32 32</backgroundCornerSize>     
</gridtile>

using this image: