New Comic Book Theme!

MikOzzZ

@TMNTturtlguy said in New Comic Book Theme!:

@ortsac Just got a generator running, we have been informed that our power will be out until Wednesday night. Generator is big enough to run the refrigerator a few lights, charge our cell phones and laptop batteries. No internet except for our phone though, so I probably won't be able to get theme update for some time now.

I hope there is not too much damage besides the current?
@pjft as you managed to create a new logo because personally I do not follow the manipulation with illustrator.
I miss it "Lutro, Dos, C64, Cavestrory, ZX81

ruckage

@TMNTturtlguy said in New Comic Book Theme!:

@ortsac Just got a generator running, we have been informed that our power will be out until Wednesday night. Generator is big enough to run the refrigerator a few lights, charge our cell phones and laptop batteries. No internet except for our phone though, so I probably won't be able to get theme update for some time now.

Wow, that's a long while to be without power. And I start to moan when power is out for a few hours. Do you often get power cuts like that due to storms or is it a rare occurrence?

TMNTturtlguy

@ruckage it is a pretty rare occurannce. Typically June and July we get a few good storms that knock over power lines or blow transformers. Most of the time they fix it in 4 hours or less. This was just a huge storm with damaging wind. Storm blew through in 10 minutes. Left 180,000 homes without power due to massive numbers of down trees and power lines.

CodeDrawer

@TMNTturtlguy said in New Comic Book Theme!:

@ruckage it is a pretty rare occurannce. Typically June and July we get a few good storms that knock over power lines or blow transformers. Most of the time they fix it in 4 hours or less. This was just a huge storm with damaging wind. Storm blew through in 10 minutes. Left 180,000 homes without power due to massive numbers of down trees and power lines.

Yikes! I hope it is all over!

pjft

Hi @TMNTturtlguy .

Hope things are going well!

Just wanted to give you a small heads up that the new developments are actually going nicely.

The names for the new system folders are, in the end, "all", "recent" and "favorites". Wanted to make sure you knew that before you release your next update, in case anything needs to change. :)

So far I've been using copies of your existing ones, and it's going well. I just need now to keep the metadata consistent if/when it's updated elsewhere in ES.

Hope you get power back soon!

TMNTturtlguy

@pjft Thanks and glad to hear all is going well. We actually just got power back on! A day earlier than expected. I have completed the theme updates and they are all ready to be uploaded so that everyone can update. The only hold up is that after updating to the newest ES from source which now includes screensavers! the ratings system is broken. I used to have the comic pows with colored overlays (instead of stars). The code for those was identical to the original stars in carbon, i just switched out .svg files. Now the comic pows all show up black and they just get bolder when the rating goes up, no more color/image working on them. On the older ES and even your Screensaver test branch, this worked fine. @jdrassa and @ruckage i did see you guys working on something like this, can you let me know what might have happened? No changes to my theme, so it must be something in the updates?

@pjft - i do have all 3 of your systems ready to go and included. Last played will need some future updates but it works great and for the most part it is all completed. I need to upload and throw together an update post, but was hoping to figure out the rating system before releasing.

If anyone out there is running the newest ES from source with the comic book theme, can you please report if the rating system is all black, or is it still in color on your ES v 2.3.0RP

pjft

@TMNTturtlguy I am almost pretty sure it'd be related to this change.

@jdrassa - what's the right way to keep compatibility for older themes who may not have a color set? Do they need to change anything in the theme? Ideally it'd be out of the box?

@TMNTturtlguy anyway, glad you have power back!

If you do want to test out the current development branch, you can find it at the usual repository, at the Virtual-Systemsbranch. The current version will create "All" and "Last Played" systems, and is fully functional to the best of my knowledge. Things only get out of sync when metadata changes elsewhere (i.e. if you play a game on the actual system, it won't update the play count in the new ones or the sorting order in "last played"... yet).

You don't need to test it out, it's just if you want to have some fun with it. It's based on 2.2.1, though, not 2.3.0 yet.

TMNTturtlguy

@pjft Thanks for the info and for finding the potential change that is causing the issue!

I will gladly help test out your new build, however i have a backlog of a few things to take care of first. Will you also be doing a favorites to go along with the All and Last Played? Can't wait to see it in action.

I will get my theme posted, even with the broken ratings system and then I can apply a fix to that later I guess.

Thanks

ruckage

@TMNTturtlguy said in New Comic Book Theme!:
Hi, I didn't realise the ratings system was being worked on - I had mentioned that it was annoying that you couldn't define the color for the ratings system though. I'll have to check it myself as well.

As it looks like @jdrassa has added the color option you could try adding <color>ffffff</color> into your ratings section to set it to white (perhaps @jdrassa has mistakenly set the default to black).

ruckage

Just tested it on windows and the color is defaulting to black, add <color>ffffff</color> and it works perfectly again. This will affect all themes so will need a fix at some point. I'm quite excited now though as I can now color my ratings to match every system :).

TMNTturtlguy

@ruckage said in New Comic Book Theme!:

<color>ffffff</color>

Yup, it worked! Thanks for the help...Now my only concern is that adding color to something that previously didn't support color might break them for those who have not updated from source.......

pjft

@TMNTturtlguy Agreed. That may break things - it should probably be the default color instead, for backwards compatibility support for themes that omit it. I'm sure it's a quick change, and @jdrassa is usually very much on top of things. Thanks for flagging that, though!

As for the build, there's no need to test - as I said, it was more if you were curious to use it yourself. At this stage, there's not a lot of testing needed :)

I will be doing favorites, but that does depend on "favorites" being included in ES.

@Zigurana : I certainly don't want to add any particular pressure or stress around this, but if you'd want me to, I'm happy to just at least add "favorites" to the metadata at the moment, and then you can bring over the rest of your changes (toggle button, theme support, etc).

Thoughts? If you'd rather not, I'd certainly not insist on taking it over.

There's also @sokiee 's PR, which we could ask to downsize so that it only includes the metadata changes but nothing on the theme side of things, as that was the main discussion at the time (font vs image vs everything else).

Anyways, no urgency whatsoever, just bringing this up.

Hope you're both doing well, while we're at it! :)

ruckage

@TMNTturtlguy said in New Comic Book Theme!:

@ruckage said in New Comic Book Theme!:

<color>ffffff</color>

Yup, it worked! Thanks for the help...Now my only concern is that adding color to something that previously didn't support color might break them for those who have not updated from source.......

Yeah, I know. I have a similar dilemma because the fixes currently needed on my theme will break it for older versions of ES. However I think moving forward is good so I will make the changes and then advise people that they will need the latest version.

In your case it may be worth waiting as I'm sure it's just an oversight on @jdrassa part so will most likely be patched. I've posted to his topic regarding the rating color to let him know about the problem.

TMNTturtlguy

@ruckage @jdrassa I have confirmed that adding a color to the ratings, which fixes the issue in the newest update does infact breack the entire theme in the previous ES builds. Thank you

hansolo77

Very excited to see these new changes. Although not directly related to this thread about this theme... are there going to be instructions set up on how to enable and use these extra menus (favorites, most played, etc)?

Other than that, I too wish to say that's good news that @TMNTturtlguy has power once again. :)

TMNTturtlguy

@hansolo77 I will post the theme updates, hopefully in a few hours after the kids are in bed.

I will provide info on how to set up custom systems with 24 hours of releasing the updates and I will also provide a link to the instructions in how to creat links by @meleu .

As for the ES updates, @pjft is working on those and they will need to be developed and tested. I am providing themes for use in testing. That update will be a future release.

cyperghost

Hehe COWABUNGA!

pjft

@hansolo77 I expect them to be a simple option in the ES menu, and then potentially editing metadata for the favorites (directly in ES, or in a gamelist) :)

hansolo77

@TMNTturtlguy - I see, can't wait to see what happens!

@pjft - That would be the easiest route. I was afraid I'd have to do a bunch of ROM folder creating, moving, editing, etc. If a simple "<favorite>yes|no</favorite>" could be done to a game in a gamelist.xml, that would be easiest.

Now all we need to do is come up with a way for ES to scrape a romlist from RetroAchievments so I can have a menu dedicated to those games, I'd be REALLY happy. :) Right now I just created a subfolder (for instance /RetroPie/roms/nes/_achievements) and copied the roms that have achievements into that folder (making 2 copies). The problem with that is they are always adding new roms, so I have to constantly keep copying more roms. Would be nice if there was an automated way to just build a gamelist.xml that listed those games. Maybe someday!

jdrassa

@TMNTturtlguy @ruckage I just submitted a fix for the the rating component. So the default color was being set to white, but it wasn't being initialized properly which caused it to transparent.

Interestingly, with the Comic theme, the ratings were appearing black because the theme is actually setting them to be black.
https://github.com/TMNTturtleguy/es-theme-ComicBook/blob/master/comic_book.xml#L126

The color is being set to black along with all of the text components. I have seen a few themes do this. Previously, the color setting was ignored, but now it is actually being used. You may notice that in this case md_rating is being used on a <text> element. ES will log a warning about this, but won't fail to load the theme.