Sony DualShock 3 - call for testers: "sixaxis" script module

psyke83 · 23 Jan 2018, 18:30

I updated the PR to really fix first-time pairing of controllers. The instructions on how to pair correctly has been added to the first post.

@xadox said in Sony DualShock 3 - call for testers: "sixaxis" script module:

What is the difference / advantage to the other method you mentioned:
https://retropie.org.uk/forum/topic/11638/dualshock-3-4-testers-needed

Ignore that thread - it's outdated. The default 4.9 kernel hid-sony driver has issues with axis calibration, and the Raspbian version of the BlueZ stack is not compatible with third-party controllers. The scriptmodule upgrades both and makes the necessary changes to ensure they are supported correctly.

lostless · 24 Jan 2018, 05:19

how would one install said driver? I would like to test it.

psyke83 · 1 Feb 2018, 05:12

@lostless said in Sony DualShock 3 - call for testers: "sixaxis" script module:

how would one install said driver? I would like to test it.

You need to be relatively comfortable with using the command-line to test.

These commands will enable the PR branch:

 cd RetroPie-Setup
git remote add psyke83 https://github.com/psyke83/RetroPie-Setup
git fetch psyke83
git checkout sixaxis

Make sure to go back to the official branch after testing the PR! Uninstall sixaxis from the menu, then:

 cd RetroPie-Setup
git checkout master

It's been confirmed that both official and Shanwan controllers are working. I need someone with a Gasia branded pad to test.

madmodder123 · 26 Jan 2018, 03:54

@psyke83 Can you use other BT devices with this or is it like the regular driver?

psyke83 · 26 Jan 2018, 05:14

The point of this is to keep the Bluetooth stack fully enabled. No more hacks will be needed, as it uses the built-in sixaxis pairing of BlueZ.

madmodder123 · 2 Jan 2018, 05:13

@psyke83
Using an OEM PS3 controller:
I tried it and it works fine, except I get the following displayed in the terminal when launching anything from ES:

  INFO: the key you just pressed is not recognized by SDL. To help get this fixed, please report this to the SDL forums/mailing list <https://discourse.libsdl.org/> EVDEV KeyCode 313

It displays a bunch of different key codes depending on which inputs on the controller I had pressed prior to launching the games.
Here is the list of keycodes for the PS3 controller which I grabbed from EVTEST:

Event code 304 (BTN_SOUTH)
Event code 305 (BTN_EAST)
Event code 307 (BTN_NORTH)
Event code 308 (BTN_WEST)
Event code 310 (BTN_TL)
Event code 311 (BTN_TR)
Event code 312 (BTN_TL2)
Event code 313 (BTN_TR2)
Event code 314 (BTN_SELECT)
Event code 315 (BTN_START)
Event code 316 (BTN_MODE)
Event code 317 (BTN_THUMBL)
Event code 318 (BTN_THUMBR)
Event code 544 (BTN_DPAD_UP)
Event code 545 (BTN_DPAD_DOWN)
Event code 546 (BTN_DPAD_LEFT)
Event code 547 (BTN_DPAD_RIGHT)

I am not sure where I can find the log file of these messages (I checked dmesg and the /var/log/ folder but I couldn't find any logs that contain the messages)
I would be glad to find out if it affects all the buttons (i assume it does) but as I mentioned, I do not know the location of the logs for it.

The controller is 100% functional in ES and in-game so I am not entirely sure why SDL is complaining.
I was even able to get a Bluetooth Xbox One controller paired and working along side it :)

psyke83 · 2 Jan 2018, 07:13

@madmodder123,

Thanks for testing. The messages you're receiving also happened with the older PS3 controller driver, but reverting this commit was supposed to solve it.

Can you report your current version of SDL2 that's installed?

dpkg -l | grep sdl2

The messages you're seeing in the terminal are probably emanating from EmulationStation itself. Perhaps you could try checking ~/.emulationstation/es_log.txt and let me know? Or if they don't appear there, if you manually quit EmulationStation and then launch it from an SSH session, you can monitor output directly from the SSH session.

The error isn't fatal, but it's strange... I can't seem to reproduce the problem.

madmodder123 · 2 Jan 2018, 07:29

@psyke83
SDL2 info:

ii  libsdl2-2.0-0:armhf                   2.0.7+2rpi                                 armhf        Simple DirectMedia Layer
hi  libsdl2-dev:armhf                     2.0.7+2rpi                                 armhf        Simple DirectMedia Layer development files
ii  libsdl2-image-2.0-0:armhf             2.0.0+dfsg-3+b1                            armhf        Image loading library for Simple DirectMedia Layer 2, libraries
ii  libsdl2-image-dev:armhf               2.0.0+dfsg-3+b1                            armhf        Image loading library for Simple DirectMedia Layer 2, development files
ii  libsdl2-mixer-2.0-0:armhf             2.0.0+dfsg1-5                              armhf        Mixer library for Simple DirectMedia Layer 2, libraries
ii  libsdl2-mixer-dev:armhf               2.0.0+dfsg1-5                              armhf        Mixer library for Simple DirectMedia Layer 2, development files
ii  libsdl2-ttf-2.0-0:armhf               2.0.12+dfsg1-2                             armhf        TrueType Font library for Simple DirectMedia Layer 2, libraries
ii  libsdl2-ttf-dev:armhf                 2.0.12+dfsg1-2                             armhf        TrueType Font library for Simple DirectMedia Layer 2, development files

I was able to use the SSH method you mentioned above and I was able to verify that all of the controls produce the message (except events 304, 305, 307, & 308 but I wasn't able to find a way to activate them)

I guess I should have mentioned that I am using RetroPie 4.3.9 on a Pi3.

So I did some testing...
This issue does NOT occur when using the binary install from the retropie script.
This issue DOES appear when using the source install from the retropie script.

I am using a stable (NOT MASTER) branch of ES I compiled myself (in which I just changed some fonts/icons).
How much older is the binary of ES compared to the stable branch source? It seems like the stable branch doesn't get updated very much from the last time I looked at it in github.

I'm curious on what is causing this and how to resolve it.

psyke83 · 1 Feb 2018, 23:35

I think that the difference here has nothing to do with changes in EmulationStation, and everything to do with the SDL2 library/headers installed on your system that are used to build the program. You'd see those errors when using an unpatched SDL2 library... but it seems that the version on your system (2.0.7+2rpi) is up to date.

I can't reproduce this by building EmulationStation from source, but I'm currently testing on stretch. I don't recall seeing this when I was testing on a standard jessie image, however. Perhaps try to rebuild/reinstall the SDL2 packages and then EmulationStation:

 sudo ./retropie_packages.sh sdl2
sudo ./retropie_packages.sh emulationstation

madmodder123 · 2 Feb 2018, 06:37

@psyke83
So I did the commands you suggested above, and the issue was not resolved I then ran the following:

sudo apt-get remove --purge libsdl2-dev
sudo apt-get -f install &&
sudo apt-get autoremove &&
sudo apt-get -y autoclean &&
sudo apt-get -y clean

after running those I tried to reinstall SDL/ES again and the error messages still occurs.

Does it matter that I have this version of SDL still installed?:

hi  libsdl1.2-dev                         1.2.15-12rpi                                                                                                  armhf        Simple DirectMedia Layer development files
ii  libsdl1.2debian:armhf                 1.2.15-12rpi                                                                                                  armhf        Simple DirectMedia Layer

I have been using and updating this image of RetroPie for a little over a year now (i'm not sure which version I started with). Perhaps that has something to do with this?

psyke83 · 2 Feb 2018, 07:20

I tried doing the opposite; I rebuilt SDL with the patch that I mentioned earlier re-applied to the source, and couldn't reproduce the SDL log spam, even after rebuilding EmulationStation. I'm quite perplexed at the situation, as my controller produces the same keycode values as yours, but I've never seen these messages on jessie or stretch.

If you happen to have a spare SD card, perhaps you could try re-installing the latest image and testing the PR on a fresh installation? That's asking a lot, however, so don't feel obliged. The next release is going to be based on stretch, so perhaps it's better to wait a little while for that.

Apart from the spam, have you encountered any issues? It's been reported to me that ps3controller (sixad) causes dropped inputs when multiple controllers are used; I'm curious if the PR improves that situation or not.

Your version of SDL1 is also up-to-date, but as far as I can tell it doesn't have the same problem, and EmulationStation uses SDL2 exclusively.

madmodder123 · 2 Feb 2018, 07:39

I can try it on a fresh image of RP this weekend, when you mean multiple controllers do you mean multiple PS3 controllers? or a combination of different controllers?
Any idea when the next RP version based on Stretch is going to be released? Maybe I could just wait for it to come out and copy all my custom settings/files from my current image to a fresh image (although that would be a major task in and of itself, I have added an ungodly amount of customization to my image).
Also I might be able to compress my image and host it on Dropbox or something if you really want to take a look at it.

madmodder123 · 3 Feb 2018, 07:42

@psyke83 Good news, I was able to compile ES from a fresh copy of RetroPie and then copy that executable over to my original image and the message no longer appears :)

psyke83 · 3 Feb 2018, 08:23

@madmodder123 said in Sony DualShock 3 - call for testers: "sixaxis" script module:

@psyke83 Good news, I was able to compile ES from a fresh copy of RetroPie and then copy that executable over to my original image and the message no longer appears :)

Good news - so let's assume it's a quirk from your installation that won't impact most users. If you really want to figure out why it's happening, some thoughts below.

I posted the wrong link before; this is the commit that should have fixed your problem.

Perhaps you could try to do a grep of the libraries on your system:

grep -r "key you just pressed" /usr/lib

Mine results in a match in libSDL2, but it's only the message from the X11 video driver which doesn't get used on RetroPie (and yours was also the EVDEV one that the commit above would silence):

$ strings /usr/lib/arm-linux-gnueabihf/libSDL2-2.0.so.0.7.0 | grep "key you just pressed"
The key you just pressed is not recognized by SDL. To help get this fixed, please report this to the SDL forums/mailing list <https://discourse.libsdl.org/> X11 KeyCode %d (%d), X11 KeySym 0x%lX (%s).

Perhaps you could also try rebuilding EmulationStation and grepping the resulting binary for the string... although I don't see why that'd happen unless you modified the source to statically link SDL2 into the executable.

pjft · 8 Feb 2018, 18:35

Thanks @psyke83 , this works great on my end as well with the original PS3 controllers and Shanwan as well.

Does anyone have gasia controllers they could test? Tagging @meleu @mediamogul @cyperghost in hopes one of them would have these? :)

cyperghost · 8 Feb 2018, 18:55

@pjft No ...2 idroid:con paddels here ;)

mediamogul · 8 Feb 2018, 19:25

@pjft

Sorry, none here either.

pjft · 10 Feb 2018, 09:40

@mediamogul @cyperghost thanks, sorry for tagging you. It was worth a shot? :)

mediamogul · 10 Feb 2018, 16:05

@pjft said in Sony DualShock 3 - call for testers: "sixaxis" script module:

sorry for tagging you. It was worth a shot? :)

Not a problem. Never hurts to ask.

cyperghost · 10 Feb 2018, 17:57

@pjft No problem bro
Always here for help :)

	cd RetroPie-Setup
	git remote add psyke83 https://github.com/psyke83/RetroPie-Setup
	git fetch psyke83
	git checkout sixaxis

	sudo ./retropie_packages.sh sdl2
	sudo ./retropie_packages.sh emulationstation