Chicuelo Theme

cloudlink

This awesome theme is getting better and better! I really like this theme. The list of missing consoles is getting smaller.
vectrex
sg-1000
ngp
ngpc
intellivision
nds
msx
msx2
supergrafx

movisman

@chicuelo

PR raised for the new readme! Will raise another over the weekend with further corrections i'm sure.

I noticed you have a branch called pr/1 in addition to the master one. I can see that hasn't been altered for ages and i'm not convinced it's needed any more. Maybe you could delete that branch to tidy things up?

Cheers

chicuelo

@cloudlink

Working on that! Soon the theme will cover the most used (and not too) systems!
Thanks for the support!

chicuelo

@movisman
Great! updated the readme.
I have no I dea what a branch is and what is used for but I deleted :) now there is a master one only

movisman

@chicuelo

Awesome. Thank you! And thanks for deleting the orphan branch.

I have been working with command line for Git stuff but still finding some of it a bit odd to get to grips with and I keep forgetting some of the commands, so I installed GitKraken due to recommendation from someone else. So far I like it and I reckon i'll learn more this way. The documentation on their website is also much easier for me to understand. This is where I spotted that other branch!

About what a branch is - from the GitHub docs:
When you're working on a project, you're going to have a bunch of different features or ideas in progress at any given time – some of which are ready to go, and others which are not. Branching exists to help you manage this workflow.

When you create a branch in your project, you're creating an environment where you can try out new ideas. Changes you make on a branch don't affect the master branch, so you're free to experiment and commit changes, safe in the knowledge that your branch won't be merged until it's ready to be reviewed by someone you're collaborating with.

As far as I understand, creating a branch is useful for when you are working on something but you don't want to affect the 'master'. Once you are happy with the work on the branch, you can then merge this into the master and remove the branch, as it's not likely to be required anymore.

For a project like this, where only you are managing the master and accepting PR's as they come in, unless you are making big changes to the theme, I doubt you'd need to use branches unless it helps your workflow. Someone who knows more about GitHub may correct me though, and please do (still learning).

With this, we are just adding new stuff and not even really changing files at the same time, so we don't really make use of the GitHub feature set. I just found it easier to work from my forked master and raise PR's off that!

Cheers

PS. I am a total novice with GitHub, only started using it regularly when I first helped with this theme! Prior to that I think I have done a couple of pull requests for other projects and that's about it!

chicuelo

@movisman
Great explanation! Thanks!

movisman

@chicuelo

Superb additions with Intellivision and Vectrex!

I notice the readme.md has got a bit messed up with what looks like a merge you have performed. Let me sort it out and i'll raise a PR for it.

Cheers

movisman

@chicuelo

Okay all fixed up and updated, if you accept my PR - should be ok now.

Thanks! :)

chicuelo

@movisman
Done!

movisman

@chicuelo @cloudlink

Raised a PR for partial SuperGrafx (alternative system) support:

Created and added SuperGrafx logo, plus theme.xml description for partial support
Used PC Engine character background as the SuperGrafx is an upgraded version. Did not copy an existing controller though as SuperGrafx had it's own type. Left this blank for now but it would need creating to gain full support (like Super Famicom)
Updated readme.md

Thanks

movisman

@chicuelo

Updated my PR to include PC Engine CD and TurboGrafx-16 CD systems. Created logo and theme.xml for both. These ones are fully supported/finished, as they use the same controller and character image as PC Engine/TurboGrafx-16.

Updated the readme.md to suit.

Cheers

chicuelo

@movisman
Merged!

movisman

@chicuelo

Was just having a quick look to see if I could find controllers for any 'partially' supported systems, and it's really hard to find a Super Famicom controller or Supergrafx one.

I was wondering if you could take a copy of the other EU SNES controller, and then copy the logo and select/start writing from here and put it in place of the EU SNES logo and button names?
http://farm9.staticflickr.com/8530/8553686769_5cc75647bd_o.png

But that's the only difference between the two controllers (name and button font). Rest is the same I think!

You can see all three here:
https://www.flickr.com/photos/mattgemmell/8548671880

We already have the EU and US ones, just the Famicom one is required.

The best Supergrafx controller i've found is this:
http://4.bp.blogspot.com/_6L8vOhCmEx0/R8__zD3uUaI/AAAAAAAAC9w/LjzDNAPaLB0/s1600/l_supergrafx_pad2.jpg

There are others but they are at an angle or lower res.

I must be looking in the wrong places - these controllers are hard to find decent 'top down' images of!

What do you think? Or can you not work with these?

The good news is, once these are complete, I think we have all the main system variations + additional systems people might want to use (except Odyssey 2, which would need to be done at the same time as VideoPac).

Then it's just a case of finishing the primary systems (MSX, Neo Geo Pocket, etc, etc).

The readme I made should be fully up to date with what's left hopefully.

We also need a 'custom collections' bg to finish that theme off too.

Cheers

chicuelo

@movisman
I can use some actual controllers and mix with the right logos and texts so dont worry!
Im short of time right now but when I have a break I will update those!

chicuelo

@movisman
Updated, Don't know if the name of the files are ok!

movisman

@chicuelo

Thank you man! Great stuff.

The name of the Super Famicom one doesn't match the theme I set up, but let me correct that and raise a PR shortly :)

movisman

@movisman

PR raised with file deletion and correction, plus readme.md updated to indicate those two systems are fully supported!

Thanks :)

chicuelo

@movisman
Merged! I think the next step is finishing all the remaining systems

movisman

@chicuelo

Thanks!

Yes I totally agree. I went off on a bit of a tangent creating the alternative systems, even though I said we should concentrate on the primary systems first :) but most of them just needed a logo creating and a description writing (as character and controller can stay the same), so this was something I was able to get on with myself, with the exception of those couple of controllers you kindly created.

Where did you get those from?! I searched for ages for a decent SuperGrafx controller!! Haha!

I think the most common ones are complete now for 'alternatives' - which is great, and will make people happy who like to split out their PC Engine stuff into multiple systems or use a Famicom instead of NES, etc.

I have tried to keep the readme nice and up to date. The 'partially' supported systems I have listed are the ones which need a controller and/or character creating. I will keep maintaining this as you work towards completion for the artwork. There are so many systems fully supported, it's really great! The theme is so good now, and to get it completed for all systems will be a real achievement. There are a fair few themes out there which are not totally complete - themes like Pixel are really popular because they look good - but also they are complete which can make them stand out from some of the others.

Once it's complete, it'll be nice to just do the odd update / enhancement here and there!

Cheers :)

chicuelo

@movisman
Great! Hope to complete them all soon.
For the controllers I modify a turbografx controller and add the particularities of the supergrafx one, some makeup in photoshop, just like the ones one