RetroPie forum home
    • Recent
    • Tags
    • Popular
    • Home
    • Docs
    • Register
    • Login
    Please do not post a support request without first reading and following the advice in https://retropie.org.uk/forum/topic/3/read-this-first

    [Solved] How to bind a shell command to a hotkey? (raspi2png)

    Scheduled Pinned Locked Moved Help and Support
    hotkeyshortcutscreenshotraspi2png
    59 Posts 6 Posters 11.6k Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • mituM
      mitu Global Moderator
      last edited by mitu

      Yes, the dreaded \, forgot about them - I was testing with an emulator started. This can be fixed taking the sed command from your initial line:

      raspi2png --pngname "$(ps a | grep RetroPie/roms | awk -F "/" 'NR==1 { print $NF }' | sed 's/\.[^.]*$//g; s#\\##g')"-$(date +%Y.%m.%d-%H.%M.%S).png
      

      E.T.\ The\ Extra-Terrestrial\ \(1982\)\ \(Atari\)\ \(PAL\)\ \[\!\]-2019.02.23-17.20.15.png becomes E.T. The Extra-Terrestrial (1982) (Atari) (PAL) [!]-2019.02.23-17.25.43.png

      ClydeC 2 Replies Last reply Reply Quote 1
      • ClydeC
        Clyde @mitu
        last edited by

        @mitu To answer in German: Wunderbar! ๐Ÿ˜„

        1 Reply Last reply Reply Quote 0
        • ClydeC
          Clyde @mitu
          last edited by Clyde

          @mitu said in How to bind a shell command to a hotkey? (raspi2png):

          aspi2png --pngname "$(ps a | grep RetroPie/roms | awk -F "/" 'NR==1 { print $NF }' | sed 's/\.[^.]*$//g; s#\\##g')"-$(date +%Y.%m.%d-%H.%M.%S).png
          

          You might want to change that to raspi2png with an "r". ๐Ÿ˜‰

          edit: Aaaand โ€ฆ I saw your post changing while I was waiting for this post to appear. ๐Ÿ˜†

          mituM 1 Reply Last reply Reply Quote 0
          • mituM
            mitu Global Moderator @Clyde
            last edited by mitu

            @Clyde I already did :). Anyway, I think you should add a reference to your solution post to your 1st post, so people can find it without reading to the whole topic.
            Now the challenge is to find the equivalent of raspi2png for other platforms (Odroid, Pc).

            ClydeC 2 Replies Last reply Reply Quote 0
            • ClydeC
              Clyde @mitu
              last edited by Clyde

              @mitu Did you read my mind? I just did that. ๐Ÿ˜ฑ ๐Ÿ˜„

              edit: Er โ€ฆ sorry, I didn't do that, but added a reference of your raspi2png solution to my first one. Adding the reference that you meant now. ๐Ÿ˜ณ

              1 Reply Last reply Reply Quote 1
              • ClydeC
                Clyde @mitu
                last edited by

                @mitu Done, along with "[Solved]" in the title and my How-To updated with your raspi2png line.

                I love communities like this for such constructive synergy. ๐Ÿ˜Š

                1 Reply Last reply Reply Quote 0
                • roslofR
                  roslof
                  last edited by roslof

                  Love this thread, but I may need a smidgen more help to get this to work.

                  I followed Clyde's guide to the letter, but after pressing the defined key, entering sudo systemctl status triggerhappy.server yields:

                  Feb 23 19:01:19 retropie thd[2523]: Executing trigger action: raspi2png --pngname "/home/pi/$(ps a | grep RetroPie/roms | awk -F "/" 'NR==1 { print $NF }' | sed 's/.[^.]*$//g; s <---abruptly ends
                  Feb 23 19:01:19 retropie thd[2523]: sh: 1: Syntax error: Unterminated quoted string

                  Looks like it's cutting off the command line... No idea why. It looks fine in the config file. Actually, I just noticed that the line is being cut after EXACTLY 128 characters... So I wager I'm experiencing some character line limit that y'all are not.
                  Edit: It turned out the character limit was a red herring and not the cause.

                  FWIW, if I copy the same information from Step 4 into bash (removing KEY_SYSRQ 1) it works fine, and raspi2png takes the shot and the output file is named correctly. So the syntax as provided by Clyde (via Mitu) is definitely correct.

                  I'm only having trouble w/triggerhappy truncating the line from the config file in triggers.d.

                  Any advice?

                  mituM 1 Reply Last reply Reply Quote 0
                  • mituM
                    mitu Global Moderator @roslof
                    last edited by

                    @roslof If you post the contents of the /etc/triggerhappy/triggers.d/raspi2png.conf we may be able to spot any errors.

                    roslofR 1 Reply Last reply Reply Quote 0
                    • roslofR
                      roslof @mitu
                      last edited by roslof

                      @mitu You bet, but it really is the same as step 4 above, and it definitely works at a bash prompt:

                      KEY_SYSRQ 1 raspi2png --pngname "/home/pi/$(ps a | grep RetroPie/roms | awk -F "/" 'NR==1 { print $NF }' | sed 's/\.[^.]*$//g; s#\\##g')"-$(date +%Y.%m.%d-%H.%M.%S).png
                      

                      Syntax-wise, this is good. It just gets cropped during parsing after the 128th character.

                      I did, however, figure out a work-around. I just created a separate script/.sh to run raspi2png w/all the parameters. Then I just called the script from raspi2png.conf ;-)

                      My work-around:

                      Newly added /etc/triggerhappy/triggers.d/run-raspi2png.sh ensure executable perm flag is set

                      raspi2png --pngname "/home/pi/$(ps a | grep RetroPie/roms | awk -F "/" 'NR==1 { print $NF }' | sed 's/\.[^.]*$//g; s#\\##g')"-$(date +%Y.%m.%d-%H.%M.%S).png
                      

                      Revised /etc/triggerhappy/triggers.d/raspi2png.conf

                      KEY_SYSRQ 1 /etc/triggerhappy/triggers.d/run-raspi2png.sh
                      

                      Edit Note: Previously posted a line that used nohup, which was non-essential. For the curious, it was: KEY_SYSRQ 1 nohup /etc/triggerhappy/triggers.d/run-raspi2png.sh 0<&- &>/dev/null &

                      I have to say, the command-line arguments you and Clyde created are super-creative. I never would have imagined a screen capture with proper naming, and a solution for ANY emulator, including non-Retroarch. Great work, guys!

                      roslofR ClydeC 2 Replies Last reply Reply Quote 2
                      • roslofR
                        roslof @roslof
                        last edited by roslof

                        removed post based on insights from mitu

                        mituM 1 Reply Last reply Reply Quote 0
                        • mituM
                          mitu Global Moderator @roslof
                          last edited by

                          @roslof That's not necessary on Raspbian (and RetroPie) since the pi user is already a member of the video group and has access to /dev/vchiq. This kind of advice (make the /dev/whatever writable to anyone) it's just encouraging bad practice - don't do it, instead make sure your user is in the correct group.

                          roslofR 1 Reply Last reply Reply Quote 0
                          • roslofR
                            roslof @mitu
                            last edited by

                            @mitu Helpful. I'll edit the post. Unclear why I was in this state.

                            mituM 1 Reply Last reply Reply Quote 0
                            • ClydeC
                              Clyde @roslof
                              last edited by Clyde

                              @roslof Thanks for reporting this and for the workaround. I'll admit that I didn't test the last version of the string (note to myself: always test things before putting them online, even slight alterations of existing things).

                              It can't be the length (alone), though. I tested the command echo "...1.........2.........3..." and so on to test a string limit for command in the raspi2png.conf, but it worked well up to the 140 characters that I tested.

                              This is the output of sudo systemctl status triggerhappy.service with the last version of @mitu's string:

                              Feb 24 09:11:54 raspi thd[1458]: Executing trigger action: raspi2png --pngname "$(ps a | grep RetroPie/roms | awk -F "/" 'NR==1 { print $NF }' | sed 's/\.[^.]*$//g; s
                              Feb 24 09:11:54 raspi thd[1458]: sh: 1: Syntax error: Unterminated quoted string
                              

                              Thanks for the compliments, I want to add @Lolonois who provided the very first part of the command string.

                              @mitu My knowledge about bash fu is very limited. Do you have any idea what can cause this?

                              mituM 1 Reply Last reply Reply Quote 0
                              • mituM
                                mitu Global Moderator @roslof
                                last edited by

                                @roslof You shouldn't have :), now my reply doesn't make any sense.

                                ClydeC 1 Reply Last reply Reply Quote 0
                                • ClydeC
                                  Clyde @mitu
                                  last edited by

                                  @mitu @roslof Right, I missed the deleted post and now I'm wondering what it may have been about. ๐Ÿ˜‰

                                  roslofR 1 Reply Last reply Reply Quote 0
                                  • mituM
                                    mitu Global Moderator @Clyde
                                    last edited by

                                    @Clyde Hm, I bet it's because it interprets the # as a comment start. Try this

                                    raspi2png --pngname "/home/pi/$(ps a | grep RetroPie/roms | awk -F "/" 'NR==1 { print $NF }' | sed 's/\.[^.]*$//g; s/\\//g')"-$(date +%Y.%m.%d-%H.%M.%S).png
                                    
                                    ClydeC 1 Reply Last reply Reply Quote 0
                                    • roslofR
                                      roslof @Clyde
                                      last edited by

                                      @Clyde sorry, man -- but it sounded like a sub-par solution to perms issues I was having. Since mitu advised not to follow the directions, I felt it best not to give that information to the public, in case they didn't get the warning.

                                      mituM 1 Reply Last reply Reply Quote 0
                                      • mituM
                                        mitu Global Moderator @roslof
                                        last edited by

                                        @roslof It's ok to leave it - this way when someone googles for this advice will see that a reply with 'bad dog' has been added and think: "Hey, that's how you do it right".

                                        1 Reply Last reply Reply Quote 0
                                        • ClydeC
                                          Clyde @mitu
                                          last edited by Clyde

                                          @mitu That works! I'll update my solution with this and add a remark about @roslof's workaround in case someone wants to run a script instead of a single command. Thank you both!

                                          edit: Just when you posted your solution, I wanted to report that changing the length by removing the whitespaces before and after the pipes didn't change the point of cutting off the line. You were faster. ๐Ÿ˜‰

                                          @roslof As @mitu said, it's better (and widely seen as more honest and polite) to leave it and maybe crossing it out and/or commenting below it that it has been wrong. Just a friendly advice. ๐Ÿ˜Š

                                          roslofR 1 Reply Last reply Reply Quote 0
                                          • mituM
                                            mitu Global Moderator
                                            last edited by

                                            @roslof 's solution is also better when you just want to change something to the script command, since you don't need to re-start the thd service or edit the .conf file - any edits to the .sh file will take effect immediately.

                                            ClydeC 1 Reply Last reply Reply Quote 0
                                            • First post
                                              Last post

                                            Contributions to the project are always appreciated, so if you would like to support us with a donation you can do so here.

                                            Hosting provided by Mythic-Beasts. See the Hosting Information page for more information.