Error after updating retropie-setup to 4.4.9 (a161774a)
-
I still haven't had luck reproducing the issue, unfortunately. I tried masking a controller via xboxdrv, writing a python script to emulate a dummy joystick via uinput and I even dug out an old PS2 clone controller that has a USB connection, but I couldn't reproduce the issue with the combination of two controllers connected but only one mapping set up.
Is it possible that your SNES to USB adapter is the source of the problem because it emits joystick nodes for devices that aren't connected? Try to unplug your mapped iBuffalo gamepad (and/or any other mapped controllers) to see if you can trigger the error just when you have the unmapped SNES to USB adapter connected.
-
@psyke83 said in Error after updating retropie-setup to 4.4.9 (a161774a):
Is it possible that your SNES to USB adapter is the source of the problem because it emits joystick nodes for devices that aren't connected?
Well, one of the port is not connected, one has a SNES controller attached. But I can give it a try and connect a real controller instead of the adapter.
Try to unplug your mapped iBuffalo gamepad (and/or any other mapped controllers) to see if you can trigger the error just when you have the unmapped SNES to USB adapter connected.
Unfortunately I don't have a keyboard, but I can try with another controller instead of the iBuffalo.
-
I removed the 2SNES-to-USB adapter and connected a 8Bitdo SN30 via USB.
cat /proc/bus/input/devices I: Bus=0003 Vendor=0583 Product=2060 Version=0110 N: Name="USB,2-axis 8-button gamepad " P: Phys=usb-3f980000.usb-1.4/input0 S: Sysfs=/devices/platform/soc/3f980000.usb/usb1/1-1/1-1.4/1-1.4:1.0/0003:0583:2060.0001/input/input0 U: Uniq= H: Handlers=js0 event0 B: PROP=0 B: EV=1b B: KEY=ff 0 0 0 0 0 0 0 0 0 B: ABS=3 B: MSC=10 I: Bus=0003 Vendor=2dc8 Product=ab20 Version=0110 N: Name="SNES30 SNES30 Joy " P: Phys=usb-3f980000.usb-1.5/input0 S: Sysfs=/devices/platform/soc/3f980000.usb/usb1/1-1/1-1.5/1-1.5:1.0/0003:2DC8:AB20.000D/input/input9 U: Uniq= H: Handlers=js1 event1 B: PROP=0 B: EV=1b B: KEY=fff 0 0 0 0 0 0 0 0 0 B: ABS=30027 B: MSC=10
Without configuring it, I get the same error when starting the setup script (with the iBuffalo controller).
I've configured the 8bitdo in Emulationstation, auto-conf got generated. Starting again the setup script - no more errors.I removed the iBuffalo auto-config file, then started again the setup script - the error pops up again (IndexError: list index out of range, etc.).
I'm thinking @Efriim got the error because he paired an Bluetooth controller, then returned back to the setup script with an extra
/dev/input/jsX
device - unconfigured at that point. -
@mitu said in Error after updating retropie-setup to 4.4.9 (a161774a):
I removed the 2SNES-to-USB adapter and connected a 8Bitdo SN30 via USB.
cat /proc/bus/input/devices I: Bus=0003 Vendor=0583 Product=2060 Version=0110 N: Name="USB,2-axis 8-button gamepad " P: Phys=usb-3f980000.usb-1.4/input0 S: Sysfs=/devices/platform/soc/3f980000.usb/usb1/1-1/1-1.4/1-1.4:1.0/0003:0583:2060.0001/input/input0 U: Uniq= H: Handlers=js0 event0 B: PROP=0 B: EV=1b B: KEY=ff 0 0 0 0 0 0 0 0 0 B: ABS=3 B: MSC=10 I: Bus=0003 Vendor=2dc8 Product=ab20 Version=0110 N: Name="SNES30 SNES30 Joy " P: Phys=usb-3f980000.usb-1.5/input0 S: Sysfs=/devices/platform/soc/3f980000.usb/usb1/1-1/1-1.5/1-1.5:1.0/0003:2DC8:AB20.000D/input/input9 U: Uniq= H: Handlers=js1 event1 B: PROP=0 B: EV=1b B: KEY=fff 0 0 0 0 0 0 0 0 0 B: ABS=30027 B: MSC=10
Without configuring it, I get the same error when starting the setup script (with the iBuffalo controller).
I've configured the 8bitdo in Emulationstation, auto-conf got generated. Starting again the setup script - no more errors.I removed the iBuffalo auto-config file, then started again the setup script - the error pops up again (IndexError: list index out of range, etc.).
I'm thinking @Efriim got the error because he paired an Bluetooth controller, then returned back to the setup script with an extra
/dev/input/jsX
device - unconfigured at that point.I was only talking about not being able to reproduce the
bad file descriptor
warnings.When talking about seeing the
IndexError: list index out of range
again, do you mean without the PR active? I was under the impression that it would clear up allIndexError
exceptions at the very least. -
@psyke83 said in Error after updating retropie-setup to 4.4.9 (a161774a):
I was only talking about not being able to reproduce the bad file descriptor warnings.
Ah, ok then - I was thinking the other way around. Yes, I'm using
master
to produce theIndexError
, so it's without your PR and it's normal to have the error. -
@mitu said in Error after updating retropie-setup to 4.4.9 (a161774a):
@psyke83 said in Error after updating retropie-setup to 4.4.9 (a161774a):
I was only talking about not being able to reproduce the bad file descriptor warnings.
Ah, ok then - I was thinking the other way around. Yes, I'm using
master
to produce theIndexError
, so it's without your PR and it's normal to have the error.OK; I've merged the PR as-is, since it fixes the more serious issue that actually causes joy2key to break. When I can find a way to reliably reproduce the
bad file descriptor
warning, I'll fix that separately; I'd prefer not go back to using naked exception as they increase the probability of the script failing to exit cleanly when interrupted.Thank you all for the assistance and be sure to ping me if you find another way to trigger the warning that I can reproduce on my end.
-
Excuse me, seems last update broken joy2key, is there a fix for that? Thx in advance
-
@DarishZone Update your RetroPie script - what version do you have ?
-
@mitu said in Error after updating retropie-setup to 4.4.9 (a161774a):
@DarishZone Update your RetroPie script - what version do you have ?
4.4.9
-
@DarishZone You'll have to be more exact - what problem are you encountering and what's the revision next to the 4.4.9 version ?
-
@mitu said in Error after updating retropie-setup to 4.4.9 (a161774a):
@DarishZone You'll have to be more exact - what problem are you encountering and what's the revision next to the 4.4.9 version ?
Yeah, it's a text random error during loading screen or black screen (example access retropie setup screen), it seems referring to joy2key, impossible to reproduce but maybe message is stored somewhere on logs.
I've just update to last version, which is 4.4.9 -
@DarishZone Do you have any problems navigating the setup with your joystick/gamepad ?
-
@mitu said in Error after updating retropie-setup to 4.4.9 (a161774a):
@DarishZone Do you have any problems navigating the setup with your joystick/gamepad ?
Gamepad works, i don't think is big deal
-
Also got this error, even if i think is not releated to joy2key but a python script i use for bgm (guessing)
Could be useful for someone
-
@DarishZone The exception message from the picture was mentioned by @Efriim also and we've talked about this in the topic. If you have another error message you see, please add some info about it.
@psyke83 I did some small tests, it appears in the
close_fds
method raises the OSError exception, most likely because of the closure of an already closedfd
and it's probably during the TERM signal handler (hence the threading module reference).
I re-installed a 4.4 image, updated RP (including the fix from this topic) and the OS only and get this error after the 1stjoy2key
invocation with just the one SNES iBuffalo controller connected and configured. -
@mitu said in Error after updating retropie-setup to 4.4.9 (a161774a):
@DarishZone The exception message from the picture was mentioned by @Efriim also and we've talked about this in the topic. If you have another error message you see, please add some info about it.
@psyke83 I did some small tests, it appears in the
close_fds
method raises the OSError exception, most likely because of the closure of an already closedfd
and it's probably during the TERM signal handler (hence the threading module reference).
I re-installed a 4.4 image, updated RP (including the fix from this topic) and the OS only and get this error after the 1stjoy2key
invocation with just the one SNES iBuffalo controller connected and configured.Thanks! I finally managed to reproduce the error, but only by running multiple concurrent instances of joy2key. Regardless, I think that this PR should solve the problem: https://github.com/RetroPie/RetroPie-Setup/pull/2655
Please test and let me know if this solves the issue to your satisfaction.
-
@psyke83 said in Error after updating retropie-setup to 4.4.9 (a161774a):
@mitu said in Error after updating retropie-setup to 4.4.9 (a161774a):
@DarishZone The exception message from the picture was mentioned by @Efriim also and we've talked about this in the topic. If you have another error message you see, please add some info about it.
@psyke83 I did some small tests, it appears in the
close_fds
method raises the OSError exception, most likely because of the closure of an already closedfd
and it's probably during the TERM signal handler (hence the threading module reference).
I re-installed a 4.4 image, updated RP (including the fix from this topic) and the OS only and get this error after the 1stjoy2key
invocation with just the one SNES iBuffalo controller connected and configured.Thanks! I finally managed to reproduce the error, but only by running multiple concurrent instances of joy2key. Regardless, I think that this PR should solve the problem: https://github.com/RetroPie/RetroPie-Setup/pull/2655
Please test and let me know if this solves the issue to your satisfaction.
In case it helps, this is the script I used to reproduce the error:
#!/bin/bash SLEEP_TIME=$1 [[ -z "$SLEEP_TIME" ]] && SLEEP_TIME=1 function joy2keystart() { __joy2key_ppid=$$ ~/RetroPie-Setup/scriptmodules/supplementary/runcommand/joy2key.py /dev/input/jsX kcub1 kcuf1 kcuu1 kcud1 0x0a 0x20 & } function joy2keystop() { kill $(pgrep -f joy2key.py) 2>/dev/null } function joy2keytoggle() { joy2keystart sleep "$SLEEP_TIME" joy2keystop } while true; do echo "loop" joy2keytoggle & joy2keytoggle & joy2keytoggle & joy2keytoggle & joy2keytoggle done
Note that my i7 laptop required around 3-5 concurrent instances to trigger the warning, but the Pi could do reproduce it with just two.
-
@mitu said in Error after updating retropie-setup to 4.4.9 (a161774a):
@DarishZone The exception message from the picture was mentioned by @Efriim also and we've talked about this in the topic. If you have another error message you see, please add some info about it.
@psyke83 I did some small tests, it appears in the
close_fds
method raises the OSError exception, most likely because of the closure of an already closedfd
and it's probably during the TERM signal handler (hence the threading module reference).
I re-installed a 4.4 image, updated RP (including the fix from this topic) and the OS only and get this error after the 1stjoy2key
invocation with just the one SNES iBuffalo controller connected and configured.My bad, probably i missed the part of topic where you talk about it.
Ive got only this and the joy2key error at the moment. -
@psyke83 said in Error after updating retropie-setup to 4.4.9 (a161774a):
Please test and let me know if this solves the issue to your satisfaction.
That seems to work - there's no more exception shown on the terminal background. Thank you.
-
Yay. So the fix ended up being on line 134? You don't have to explain, I wouldn't understand.
Unrelated, is there any chance that the runcommand button response will get fixed?
To break it down, it only responds to an input right after the pop-up/launching.png disappears. Making the delay entirely pointless, and just being difficult to invoke.
Contributions to the project are always appreciated, so if you would like to support us with a donation you can do so here.
Hosting provided by Mythic-Beasts. See the Hosting Information page for more information.