New Theme Testing

f.caruso

@lilbud I like your theme a lot, but there are 2 things in ES source code.

First : there is a bug in void SystemView::renderCarousel(const Transform4x4f& trans)
When you switch system, as logoCount is 1, you cannot see 2 logos at the same time.
The actual code is -> Must be changed to ignore if an animation is running :

if (logoCount == 1) // Should add -> && mCamOffset == 0
{
bufferLeft = 0;
bufferRight = 0;
}

Second : As you don't display logo at center, you have to reposition your carousel. When you scroll ( it is very annoying if it is horizontal ), logo disapears partially : it stays in the bound of the carousel. for that, a property "logoPos" is missing. With that propery, your carousel could be posed at 0 0 and sized 1 1, and logoPos set at 0.6603221083455344 0.171875.

With those changes, your systemview is perfect... But it needs some changes in ES code...

I did it in my Windows version ( i didn't publish it yet as I have other unfinished changes pendings ), but I don't know how to do that in RetroPie's version neither how to contact people how manage it... I can only tell how to fix it...

@mitu : Do you know how do to that ?

mitu

@f-caruso said in New Theme Testing:

@mitu : Do you know how do to that ?

You can always send a pull request to the RetroPie's repository with the fix you found, I'm sure it will be appreciated.
For the 2nd part (logosPos ?) - is this a new feature or just something that @lilbud should add to the theme ?

f.caruso

@mitu said in New Theme Testing:

feature

"logoPos" would be a new feature. ES supports logoSize but not logoPos ->
You cannot set the position of the logo inside the carousel, it is always centered.

lilbud

@f-caruso What system are you talking about

Also, I only became aware of your custom emulationstation build yesterday. I haven't had the time to test yet.

What changes have you made to the source code that might cause issues?

lilbud

@f-caruso I just tested the theme on your ES build, (after switching the language to english and figuring out the controls) The theme seems to work completely fine.

Also, if you can figure out the exact position and place the whole carousel there, no need for your logo's position thing.

Yeah, if you change the ES code, then the theme can be modified. But I'm really not seeing the advantage over the current carousel position. Kinda seems like the same exact thing to me.

f.caruso

@f-caruso said in New Theme Testing:

i didn't publish it yet as I have other unfinished changes pendings

"What system are you talking about" : When I tested your theme, i had i "WiiU" system. Everything went black cuz I didn't have a systemColor for wiiu...

For the rest, as i said : "i didn't publish it yet as I have other unfinished changes pendings"...

lilbud

@f-caruso Added Wii U

A Former User

@lilbud Are your screenshots / logos that you posted in the original images a composite image?If so, how’d you scrape those?

Example: How the Aerofighters Assault and Bust a Move logos are perfectly aligned on the bottom right of the screenshot.

lilbud

@LiveFastCyYoung I used skyscraper to get the screenshots and marquees. I don't have any videos, but I wanted the marquees to show, so I just set it to Video view as a default.

The bust a move was scraped, the aerofighters one was from the es-toolkit

A Former User

@lilbud I’m using Skraper so I’ll probably just need to play around with custom mixes to get the carousel further to the left.

Thanks!

This theme is seriously excellent! 😀

Gwyllion

@lilbud could you please list all the systems you made? Thanks!!!

lilbud

@Gwyllion Sure
3do
amiga
amstradcpc
apple2
arcade
atari2600
atari5200
atari7800
atarijaguar
atarist
auto-allgames
auto-favorites
auto-lastplayed
c64
colecovision
cps1
cps2
cps3
daphne
dragon32
dreamcast
famicom
fds
gamegear
gb
gba
gbc
gc
genesis
intellivision
kodi
machintosh
mame
mastersystem
megadrive
msx
n64
naomi
nds
neogeo
neogeocd
nes
ngp
ngpc
pcengine
printit.txt
ps2
psp
psx
retropie
saturn
sega32x
segacd
sfc
snes
tg16
tgcd
wii
wiiu
wonderswan
wonderswancolor
zxspectrum

joharibk

@lilbud anyway we can download the theme still. It looks good!

lilbud

@joharibk The official theme downloader in retropie-setup