Updated EmulationStation for Windows
-
@f-caruso said in Updated EmulationStation for Windows:
hide when launching game
With your version of ES whenever I quit a game using a controller button press it doesn't show the menu again, it stays on the loading screen until you tap the keyboard or press a button on the controller once the form is active and sometimes if I have another window open when the game ends it will jump to that and I can not reactivate it at all unless I press alt tab on my keyboard - which means I can't do it from the couch with the controller at all. It did it with your previous version I was testing, the only time i can get it to come back is if I set Power Saving to Disabled - which I am thankful only uses 4 to 5% CPU now thank you, but if you can take a look at forcing form activation and redraw once the calling process has ended (or however it detect Emulator closures). I am loving the latest work ;)
-EDIT-
After a few minutes the CPU drops to 0% - 1% usage, so I will just leave Power saving disabled and that will fix the redraw bug for me for now.
-
@LiveFreeDead This happens because :
You set "POWER SAVING" to "INSTANT" + "HIDE WHEN RUNNING GAME" to OFF + "GAME LAUNCH TRANSITION" (I created a different transition for game launch) which it is not set to INSTANT (should be done automatically, but it is not). Simply set GAME LAUNCH TRANSITION to INSTANT. Or stop using Power saving... -
Is there a way to start ES on a second monitor and keep it open while working on the other monitor?
im trying to make ES to always open in my tv, while y work on my pc monitor, is that possible?
-
Hey @f-caruso Im trying to trigger this with Redream. What am I doing wrong?
<padToKey>
<app name="redream">
<input name="hotkeyenable start" key="(%{F4})"/>
</app>
</padToKey> -
@sikboy Hi, nothing wrong, but not a lot of informations : Do your run emulationstationportable.exe ? if yes, maybe redream is runned as admin while emulationstationportable is not. All processes must run in the same account ( everything as admin, or nothing ) or it will not work.
-
Deleted
-
Hi everyone,
It's been a while... but I want to keep you informed that I released a new version today of my EmulationStation 2.10c fcamod.
This release in mainly focused on having a perfect & animated grid view, theming, and videos, and solving bugs. I also focused on backward compatibility for themes.
The changelog is pretty long. For example : you can now design custom views, inherited from integrated views, and choose which view to apply, either globally or by system. Also, theming system is now fully compatible with Recalbox themes.
You can download and see source code here :
https://github.com/fabricecaruso/EmulationStation/releasesYou can also download a complete pack including my theme, which demonstrates all the new possibilities here :
http://fabrice.caruso.free.fr/EmulationStationMod.7zAlso, I made a video to demonstrate the new grid possibilities. I forgot to capture a system with a video background... but it works... Never mind you can test it using "DVD Boxes #2" in my theme. You can see the video here :
I didn't document yet the new Theming possibilities, but, promise, I will soon.
@mitu I archived my code and rebased it. Even if I work under Windows / Visual Studio, my code should compile and work perfectly under Linux & Pi. I saw you validated a MR recently on github, so i'm wondering... Are you interested in merging my work that in the main Retropie repo ? Do you think I should push a MR ? Please contact me if you are interested ( as an admin, you certainly can see my email ).
-
Holy moly that's a lot of progress.
Any chance the alphabetical sorting issue was solved?
-
@LiveFastCyYoung said in Updated EmulationStation for Windows:
Any chance the alphabetical sorting issue was solved?
It is. Isn't it ?
The video continuing playing when running a game too.... -
@f-caruso I'm not at home so I can't test it until later. I'll certainly report back though. Thanks! :)
-
@f-caruso The "Magazin Madness Theme have now pixelated Covers on Main Menue. After set "preload UI" to off, the pixelate is gone. Please check it out.
-
@f-caruso said in Updated EmulationStation for Windows:
Looks like great work !
@mitu I archived my code and rebased it. Even if I work under Windows / Visual Studio, my code should compile and work perfectly under Linux & Pi.
It compiles fine under Linux. Didn't get a chance to do it on a Pi yet.
I saw you validated a MR recently on github, so i'm wondering... Are you interested in merging my work that in the main Retropie repo ? Do you think I should push a MR ? Please contact me if you are interested ( as an admin, you certainly can see my email ).
I'm just a casual contributor to Emulationstation - my PR's have been so far just small bugfixes - I don't have commit rights. @pjft, @jdrassa (which fork you forked) and @Tomaz are the main maintainers of the repository.
As a RetroPie contributor, I think some of your changes could benefit everyone - not just Windows users - and we could gain by adding your changes:
- The Grid View changes
- L10n is an request voiced here - there's a starting PR by @nadenislamarre, the main Batocera developer and several forks which implemented it.
- Windows fixes - a lot of 'orphaned' Emulationstation Win users find their way to this topic, after they realise that emulationstation.org is dormant.
- I'm sure there are more small fixes and optimisations in your fork.
For integrating those changes into the main RetroPie version, I still think a series of MR/PR (focused on a certain functionality) is the way to go - but that's up to repo's maintainers. I can certainly test things - both on Linux/PI.
-
@PittStone I added a mecanism to ensure images are sized in memory to the size of their container. It saves lot of VRAM. Maybe some images are stored in different containers and the sizing is too small. I'll investigate. Maybe l'll also add an option ( deactivated by default ? ) for this mecanim (resize images on/off).
-
@mitu "a series of MR/PR focused on a certain functionality". The problem is that I changed too many things especially in base components like GuiComponent, VideoComponent, ImageComponent. It impacts almost everything... Choosing functionnalities is not going to be an easy thing... I Retropie is interested in just one or two functionnalities, better time going back from zero from their master and re-adapt code...
I honestly don't know how to do it right. I have no experience in opensourcing nor Git... And I have no contact with anyone in the Team. The best think to do is talk ;-) That's why i asked...
-
@PittStone I understood the problem. In the theme, the logo is declared multiple times in detailed, basic and video views... But it is outside the screen (see pos), and it is very small. The preloader / image resizer takes this version as a reference. I'll see if I can parse the theme to find the "biggest" container for a given image in a future release.
Meanwhile, just remove these lines in the theme ( found 3 times - not a problem as the logo is not visible on the screen ) :
<image name="logo"> <origin>0.5 0.5</origin> <pos>1.5 1.125</pos> <maxSize>0.14 0.14</maxSize> </image>
-
@f-caruso said in Updated EmulationStation for Windows:
@mitu "a series of MR/PR focused on a certain functionality". The problem is that I changed too many things especially in base components like GuiComponent, VideoComponent, ImageComponent. It impacts almost everything... Choosing functionnalities is not going to be an easy thing... I Retropie is interested in just one or two functionnalities, better time going back from zero from their master and re-adapt code...
Yes, I see you sprinkled a lot of small additions into the a lot of files. However I see you kept the coding style, so that's a plus for future integration efforts.
I honestly don't know how to do it right. I have no experience in opensourcing nor Git... And I have no contact with anyone in the Team. The best think to do is talk ;-) That's why i asked...
Don't worry, so far - by publishing the source and adding a CI Release - you're doing ok. You might consider opening a separate topic though here in the forum :).
-
@f-caruso Hi,
I have a new bug with the latest version. With the showcase theme (automatic view), the game image is displayed when a game is selected, and after a delay of X seconds, image is replaced by video.
Now, image is not visible anymore. I can add the tags <image name="md_image"> in <view name="video">, but image is not hidden when video starts to play.
-
@dukeblooders Looking for a soluce...
-
@f-caruso said in Updated EmulationStation for Windows:
@mitu "a series of MR/PR focused on a certain functionality". The problem is that I changed too many things especially in base components like GuiComponent, VideoComponent, ImageComponent. It impacts almost everything...
@mitu's suggestion of targeted PRs is the best approach to getting your changes merged. It makes it easier to review and test the changes independently. If you were to submit a PR for everything, it would likely just be rejected.
Choosing functionnalities is not going to be an easy thing... I Retropie is interested in just one or two functionnalities, better time going back from zero from their master and re-adapt code...
Thats essentially what needs to be done. You (or someone else) would need to start with the current RetroPie version, pick a given functionality, and reimplement it there. I know it would be a lot of work, but so is keeping your fork in sync with RetroPie. Overtime that is going to become harder to do. Especially if over functionality is added that conflicts with the changes you have made.
I honestly don't know how to do it right. I have no experience in opensourcing nor Git... And I have no contact with anyone in the Team. The best think to do is talk ;-) That's why i asked...
If you want to create PRs for RetroPie, this is what I would suggest doing.
- Create a new branch in your repository to preserve all of your current work.
- Update your master branch to mirror RetroPie's master
- Create a new branch for the first feature that you would like to push to RetroPie. Once it is ready, submit a PR.
If you need any help with how to actually do any of the above with git/github let me know and I can post more detailed instructions.
As for what features to target, I think the highest priority ones would be the Grid View improvements and the menu theming.
Also, when modifying existing files, you should take care to preserve the existing styling to keep the diff to a minimum. For example if you look at the diff for GuiComponent, to shows that the entire file has changed, when ideally it should just show your additions. This is likely due to formatting changes. It makes it much harder to review what actually changed.
-
@f-caruso said in Updated EmulationStation for Windows:
@LiveFastCyYoung said in Updated EmulationStation for Windows:
Any chance the alphabetical sorting issue was solved?
It is. Isn't it ?
The video continuing playing when running a game too....Edit: Turns out my alphabetical sorting issue was I had a couple ROMS beginning with a space. -_-
Contributions to the project are always appreciated, so if you would like to support us with a donation you can do so here.
Hosting provided by Mythic-Beasts. See the Hosting Information page for more information.