Is There a Favorites Glitch in Kiosk Mode?
-
In this thead, the subject came up of how to remove the Favorites button (so kids and noob adults don't start adding stuff to the menus). It was stated that @mitu had disabled the Favorites button by default whenever you enter into Kiosk mode. Unfortunately, I have tried this several times (with several different settings off/on), but whenever I press the Y button, I still get the "Add X-GAME to Favorites" notice popping up.
Just wondering if this is not working or if I'm missing something? Alternately, I have no problem just finding the config file this is bound to and simply removing or editing the command so the Y button does nothing. Either way, I'd would like to remove this function before I let anyone get a hold of my pie. Running the latest version of Emulationstation (regualr, non-dev version) from the official image.
-
Can confirm, ES updated from source 30 Mar 2021, kiosk mode adds and removes favorites with Y button. Changes persist after returning to full mode and restarting EmulationStation.
-
Actually, it seems I was wrong - at some point the Kiosk mode favorites has been removed, but was brought back - https://retropie.org.uk/forum/topic/22564/.
-
@mitu said in Is There a Favorites Glitch in Kiosk Mode?:
Actually, it seems I was wrong - at some point the Kiosk mode favorites has been removed, but was brought back - https://retropie.org.uk/forum/topic/22564/.
Thanks for following up. It's really no problem in the end, as I was originally on the hunt for the file where the Y button was bound to the favorites command. Then I came across that thread.
So back to my original search, can you or anyone tell me where that file is that houses the favorites input? I'll simply edit it and remove the Y input and that should disable it for me. Where is that located?
-
@alphabetapie I read in another thread, there isn't a config for this, you have to modify the code. Now, I'm not exactly sure quite how one would do that -- something about checking out the program from GitHub and then committing changes or something? This part's still real new to me -- but once you're actually in the code, it was a simple matter of changing one or two lines to change the "press Y to favorite" function from
doesn't work in kids' modetoonly works in full mode.Edit: looks like this is where it was changed to allow favorites in kiosk, so you would reverse this to re-disable it: https://github.com/RetroPie/EmulationStation/commit/c98a5d6220ec79bf0e0f5695d4a28b489cfb4952
You can see where it removes a line that says (essentially) "if mode ... equals full" and changes it to "if mode ... equals !kids" instead (the ! means "not" so it changed from "only in full mode" to "anything but kids mode.") Then something further down the page, a line removed about "force disable filters." You may or may not want to add that back in (I'm not sure what that one is for.)
-
@sleve_mcdichael said in Is There a Favorites Glitch in Kiosk Mode?:
@alphabetapie I read in another thread, there isn't a config for this, you have to modify the code. Now, I'm not exactly sure quite how one would do that -- something about checking out the program from GitHub and then committing changes or something? This part's still real new to me -- but once you're actually in the code, it was a simple matter of changing one or two lines to change the "press Y to favorite" function from
doesn't work in kids' modetoonly works in full mode.Edit: looks like this is where it was changed to allow favorites in kiosk, so you would reverse this to re-disable it: https://github.com/RetroPie/EmulationStation/commit/c98a5d6220ec79bf0e0f5695d4a28b489cfb4952
You can see where it removes a line that says (essentially) "if mode ... equals full" and changes it to "if mode ... equals !kids" instead (the ! means "not" so it changed from "only in full mode" to "anything but kids mode.") Then something further down the page, a line removed about "force disable filters." You may or may not want to add that back in (I'm not sure what that one is for.)
Thanks for digging into that! Editing a config file is no problem, but digging around in code is probably a bridge too far for me. I'm sure I could do it if I put my mind to it, but I assume I'd have to recompile and build the new version after I make changes on the code level. And I'm just not looking to do that much. Will just stick to Kids mode for now, but would love if someone could mention to them that kiosk mode with favorites disable is a great idea and should be reimplemented in the future.
-
One more thing...
For anyone wondering, I just tested the favorites in kiosk mode with "Never Save Metadata" turned on. It does wipe your favorite settings/filters after a restart, so if someone did add things by accident, it won't persist after a poweroff/restart. Plus you can turn filters off, which takes away yet another menu. So that does make kiosk a little more usable (and gives your the option to search by letter, which I like).
-
@alphabetapie said in Is There a Favorites Glitch in Kiosk Mode?:
One more thing...
For anyone wondering, I just tested the favorites in kiosk mode with "Never Save Metadata" turned on. It does wipe your favorite settings/filters after a restart, so if someone did add things by accident, it won't persist after a poweroff/restart. Plus you can turn filters off, which takes away yet another menu. So that does make kiosk a little more usable (and gives your the option to search by letter, which I like).
AND yet another thing...
If I'm not able to remove the binding because it's buried in the code, where is the Y button help icon stored that the menu places at the bottom of the screen? I could just Photoshop or remove that. Unless this is also buried in the code and not normally accessible?
-
@alphabetapie said in Is There a Favorites Glitch in Kiosk Mode?:
but would love if someone could mention to them that kiosk mode with favorites disable is a great idea and should be reimplemented in the future.
Agree. Perhaps a flag that could be set while in Full mode, which would toggle Favorites functionality in Kiosk? So it could still be available for those who want it, but could be disabled if you want to leave it with the knuckleheads for an afternoon.
-
@sleve_mcdichael said in Is There a Favorites Glitch in Kiosk Mode?:
@alphabetapie said in Is There a Favorites Glitch in Kiosk Mode?:
but would love if someone could mention to them that kiosk mode with favorites disable is a great idea and should be reimplemented in the future.
Agree. Perhaps a flag that could be set while in Full mode, which would toggle Favorites functionality in Kiosk? So it could still be available for those who want it, but could be disabled if you want to leave it with the knuckleheads for an afternoon.
I'll be glad to suggest it or put a request in, if you can provide a link to where I can do so.
Also, anyone have any ideas on if the Y button icon in the help menu at the bottom of the screen is editable (and if so, where)?
Contributions to the project are always appreciated, so if you would like to support us with a donation you can do so here.
Hosting provided by Mythic-Beasts. See the Hosting Information page for more information.