New Comic Book Theme!

Zenjiro

AlphaBetaPie

@AlphaBetaPie Correct.

Cool, thanks for the heads up.

smartgenes

@sergio_mikkos hahahahaha well... I fixed it

It was stupid simple to do.

I will update it to my fork, but it you want to do it manually, all you need to so is open the comic_book.xml in the text editor of your choice. (I use Notepad++) And edit the following:

From this:
<rating name="md_rating">
         <pos>0.87 0.66</pos>
         <size>0 0.038</size>
         <filledPath>./_assets/star_filled.png</filledPath>
	 <unfilledPath>./_assets/star_empty.png</unfilledPath>
        </rating>
To This:
<rating name="md_rating">
         <pos>0.87 0.66</pos>
         <size>0 0.038</size>
	 <unfilledPath>./_assets/star_empty.png</unfilledPath>
         <filledPath>./_assets/star_filled.png</filledPath>
        </rating>
What is happening is that when it is applying the images on the screen it first applies the star_filled.png then the star_empty.png, which causes the overlap. So the edit just changes the order of apply the empty star image first, then the filled one.

Where is the file where you edit this? I think a similar issue was solved with an overlapping "D" in "TIMES PLAYED"?

What I'd also really like to do is increase the amount of text available in the text box (the <desc> information) in emulation station and also decrease the scroll speed if possible.

Zenjiro

@smartgenes Yeah it was a simple change. My fork also already has that applied.

smartgenes

@Zenjiro Thanks, sorry for the noobish question but where is the file located, it'll save me pottering about all over the place for an hour...

And do you mean already with the text box scrolling applied?

Zenjiro

@smartgenes It is here. I have not updated much because of IRL stuff. And I am focusing on actually playing on my setup now rather than tweaking it constantly.

smartgenes

@Zenjiro I meant the theme file(s) for editing but sure I guess I will add your fork too.

Zenjiro

@smartgenes Templates can be found here

smartgenes

@Zenjiro No, I mean where are the files located on the Pi which I could edit in a terminal with nano. Thanks loads!

smartgenes

@smartgenes Maybe it's obvious to others, but it's: cd /etc/emulationstation/themes/ComicBook where you can sudo nano comic_book.xml
If it's obvious a 10 second answer is still helpful, if not help would be good but anyway, now I can cause damage to the file at my leisure...

smartgenes

@smartgenes I found out the file for scroll speed is here and would have to be edited in the source code strangely enough:

https://github.com/RetroPie/EmulationStation/blob/master/escore/src/components/ScrollableContainer.cpp

(It defines a constant called AUTOSCROLL_SPEED.)
So, my workaround is just adding the title of game, Some Game (1988) and a blank line in the description ( <desc> in the gamelist.XML) which at least gives more reading time.

But the text limit is odd, surely an almost infinite space should be available for text in the scroll box?

For TMNTturtleguy's ComicBook theme, switching the order of <filledPath> and <unfilledPath> didn't work on its own (the file is also in ./art/ rather than /asset/ ). But changing the <pos> value from 0.87 to 0.82 worked.

Also changing the <pos> value from 0.88 to 0.86 under lbl_playcount fixed the issue of the overlapping text in "last played".

Lolonois

I implemented a patch a while ago to let the user control the description scroll, because the reading speed depends on many factors (Theme/Font, Displaysize, Lightning, Vocabulary of description text, reading abilities of user, ...)

What the patch enables in a nutshell:
Hotkey held/released: Description scrolling stops/continues
Hotkey held + Up/Down: Scroll description Up respective Down

https://retropie.org.uk/forum/topic/31981/control-scrolling-of-game-description-in-emulationstation

You can upvote there to make it more likely to get it into the mainline of ES.

Clyde

@smartgenes said in New Comic Book Theme!:

So, my workaround is just adding the title of game, Some Game (1988) and a blank line in the description ( <desc> in the gamelist.XML) which at least gives more reading time.

I once made a one-liner for RetroPie's command shell that adds x number of lines at the beginning or end of each game's description of a given system.

smartgenes

@Clyde Yes, I read your post with the added lines script. I wondered if the scroll box would include those lines as part of its line count? If so, it's not so useful yet to me, as I'm already short of lines for description.

smartgenes

@Lolonois That's a great idea, for sure I would upvote a way to move up and down the text box. Only some clowns downvoted my posts so I need three up votes to be able to vote again.

Any idea what is controlling the box's line limit? I can't see why it would need any limit at all.

Clyde

@smartgenes Alas, I don't know if the limit applies to the lines or characters of the description, i.e. if /n counts as only one or two characters or a line.

But you can test that easily by just adding 10 /n or so and see where the text stops being displayed compared to no empty lines.

smartgenes

@Clyde @Lolonois I've just noticed that if you switch to another console and back, then the scrolling text box doesn't reset - it continues from where it last was. So you can read the rest of the text. So emulationstation is "seeing" all the text but arbitrarily stops it after some count. So it should be changeable somehow.

Lolonois

@smartgenes said in New Comic Book Theme!:

Any idea what is controlling the box's line limit? I can't see why it would need any limit at all.

Hmm. No. But you can try Ctrl-t when EmulationStation is started with the --debug flag. Maybe it shows a hint why the bounding text box does not show all of the text.

I don't assume it is related to this issue FYI.

Logandros

My contribution, needed this one.

kcoconnor76

Anybody got a "PC-FX" logo?