Adding additional events into ES
-
@folly Ok! Will do.
-
"Like the sauce... it's in there!"
https://edgewatertech.wordpress.com/2008/08/25/web-20-like-prego-spaghetti-sauce-its-in-there/
RussellB (EnsignRutherford)
-
Yes I read your link.
Bottom line everything can be confusing some times.
Did I summarize correct ? ;-)If we can, we will help.
-
@folly, @svera - The pull request is now pending so let's see what happens.
While doing more testing I found a 'bug', at least what I think is a bug:
In ViewController.cpp if there is a startup system specified the event fires for that system. When the bash script gets the event it sets the marquee to the system, e.g. Atari Classics.
The problem here is the user interface shows the "Atari Classics" marquee, NOT "720 Degrees" which is the first game selected.
I'm missing the "game-select" event for when a startup system is specified. For my purposes, it's a bug and I need to figure out how to get the "current game" in ViewController.cpp or where the first game is set during startup.
It's not REALLY a bug as everything works as was designed. I just want to find the spot to fire that event so the bash scripts can capture it too. The bash script can decide to either show the game marquee or the system marquee. I'd rather it there than in the C++ code.
-
@folly, @svera Ok I figured it out. Need to add another parameter to game-select and specify "requestedgame". This gives the bash scripts an option to either display the requested game logo or the system logo when a startup system is specified.
I'm going to have to redo my pull request.
@svera, Can I just cancel it and redo it?
-
Done!
-
I am following what you are doing in the pull.
Curious how it goes. -
@russellb you don't need to close and reopen the pull request every time you do changes in the code, just commit and push those changes and the pull request will be updated automatically.
-
M mitu referenced this topic on
-
@svera @RussellB do you know if this one ever made it, specifically the new game-select and system-select event scripts. I did just try the latest 4.8 RetroPie on a Pi 4 but no luck. game-start works fine as it did before , just not these two new ones. They would be super helpful to have for the integration of Pixelcade arcade marquees with RetroPie .
The two events are listed also in the docs https://retropie.org.uk/docs/EmulationStation/#scripting
Thanks!
Al
-
-
@mitu thanks for the quick reply, I just downloaded the latest 4.8 vanilla info from retropie.org.uk for a Pi 4 but I did not do the update, will give that a shot and report back
-
@mitu that did the trick! thanks again!
What i'll do is add a check to the Pixelcade installer script to do that.
I can dig around the RetroPie update script but do you know if there is a way to check the ES version from bash. If so, then I can just check if the user has what is needed and if not, kick off the updater.
-
@mitu I can grep the output of ./emulationstation -h to get the version so that'll work for Pixelcade script
Version 2.11.0rp, built Dec 10 2022 - 12:26:20
would you happen to know what minimum version of ES has the new scripts (game-select and system-select)
-
as an fyi, the vanilla 4.8 download has ES 2.10.1rp and then after updating from the RetroPie updater, it's 2.11.0rp so I'll use a minimum required of 2.11 for now unless you know different, thanks again
-
updated the Pixelcade installer script so should be good now, thanks again !
Contributions to the project are always appreciated, so if you would like to support us with a donation you can do so here.
Hosting provided by Mythic-Beasts. See the Hosting Information page for more information.