lr-mame binary not updating?

roslof

It's possible that the lr-mame binary is not compiling correctly, since the most recent binary for lr-mame is several builds behind the github repro. Some recent changes to 0.257 and compiler changes may be the culprit. Was hoping to run another multi-week test of FBNeo vs. lr-mame with latest changes from each and update my compatibility list which is about a year old.

BuZz

@roslof it wasn't recently due to build errors. I have also paused building binaries currently and will resume soon.

barbudreadmon

@BuZz i'd recommend being careful when updating that binary, i think the rebasing of that core is still sort of a work-in-progress.

roslof

@barbudreadmon said in lr-mame binary not updating?:

@BuZz i'd recommend being careful when updating that binary, i think the rebasing of that core is still sort of a work-in-progress.

Absolutely. Always careful and thorough and providing insights as I find them.

nemo93

Hello, testing has pointed out a specific flag must be added for more drivers to run properly (see here, here or here).

Flag to be added: -fsigned-char (I can't test this by myself given the super long time to compile on RPi). Let me know if I should raise a ticket or keep everything into that thread.

Thanks and credits to @sonninnos as well as @grant2258 for their great help, assistance and rebasing/improving that libretro core.

@barbudreadmon I'd like to use that opportunity to thank you as well for everything you do on FBNeo. That core always impresses by how blazing fast it is even on such low-spec device as the Pi! For everything Neo Geo, Cave or CPS3 (and for many other 'drivers') it is the best choice for Pi users. Thanks again (and to the team).

mitu

@nemo93 said in lr-mame binary not updating?:

Hello, testing has pointed out a specific flag must be added for more drivers to run properly (see here, here or here).

Thanks for the heads-up. Does the issue happen with MAME standalone also ? We might need to add it there also.
I wonder if it breaks something else, though.

nemo93

@mitu yes you are correct. Standalone impacted too. Standalone has been tested on 64bit OS only. On my end I test only with the stock Retropie image and the lr-mame core.

Should adding that flag break another driver I'm pretty sure I'll figure it out :-) I'll do another round of testing once this has been sorted out.

roslof

@nemo93 said in lr-mame binary not updating?:

@mitu yes you are correct. Standalone impacted too. Standalone has been tested on 64bit OS only. On my end I test only with the stock Retropie image and the lr-mame core.

Should adding that flag break another driver I'm pretty sure I'll see it :-) I'll do another round of testing once this has been sorted out.

I built lr-mame from source with the recommended flag and can confirm that the listed issues are resolved with the change. It also resolves the long-standing issue of "can't insert coin" issue with Speed Racer.

This is unofficial, but I just modified the lr-mame.sh script, adding the flag to the make line. Can disregard the -j2, as I added that to help build this faster on my pi4b.

make CFLAGS="-fsigned-char" -j2 "${params[@]}"

@nemo93 I uploaded my binary to my Google Drive here if you'd like to run some checks.

nemo93

@roslof thanks a lot for sharing, definitely helpful. I was able to test and I do confirm your feedback. All problems referenced are now gone. Kind of a magic flag :-) I'm now in the process of closing every open ticket.

Note: I've tested also a bunch of other games from other popular drivers (CPS1 and CPS2, Konami, etc) and so far so good. I'll update that thread should I fine anything following that binary update.

nemo93

All, to end that topic, the "magic" flag mentioned above has been added to lr-mame directly. I consider the case closed for that core at least.

Thanks again for reporting, feedback and @roslof for the binary (which works really great on RPi4).

nemo93

Well... I've spoken too fast ;-) I just found an issue with one specific driver (details). Every other drivers tested are working just fine up to that point. This applies to lr-mame for sure. I can't test with standalone hence not sure it's impacted as well.

EDIT: alright issue has been found and fixed (missing driver).

@roslof: can you please try and compile the latest commit? I don't want to ask but if you could also share it on Gdrive as you did last time that would be of great help too :-) Thanks in advance.

roslof

@nemo93 said in lr-mame binary not updating?:

@roslof: can you please try and compile the latest commit? I don't want to ask but if you could also share it on Gdrive as you did last time that would be of great help too :-) Thanks in advance.

I'll get it started. Will take 1/2 a day or more, then I'll upload it.

roslof

@nemo93 you're all set.
Link to binary

I checked out tmnt2 and it works with this version.

nemo93

@roslof thank you so much for providing the binary (once again) and for reporting back re tmnt2! Much much appreciated. I'll keep on testing and reopen the thread should I find anything else.