Acorn BBC Micro Emulator (current?)

Folly

@Retrodade said in Acorn BBC Micro Emulator (current?):

@Folly
OK, Thanks for the reply, was one of my favorites as it booted directly to game and exit was easy over any other.
most pi users like direct game loads I guess or I'm odd.

I had a look again at the original source and it seems like kilograham has updated the source.
Also found that I use the flag rpi4 so for the rpi5 it will use the wrong compile line.
Can't promise but I will have a look if I can get it working again.

Retrodade

@Folly oooo ,wasn't expecting that but wow sweet if you do get it, I'd love to know.
and i do understand no promises all good either way

Folly

@Retrodade

Nice find ;-)
Just tested experimented on my pi5 with 64 bit OS and it did compile correctly.
Will have a look later If I can fix it all together.

Retrodade

@Folly sweet!

Folly

@Retrodade

Updated, you can test it :
https://github.com/FollyMaddy/RetroPie-Share/commit/c6476de8bb73955e60c0e4f512b9ef3bb65b955c

Let me know if it works.

Retrodade

@Folly will do wow, Thanks!

Retrodade

@Folly just got it installed and tested thank you for fixing it for the pi5 works a charm

Retrodade

@Folly also a side note, if one has Qjoy installed to retro pie desktop you can add qjoy to the emu

in
xbeem after the line "matchbox_key_shortcuts" add & qjoypad "bbcmicro" &
and in
xmaster after the line "matchbox_key_shortcuts" add & qjoypad "bbcmicroalt" &

both emus work, seems BBC micro has mainly 2 keyboard mappings, so this gives u most game ability using a controller or joystick over just a keyboard

note in Qjoy make a controller mapping called bbcmicro and another called bbcmicroalt and map your controller to the games keyboard requirements, that way you won't need a keyboard for the games.

just tossing it out there

phoenixdacat

@Folly upon doing what you suggested, trying to run the script from the CLI, the issue was apparent.

I'd used Git to clone your repo to my Win11 PC and then copied the files over to my Pi.

The line termination character is different between Win/Linux, so the script wasn't valid, even though to the eye it looked so.

Thanks for the info on how to do this from the CLI.

Folly

@phoenixdacat said in Acorn BBC Micro Emulator (current?):

@Folly upon doing what you suggested, trying to run the script from the CLI, the issue was apparent.

I'd used Git to clone your repo to my Win11 PC and then copied the files over to my Pi.

The line termination character is different between Win/Linux, so the script wasn't valid, even though to the eye it looked so.

Thanks for the info on how to do this from the CLI.

Aha,
I have heard of these differences in line-endings before but never knew it would make a script unusable.
Thanks, good to know.

Folly

@Retrodade said in Acorn BBC Micro Emulator (current?):

@Folly also a side note, if one has Qjoy installed to retro pie desktop you can add qjoy to the emu

in
xbeem after the line "matchbox_key_shortcuts" add & qjoypad "bbcmicro" &
and in
xmaster after the line "matchbox_key_shortcuts" add & qjoypad "bbcmicroalt" &

both emus work, seems BBC micro has mainly 2 keyboard mappings, so this gives u most game ability using a controller or joystick over just a keyboard

note in Qjoy make a controller mapping called bbcmicro and another called bbcmicroalt and map your controller to the games keyboard requirements, that way you won't need a keyboard for the games.

just tossing it out there

Ok, will have a look.

phoenixdacat

@Folly

It's not the first time I've come across this.

If you add a .gitattributes file to the root of your repo, with this as the content

* text=auto
*.sh text eol=lf

it should fix that issue for those who clone to Win systems.

Folly

@phoenixdacat

I had a look to change it but I only use the web-browser to add stuff not the git command as I am much too inexperienced with that.

Seems I cannot change in the browser or can I ?

mitu

@phoenixdacat said in Acorn BBC Micro Emulator (current?):

It's not the first time I've come across this.

Probably because your git is configured to translate LF to CRLF automatically via core.autocrlf ? Windows nowadays is better equiped to handle Unix line endings, you should turn off this option if you'd like to get rid of this problem.

phoenixdacat

@Folly I can do a pull request to your repo with the file added it you like?

phoenixdacat

@mitu that would fix it for me, but others could face the same issue.

I'll add the .gitattributes file to my local clone, and do a pull request.

mitu

@phoenixdacat said in Acorn BBC Micro Emulator (current?):

@mitu that would fix it for me, but others could face the same issue.

Sure, if they use Windows, but most of the users that clone @Folly's repo are already using Linux.

phoenixdacat

@mitu Which is why I'd class it as a subtle issue.

I'm a Win developer by profession, and I like to clone repos to my main PC, so that I can learn from code. I did that with Folly's repo, and then copied it to my Pi. Once I found out how that script could be run via the CLI, it was obvious from the errors what the issue was, so I just hopped onto the Pi and cloned it there.

I can't imagine I'm the only one who would clone to Windows then copy over.

Folly

@phoenixdacat

Ok, I merged it.
Should be good for windows user now then.
Thanks !

Edit :
I see that the .gitattributes file is showing up in the browser.
So it can be edited via the browser if needed.

Folly

@phoenixdacat said in Acorn BBC Micro Emulator (current?):

I'm a Win developer by profession, and I like to clone repos to my main PC, so that I can learn from code.

Just something to add if you want to review the code you can simply check it by function.
At least next works for these kinds of module-scripts.

Remember this :

pi@raspberrypi:~/RetroPie-Setup $ sudo ./retropie_packages.sh|grep b-em-allegro4
b-em-allegro4       : Acorn BBC emulator                         : build configure depends install sources clean remove

If you want to do the depends only you do :

sudo ./retropie_packages.sh|grep b-em-allegro4 depends

etc.
Just use it in the proper order (seen in the module-script) and you can see what every function is doing step by step.

clean is to remove the source-code in Retropie-Setup/tmp/build/
remove is to remove the emulator that is installed.