Video Preview in EmulationStation
-
@Nismo I find the software part easy whereas I cannot make a good looking theme to save my life! Different people; different skills.
Regarding the issues and enhancements - are you able to log these as issues in github on my fork? I'm not sure if I need to give permission or not.
Do you think you should announce your theme in the "Projects and Themes" section?
Regarding the issues. They are more of a wishlist for my personal preference:
- I haven't tried it yet but I think you've already addressed this - on my RPi screen I cannot see the highlight on the selected game in the game list
- For my MAME games I have quite a detailed description for each game. It would be nice to include this on the view but I can see that most people wouldn't want it - and there's not much room :)
- The simulated scan lines don't work when they are scaled onto my 800x600 RPi screen.
That's it.
-
@fieldofcows I'll try to add the issues on github.
Of course i'll post the theme in the right section when finished.
About 1 point. I already did some changes for better visibility in the last release, but i'll try some changes to see if I can do it better without losing the theme essence.
About point 2. Yes I like the description too, but I don't know where to place it, I'll experiment and try to add it in some free space, but not too much space.
About point 3. I have no idea why the scanlines doesn't work when scaled, it's only a transparency png, try renamig scanlines.png to another name inside oldroom>"nameofthesystem">art folder and see if you notice some difference, maybe you don't notice scanlines because of low resolution.
Regards.
-
@fieldofcows I was thinking a lot and I think the best way to implement description in theme is to place it in the same space than gamelist, so I did this:
https://postimg.org/image/qho4yfer5/
But I discovered an issue introduced on beta 4, description autoscroll is not working on video view, it works in detailed view. I have tested old releases and it's working, till beta 3.
I'll try to add this issue and relative path issue on github later.
Please tell me what do you think about placing description under gamelist. And.. we need description scroll working to read full text...
What do you think about add a "Add as favourite" and "remove from favourites" (if already added) option for games when press select on a game? Favourites can be another system in theme, like nes, snes, favourites, etc. But the difficult thing it's to implement diferent systems in same gamelist.xml inside favourites folder...
It's only an idea for future releases. Please don't forget to tell me what you think about description under gamelist.
-
@Nismo Yes that looks good. I think I've fixed the issue with autoscroll - it was the same problem that was causing the game list to not automatically scroll when holding the down button. I'll test it later just to make sure. I'll build you a Windows version a bit later with this and the other fixes I've already done.
I've just about finished implementing a video screensaver - something else I wanted in ES. You can now select between "Black", "Dim" and "Random Video". When the screensaver is activated it will scan the gamelists for a random game with video and start playing it. I've got some more testing to do but it's working and nearly there.
-
@fieldofcows Very nice commit. I was thinking about the easiest way to implement favourites, and could be something like this:
-
Press select on a game and in "options" menu, you can insert another option "add to favourites" or "remove from favourites if already added (for no confusion).
-
For adding a game to favourites, emulationstation add the tag <favourite>1</favourite> in gamelist for that game, and <favourite>0</favourite> if you remove from favourites.
-
In the same "options" menu for a game (pressing select) , you can see "sort games by", that's the place where you can implement favourites, sort games by favourites, that way it's super easy and don't need a theme for favourites, it can work inside the system itself so no headaches for multiple systems in a game list.
What do you think?
-
-
@fieldofcows Here you have a new update so you can test if description autoscroll it's working on video view in beta 5:
New update oldroom theme v 1.3:
-
Added description for games.
-
Added rating and last time played.
-
Added N64 system.
-
Some fixes on Sega 32x theme.
-
Fixed Atari 2600 logo on in video view.
-
Fixed Neo Geo logo in video view.
Download: http://www.mediafire.com/file/uzj8rrhmkz85zbz/oldroom+1.3.zip
Video preview: when next release.
-
-
@Nismo Update looks fantastic as usual. I've tested it with my latest local build. Key auto repeat and text autoscroll work as expected.
Here is the new build:
https://github.com/fieldofcows/EmulationStation/releases/tag/v0.1-beta.5
-
Child-Friendly Emulationstation has Favourites already, couldn't it just be ported over to this build?
-
@fieldofcows Thank you very much! Great update.
-
@robertybob I had a feeling that I read about favourites somewhere before hence I held off commenting on @Nismo 's suggestion until I had investigated. I'll take a look and see how easy it will be to port.
-
@fieldofcows There's something wrong in the last build, when I start emulationstation, I can hear the video from the first game of each system simultaneously.
If I enter a game, and then exit, I can hear both the video of my game and the first video on the right side system.
Very, very strange..XD anyway thanks for the update, scroll is working now.
-
@Nismo If it's not one thing then it's another! ES seems to keep every view for every system active at the same time so managing which one should be playing video is a bit of a challenge. I'm not sure what happened there but I'll take a look.
It didn't seem to be doing that on my machine but I only have a single system configured.
-
@fieldofcows Of course if you only have one system you can't check that.
It was working very good on beta 3 and beta 4 no sounds problem and video working good. Wait a minute i'll upload a video for you.
-
@fieldofcows Ok here is the video:
-
@Nismo I've actually managed to find a spare hour today so rather than just throwing the code together and leaving you to test it (sorry!) I've given this one a reasonable amount of testing before publishing it:
https://github.com/fieldofcows/EmulationStation/releases/tag/v0.1-beta.6
- Rework logic behind starting and stopping videos to address strange behaviour with multiple videos playing, videos starting at the wrong time, etc.
- Issue #5: Add option to select random game videos as screensaver
- Fix relative paths in video and marquee metadata (yay!)
Fingers crossed!
-
@fieldofcows omg!!! don't tell me you finally fixed relative paths!!! really? Nice! now finally i can scrape games and emulationstation can save my times playes and last played day, etc.
Thank you very much!!! I'm sick on bed today, but i'll test and tell you how it goes.
Thanks again.
-
@fieldofcows I have tested a bit, and seems all it's working very well.
-
The sound problem with videos it's gone.
-
About relative paths, my path are something like this:
<video>~/.emulationstation/roms/megadrive/Videos/3 Ninjas Kick Back.mp4</video>
<marquee>~/.emulationstation/roms/megadrive/Marquees/3 Ninjas Kick Back.png</marquee>After playing, when saving the paths changes like this:
<video>./Videos/3 Ninjas Kick Back.mp4</video>
<marquee>./Marquees/3 Ninjas Kick Back.png</marquee>But no problem, videos and marquees still working, maybe because they are inside rom folder, so still working in portable mode.
- Only thing I notice is that when exit emulationstation the video sounds for a few seconds ( 3 or 4), but I know that isn't an issue, it's because emulationstation is saving now, not like before that saving was disabled.
Very, very nice commit, this is absolutely stable version, no bugs, congratulations.
Edit: I don't know how to put the code inside the black box...
-
-
@fieldofcows I have a little request for you, I think this one is very easy for you.
Can you decrease time for autoscroll on description and gamelist? It takes tooo long...
Thanks again.
-
@Nismo I found where relative paths were handled for images and just made it work the same for marquees and videos. It doesn't store the original relative path but instead calculates it again from the system directory so it can and up different but should work. If it becomes a problem then I know how to fix it properly.
Yes, I know the sound plays while the metadata is saved. I did notice that but didn't think it was worthwhile fixing it. Maybe I will if it annoys people too much.
You get the black box by using three backquotes round your code like this:
'''
Code
'''(except use backquotes, not forward quotes like I did there)
-
@Nismo said in Video Preview in EmulationStation:
@fieldofcows I have a little request for you, I think this one is very easy for you.
Can you decrease time for autoscroll on description and gamelist? It takes tooo long...
Thanks again.
Ha ha! I've done exactly that on my local build!
Contributions to the project are always appreciated, so if you would like to support us with a donation you can do so here.
Hosting provided by Mythic-Beasts. See the Hosting Information page for more information.