runcommand launching images for ANY theme

Rookervik

@meleu Ahhh, that's why you want me to make my theme XML compliant, even tho it's already ES complaint. I was wondering why you wanted me to make changes even tho there's no issues with ES. :P Considering I'd rather people not use my graphics since I've spent hundreds of hours on them, I may leave that change out. If I had just used someone elses' assets I'd fix it right up.

meleu

@Rookervik No problem bro. I was just making tests with my script with several themes and noticed that with the pixel xml files. Your launching images for pixel theme are far better than the generated ones. ;-)

Thanks for all your artwork!

tronkyfran

Please, use the proper aspect ratio for the tronkyfran theme images , they look weird stretched ;)

meleu

@tronkyfran OK. I will fix it. Thanks.

meleu

@tronkyfran The resulting image has the 4:3 proportion. Are you OK with cropped images?

daeks

Very lovely progess on your script :) - Think that should be moved into a retropie package as well

meleu

@daeks said in runcommand launching images for ANY theme:

Think that should be moved into a retropie package as well

The code is a little messy and ugly for now. I'll try to make scriptmodule when I think the code is polished enough. :-)

Thanks again for your ImageMagick tricks.

lilbud

@meleu could you make the text white? Where it says, "press a button to configure"

daeks

@lilbud just change the color to "white" in https://github.com/meleu/share/blob/master/generate-launching-images.sh#L43

meleu

@lilbud said in runcommand launching images for ANY theme:

@meleu could you make the text white? Where it says, "press a button to configure"

I'm planning to add a feature to let the user choose the colors, but if you are comfortable to editing files in Linux it's pretty simple to do what you want now. Just change the press_a_button_text_color from gray50 to white. It's on the line 43.

meleu

@tronkyfran no stretching anymore (and keeping the aspect ratio) ;-)

meleu

This infographic here made me change the final image from .png to .jpg (the file size is smaller and then loads faster, the image loses some quality, but it's a fair price for something that will displayed just for a few seconds...).

EDIT: returning to .png! The .jpg generated images for the material theme don't look fine...

gif-jpg-png

backstander

@meleu
You should make an option for JPEG or PNG but default to JPEG.

I don't know the trick to use genesis rather than megadrive...

The script would need to look in es_systems.cfg

  <system>
    <name>pcengine</name>
    <fullname>TurboGrafx 16 (PC Engine)</fullname>
    <path>/home/pi/RetroPie/roms/pcengine</path>
    <extension>.pce .cue .zip .PCE .CUE .ZIP</extension>
    <command>/opt/retropie/supplementary/runcommand/runcommand.sh 0 _SYS_ pcengine %ROM%</command>
    <platform>pcengine</platform>
    <theme>tg16</theme>                 <--- look for this line!
    <directlaunch/>
  </system>

If <theme> is set to "tg16" then use that system's theme, if it's "pcengine" then use that system's theme.
Same with Megadrive vs Genesis

You should just have your script look for <theme> in es_systems.cfg for each system and if that directory exist in /etc/emulationstation/themes/<theme name> then use that for that system's runcommand launch picture.

This would help with user with custom themes or like when @lilbud make his Mario games only "system".

meleu

@backstander said in runcommand launching images for ANY theme:

@meleu
You should make an option for JPEG or PNG but default to JPEG.

I've put it in my TO-DO list already. ;-)

The tronkyfran generated images have their file size very reduced when they're JPEG, with no significant loss of quality. But the material theme ones look very ugly when JPEG. I'll leave the .PNG for now and add that option later.

You should just have your script look for <theme> in es_systems.cfg for each system and if that directory exist in /etc/emulationstation/themes/<theme name> then use that for that system's runcommand launch picture.

The script already do this way. It gets all the installed systems' names from es_systems.cfg -> <systemList> <system> <name> (in this part of the code) and then gets the system's theme from <systemList> <system> <theme> (in this part of code).

backstander

@meleu

The script already do this way.

So I should be able to use Genesis instead of Megadrive if my <theme> is set to "genesis" and the same with TG16 vs PC Engine?

I ran your script the other day (Jan 10th) on a ES theme and all my "Genesis" games load with a "Megadrive" runcommand picture. Also my "TG16" games loaded a "PC Engine" runcommand picture.

And why did they have to call the US version of game systems a different name then the rest of the world? ;-)

meleu

@backstander Here is the megadrive part of my /etc/emulationstation/es_systems.cfg:

  <system>
    <name>megadrive</name>
    <fullname>Sega Mega Drive</fullname>
    <path>/home/meleu/RetroPie/roms/megadrive</path>
    <extension>.smd .bin .gen .md .sg .zip .SMD .BIN .GEN .MD .SG .ZIP</extension>
    <command>/opt/retropie/supplementary/runcommand/runcommand.sh 0 _SYS_ megadrive %ROM%</command>
    <platform>megadrive</platform>
    <theme>megadrive</theme>
  </system>

Here is the resulting image for carbon theme:

And then I changed the <theme> to genesis:

...
    <platform>megadrive</platform>
    <theme>genesis</theme>
...

And here is the resulting image:

I'm not sure what's wrong on your side... is your es_systems.cfg in /etc/emulationstation or in ~/.emulationstation?

backstander

@meleu
oh yeah...my es_systems.cfg it's in /opt/retropie/configs/all/emulationstation/
I was told it should be placed there so it doesn't get over-written by updates to RetroPie.

meleu

@backstander
good point. I'll sort it in the script, hold on...

BTW: ~/.emulationstation is a symbolic link to /opt/retropie/configs/all/emulationstation/.

meleu

@backstander done! Can you update and test it again?

Concat

Good work!

I have to update runcommand, yes? I am on 3.8, though I have updated Retropie Setup. Am I going to break something?
What's this about moving es_systems.cfg ? I swear mine isn't in /opt/retropie/configs/all/emulationstation/ . . .