runcommand launching images for ANY theme

meleu · 1 Dec 2017, 16:58

@backstander said in runcommand launching images for ANY theme:

@meleu
You should make an option for JPEG or PNG but default to JPEG.

I've put it in my TO-DO list already. ;-)

The tronkyfran generated images have their file size very reduced when they're JPEG, with no significant loss of quality. But the material theme ones look very ugly when JPEG. I'll leave the .PNG for now and add that option later.

You should just have your script look for <theme> in es_systems.cfg for each system and if that directory exist in /etc/emulationstation/themes/<theme name> then use that for that system's runcommand launch picture.

The script already do this way. It gets all the installed systems' names from es_systems.cfg -> <systemList> <system> <name> (in this part of the code) and then gets the system's theme from <systemList> <system> <theme> (in this part of code).

backstander · 1 Dec 2017, 19:55

@meleu

The script already do this way.

So I should be able to use Genesis instead of Megadrive if my <theme> is set to "genesis" and the same with TG16 vs PC Engine?

I ran your script the other day (Jan 10th) on a ES theme and all my "Genesis" games load with a "Megadrive" runcommand picture. Also my "TG16" games loaded a "PC Engine" runcommand picture.

And why did they have to call the US version of game systems a different name then the rest of the world? ;-)

meleu · 1 Dec 2017, 21:13

@backstander Here is the megadrive part of my /etc/emulationstation/es_systems.cfg:

  <system>
    <name>megadrive</name>
    <fullname>Sega Mega Drive</fullname>
    <path>/home/meleu/RetroPie/roms/megadrive</path>
    <extension>.smd .bin .gen .md .sg .zip .SMD .BIN .GEN .MD .SG .ZIP</extension>
    <command>/opt/retropie/supplementary/runcommand/runcommand.sh 0 _SYS_ megadrive %ROM%</command>
    <platform>megadrive</platform>
    <theme>megadrive</theme>
  </system>

Here is the resulting image for carbon theme:

And then I changed the <theme> to genesis:

...
    <platform>megadrive</platform>
    <theme>genesis</theme>
...

And here is the resulting image:

I'm not sure what's wrong on your side... is your es_systems.cfg in /etc/emulationstation or in ~/.emulationstation?

backstander · 12 Jan 2017, 21:17

@meleu
oh yeah...my es_systems.cfg it's in /opt/retropie/configs/all/emulationstation/
I was told it should be placed there so it doesn't get over-written by updates to RetroPie.

meleu · 1 Dec 2017, 21:41

@backstander
good point. I'll sort it in the script, hold on...

BTW: ~/.emulationstation is a symbolic link to /opt/retropie/configs/all/emulationstation/.

meleu · 12 Jan 2017, 21:34

@backstander done! Can you update and test it again?

Concat · 12 Jan 2017, 22:04

Good work!

I have to update runcommand, yes? I am on 3.8, though I have updated Retropie Setup. Am I going to break something?
What's this about moving es_systems.cfg ? I swear mine isn't in /opt/retropie/configs/all/emulationstation/ . . .

backstander · 12 Jan 2017, 22:21

Thanks @meleu! I'll test it when I get home this evening.

backstander · 1 Dec 2017, 22:25

@Concat

What's this about moving es_systems.cfg ? I swear mine isn't in /opt/retropie/configs/all/emulationstation/ . . .

Check out this link:
https://github.com/retropie/retropie-setup/wiki/EmulationStation#my-es_sytemscfg-is-being-overwritten-on-updates

I probably should be using ~/.emulationstation/ instead of /opt/retropie/configs/all/emulationstation/

meleu · 1 Dec 2017, 23:02

@Concat said in runcommand launching images for ANY theme:

I have to update runcommand, yes? I am on 3.8, though I have updated Retropie Setup. Am I going to break something?

When you execute retropie_setup, what version is shown on the top? It must be 4.0.3 or higher.

What's this about moving es_systems.cfg ?

It's unnecessary to make the script work.

Concat · 12 Jan 2017, 23:19

Yeah I didn't realize that updating Setup also updates Runcommand :P I just never updated all packages cause I haven't seen a need... yet. Just the emulators have been updated when I hear of some improvements, like mupen64plus.

Anyway, I looked through your code and quickly realized it won't work for me because I edited theme.xml to change system.svg to one I prefer. Running this script will use logos that conflict with what I have in ES...

I suppose I can just add the affected systems to your "if" statements and point to the correct logo. Easier than making custom images for sure!

meleu · 12 Jan 2017, 23:24

@Concat can you show me a tweaked theme.xml as an example?

backstander · 13 Jan 2017, 01:25

@meleu

done! Can you update and test it again?

Okay so both ~/.emulationstation/es_systems.cfg and /opt/retropie/configs/all/emulationstation/es_systems.cfg are the same with the custom <theme> has "genesis" & "tg16" and /etc/emulationstation/es_systems.cfg has the defaults "megadrive" & "pcengine".

I updated script and ran it but the runcommand pictures are Megadrive & PC Engine still :`(

lilbud · 13 Jan 2017, 01:54

@meleu said

UPDATE: the material theme got promoted to the cool examples.

Concat · 13 Jan 2017, 04:55

@meleu said in runcommand launching images for ANY theme:

@Concat can you show me a tweaked theme.xml as an example?

In my /etc/emulationstation/themes/carbon/pc/theme.xml: http://pastebin.com/gyfk0WYr

You'll see I modified it to include a .PNG image instead of system.svg. Not saying you need to accommodate this hooligan behaviour :P

Just saying for me to use your script I need to modify it so it pulls the correct logo for each system.

tronkyfran · 13 Jan 2017, 08:20

@meleu ok with that crop ;)

meleu · 13 Jan 2017, 10:10

@backstander said in runcommand launching images for ANY theme:

I updated script and ran it but the runcommand pictures are Megadrive & PC Engine still :`(

Man, I tested it on my end before posting that and it worked as expect (generated an image with the "genesis" logo). Can you show me your es_systems.cfg so I can see what's going wrong?

meleu · 13 Jan 2017, 10:23

@Concat said in runcommand launching images for ANY theme:

You'll see I modified it to include a .PNG image instead of system.svg.

Did you get some error when ran the script? I think it can deal with .png logos...

meleu · 13 Jan 2017, 11:12

@Concat I've tested here and I'm pretty sure my script can deal with .png logo files. But due to the black letters your PC logo doesn't look fine with carbon background :-(

Concat · 13 Jan 2017, 11:35

Hmm sorry man, I checked again and maybe I was looking at your old script...? I could sworn I saw a line that was grabbing system.svg....

Anyway, great work! And yeah, I know about the black on black issue. It needs an outline I suppose