[Merged] Power Saver feature

cyperghost

@Sano Thank you can you make further tests please? It's important to hunt down possible bugs before a merge to the main branch can be done.

Hex

@Sano The minute is correct. I have timed it. It is just counting after some delay which you dont know about. The delay is present to finish any remaining animations and delayed displays like game count extra.

meleu

@felleg said in Testers needed :: Power Saver features :: PR #172:

This is a problem if you want to avoid screen burn-in. I'd much rather have the screensaver be able to start automatically, although, don't get me wrong, being able to start it manually is great in its own right.

I think that playing a video is not a "power saving" action. But now I think I better understood what the @Hex 's change is about.

It seems to be a fix in the logic, and not an addition of a new optional feature.

@Hex am I right saying that?

Hex

@meleu said in Testers needed :: Power Saver features :: PR #172:

.

Yes, It was a logic problem but such things get overlooked quite often. As I said, Aloshi's work might not have been optimized for Pi but it can be.

I agree Video screensaver is not a power saving feature but it is not intended to be. It is for systems that have a constant source of power and hence not battery friendly. But that does not mean that the feature is useless. A lot of effort and time went into making it worthwhile. :)

The option to enable or disable is just for your satisfaction. The functionality is not compromised at all. It just got better at doing nothing :P

meleu

Once you fixed all those "issues" related with screensaver (video/dim/blank), then will it be enabled by default and with no option to toggle it?

Hex

@meleu All bugs are fixed. The option is still there. Do you think the option should not be present?

meleu

@Hex here's my reasoning:

your change does power saving (optimizes the logic).
dim/blank/video screensaver works fine no matter if the PS is enabled (by the way, you should update this info on OP).
there isn't any advantage in leaving PS disabled.

Then here's the big question: Why the heck would anyone leave this option disabled?

If there's no answer for that question, then the conclusion is "leave it always enabled and remove the option to disable it"

Hex

@meleu Okay let me remove the option.

EDIT : Why are you highlighting it?? I wrote a lengthy answer and deleted everything. In short the answer is to disable PS if it misbehaves and yet not be shackled by a broken feature. On the other hand we have lots of Options already so screw it :D

meleu

@Hex said in Testers needed :: Power Saver features :: PR #172:

Why are you highlighting it?

I don't mean to sound like screaming, sorry if I sounded like that. :-)

I was just trying to emphasize the conclusion. Maybe we can continue this conversation on the PR thread to get Jools opinion. I'll paste my reasoning above there.

Hex

That would be a good idea

jdrassa

@Hex @meleu I haven't had a chance to test this yet, but based on my understanding of how it works, it seems likely that power saver will disable text scrolling for game descriptions and game names in the gamelist. If I am correct, this would be a reason to keep it as an option.

Another reason to do so would be to prevent any conflicts with future development. For example, there have been requests for the ability to include animated images in themes. If power saver was not an option, implementation of this feature would be dependent on implementing a way to detect and disable PS when necessary. I would hate to see a potential contributor decide not to implement something because of the extra effort involved with making it compatible with PS.

Hex

@jdrassa Firstly the text scrolling works as expected. That feature is what convoluted the entire logic from being very simple. I am glad that i got to implement this.

Secondly I concur with you on this but.... Features like animated images would be useful and it woult be easy to implement PS+animations as I have already done it for videos and users can just copy how i did it for Videos. Its two lines, one to stop powersaver when images are animated/video and another to start it again when images end. I thought about it a lot. Remember we are developing for Raspberry pi primarily. Thus we should strive to save as much processing as possible. Had it been difficult to incorporate in further development I would have said that switch would be ideal.

See the systemscreensaver.cpp here and tell me if i can make it easier.

jdrassa

@Hex I saw that is was easy enough to enable/disable. What I was referring to was the process of determining when it should be enabled vs. disabled. For video view, the logic is pretty simple, is the current view video view? However, if any animated element was supported as a theme extra, that logic would be slightly more complex. Whenever, switching views or themes, one would have to scan the list of "extra" elements to see if one was animated. It is not terribly difficult logic, but it is more complex. It would also lead to the scenario where a user may have to choose between a theme and power saver. An option would give the user the choice to still use the theme with power saver mode, even if some animated elements were disabled.

With regards to text scrolling, for the game description, the animation runs in a loop, It scrolls to the end, pauses for a bit, then resets back to the top and scrolls again. As I said, I haven't tested it yet, but I don't see how it could work based on reviewing the code. I am guessing that you have set the delay before power saving mode is enabled so that a single scroll is completed. I think that is a great way to approach it, but some users may still want/expect the old behavior, which is why I think keeping it as an option is a good idea.

Hex

@meleu Does this answer your question?

@jdrassa I am waiting for @BuZz 's response. I have both setups at hand (with and without switch). Regarding the Animated images I would have to think some more how I can get away with it without the switch. We currently have ImageComponent to show images. How would one incorporate GifComponent ? Can I interest you in a joint venture on this?

meleu

@jdrassa @Hex @psyke83

Let's jump to conclusion: I'm OK with that being an option! :-)

But when I suggest to hide this option, I'm just giving an user point of view opinion. My only concern is with ES becoming a frontend like xmb/lakka, poluted with tons of options that casual/average users don't care and would prefer to just leave the default and don't see the option.

That being said, I think that if the text scrolls and then stops, I would label it as a bug (just like we did with the screensaver issue). But once it's fixed I believe that omit the option is the "user-friendlier" approach. If it's too complicated to "fix" this behavior, OK, leave it as an option.

Regarding to animated elements, I think that when this feature is implemented, it should setPowerSaver(false). As far as I understood @jdrassa said that this logic would be complex... Well TBH I'm afraid that such feature would bloat ES and make it heavier to use on a raspi1/zero...

Hex

@meleu Isnt the default behaviour to scroll text and stop? It doesnt stop in the middle of the scroll if that is what you mean.

Dont be confused by logic being complex. It takes less than a ms to compute logic. Processing for a ms is always better than rendering for a minute.

meleu

@Hex said in Testers needed :: Power Saver features :: PR #172:

@meleu Isnt the default behaviour to scroll text and stop?

As @jdrassa said:

With regards to text scrolling, for the game description, the animation runs in a loop, It scrolls to the end, pauses for a bit, then resets back to the top and scrolls again.

I didn't really test to see this happens in your branch (will test in a couple of hours), but I think PS should keep the original behavior (scroll to the end, pause for a bit, go back to the top and scroll again).

@Hex said

Dont be confused by logic being complex. It takes less than a ms to compute logic.

I meant complex to code, not to the processor execute. :-)

meleu

@Hex Hey man! Really sorry for saying things before testing. I've just compiled and launched your branch and the game description scrolls just like the official branch (goes to the end and back to the start and scrolls again)!

Huge thanks for adding this feature and really sorry for wasting your time...

Cheers!

meleu

@Hex
UPDATE
Ooops!

The test I described above was made with video preview on. When I changed to detailed view, the text doesn't scroll at all. Maybe you want take a look at it.

Hex

@meleu \m/ :)

You guys dont ever waste my time. Your feedback is really important.

Given enough eyeballs, all bugs are shallow -- Linus Torvalds

EDIT : can you post some screenshots. That would be helpful