Please Test: Adding support for "All", "Favorites" and "Last Played" systems
-
Okay uninstalled carbon and reinstalled, and it updated.
Okay now my current problem. im under the gamelists and I cannot press a button to favorite a game.
-
Fixed my error from above.
@pjft Could you possibly make it when we favorite a game it displays a heart next to the favorited game in game list? basically they do this in Kids Mode, and in recalbox. Also all the favorited games in that collection are on the top of the list.
Found bug: When playing a game now, runcommand doesnt show. it takes me to the command line of retropie for about 3 seconds then opens the rom.
-
Another bug found, when I changed sort in gamelist to Ratings Ascended it crashed my pi.....
Why was this released? this is still way too buggy!!
EDIT: after rebooting, runcommand is now showing.
-
@red2blue please wait and take some time to actually go through things before calling out that everything is effectively buggy or not at the first sign of something not being as you expect. It'd be somewhat appreciated as there are plenty of people that have been testing it and helping with it for the past several weeks.
Can you please summarize now effectively which bugs are you experiencing so I can troubleshoot? What crashes are you getting, and how can we replicate it?
Any more information would also be helpful, like what message you get from the crash, etc.
In regards to adding a heart, that is not going to happen, at least for now.
It has been discussed quite a few times in the thread as to why not, and what's being done in that regard.
Thanks and happy Sunday.
Edit: as you now know, run command not showing happens if you launch EmulationStation via the command line.
If you can video what you do to crash it, it'd be helpful.
I believe you were using kids mode beforehand? Maybe sharing your previous kids mode gamelist for the system with the game you're having trouble seeing to favorite will help, but this should use the same info from there.
Edit 2: rating ascending wasn't touched in any way, and hasn't been for a while. You may want to share the gamelist for that system, but I bet it's more of a problem with the metadata in the gamelist. Values should be between 0 and 1, and should be numbers.
Is that really your only problem now, just to confirm?
I had received an email claiming things were crashing when you favorited something but I find no more mention of it here... If it's no longer a problem can you tell what happened and/or how you fixed it?
Thanks.
-
@red2blue Adding to what @pjft said, I would like to tell you that many of the things you find buggy are because you have done some things and have not shared this information while reporting these bugs. It is like saying that your car is going backwards rather than forwards while omitting to inform us that you shifted to Reverse thinking R was for Racing :P
Also wait for some time, think and try to debug, and document all changes that you are making . This will allow us to determine if its a bug or not and if it is then rectify it.
-
Just to add:
I tested sorting by ratings ascending and descending in several of my libraries, and it seemed to work reasonably well. Also, as I said, I don't think that has been touched in ages.
If you do have a system for which this kind of sorting is crashing (or several?), please share the gamelist(s). I'd venture a guess that it is down to the metadata you have there on the ratings, and maybe it's sourced from a specific scraper or source - and that can help narrow it down.
But I'd be surprised if it wasn't crashing before - and you probably can easily test it by re-installing the Kids branch if you'd be so inclined and testing whether that crashes the same way or not.
Do let us know what you're experiencing and what is, effectively, still a problem - we're keen on helping.
Thanks. Happy Sunday.
-
As a user and not a coder, this is all very exciting. Many thanks to those sweating the details on something that will likely become very usable and functional.
Is there a current, brief list of the elements that are now being worked on for this update?
-
@ohmycommodore Thank you - looking forward to having more and more people enjoying them!
At the moment, if you update from binary - it should be version 2.4.0 - you'll have all these features so far: the option to turn on the systems for "All Games", "Favorites" and "Last Played".
In the future (say, give or take end of month or beginning of August) we'll hopefully be able to define custom collections of our own inside ES. But that work has still not started, and from the look of my coming weeks at work, I'm not sure how much free time I'll effectively have outside of work to make progress on these.
But we'll get there, I'm sure.
-
@pjft Great thanks, where is the toggle to turn this on, following the binary update?
-
This post is deleted! -
@ohmycommodore in the start menu, there should be a game collections menu now.
Do make sure to use an updated theme that supports them, though. You'll see a separate thread on that, that's listing all currently updated themes. I'm on my phone so can't easily link to it, sorry. .
Let us know how it goes. I'm curious as well as somewhat seeking more feedback given reports from earlier today, despite all the tests that this went through. Hope it works well for you!
Edit: it's here:
-
@pjft So the crashing when i favorited something was when i was using a 'unsupported' theme, which was carbon. after changing to comic book theme it fixed. When I changed to the Comic Book theme, thats when all my errors i wrote above was happening. After I manually restarted my pi (turning off power receiver then switching back on) all the problems stopped.
I dont think i can replicate the same exact problems, it just happened after the carbon theme switch to comic book.
As of now, I haven't had any errors or bugs after restarting console.
NOTE: The carbon theme had the favorite crashing error before carbon was updated for recent build.
-
@red2blue Just as a clarification - please confirm when using the ComicBook Theme everything works correctly. Thank you
-
@red2blue thanks!
I'll check if anything stands out when using an unsupported theme - I do have to say I only tested that briefly. I wouldn't expect that to have any effect, but it is certainly a good pointer.
Glad all is going well otherwise then.
-
@TMNTturtlguy everything is working perfectly however when i was recieing the bugs mentioned earlier, runcommand not working, command line only showing, etc etc it was when i was using your theme. but everything is good now
@pjft no problem brotha
-
@red2blue Not a bother.
Couldn't replicate any crash on my end, but will keep an eye out for it.
Best.
-
I found a conflict with FAVORITES and the retropie powerblock driver (and likely all 3rd party pi power circuits).
When a favorite is marked via the controller button shortcut or the metadata updater, the gamelist is updated in memory. Gamelists aren't saved to disk until ES is exited (not news to anybody).
Powerblock drivers appear to simply stop the ES process when the powerblock is switched off, not allowing gamelist.xml files to write back (similar to crashing ES), losing any new Favorites marked during that session as a result.
Given most 3rd party power control circuits and the 1 button gpio shutdown circuit use a similar hard stop function to shutdown the pi, a fix to ES to write the favorite tag to the gamelist.xml on disk at the time a favorite is marked might clean this up for people who use software controlled power switches.
-
@capeman This is likely an issue with editing metadata as well. The gamelists are only saved on exit because it can be a slow process. A workaround for now, is that you can restart EmulationStation from its menu to ensure any metadata changes are saved, before shutting down.
Get latest build of EmulationStation for Windows here
-
@jdrassa that's what I've been doing, quit ES out to a command line then flip the power switch. It works well enough but it's easy to forget to do.
Vector Artist, Designer and Maker of Stuff: Laser Cut Atari / Pixel Theme Bartop
-
@capeman thanks. Yeah, either that or adjusting the shutdown script to make that happen - or even the driver. Probably that will be the best.
Read up on this entire thread, with a proposed solution:
https://retropie.org.uk/forum/post/95214
As well as the problems of saving metadata immediately. It's not that we can't add an option for that, but there's specific reasons why that isn't happening, mostly performance related.
Contributions to the project are always appreciated, so if you would like to support us with a donation you can do so here.
Hosting provided by Mythic-Beasts. See the Hosting Information page for more information.