Versatile C++ game scraper: Skyscraper

Brunnis

@muldjord Awesome, now it found every single ROM I have! :-D For some reason, it missed a lot of games when running the first time, but then I immediately ran it again and it found all of them. Perhaps communication issues with screenscraper.fr?

Anyway, thanks for fixing this so quickly! With these issues fixed, I guess a lot of people will notice an improvement.

muldjord

@Brunnis Yes, I am currently going over some of my previously skipped files aswell, and a lot of them are now getting recognized. This is really cool, so thank you for being persistent in getting me to look at this.

EDIT: Btw, for anyone using the 'screenscraper' module in Skyscraper, do consider supporting them on patreon or by contributing data to their database. They are doing an amazing job with the new APIv2 (which Skyscraper uses). Same goes for the RetroPie project, please consider supporting them aswell.

Brunnis

@muldjord No problem, glad I could help! :-)

Wonderbread

~~I find that I can't rescrape certain games that previously worked with screenscraper. For example:~~

Never mind, it looks like it was a temporary problem with screenscraper. It seems to be working ok for me now.

ByteThis

@muldjord Is Skyscraper down ? I had been using it via command line and tried to update it today to the lastest version and got an error, then I uninstalled it and tried to re-install it and the same error popped up not allowing it to install from scratch.This is the error:
compilation terminated.
Makefile:748: recipe for target 'skyscraper.o' failed
make *** (skyscraper.o) Error 1

I then tried to install it via Retropie Setup and received the error
Could not successfully build skyscraper -Scraper for Emulationstation by Lars Muldjord.
(/home/pi/Retropie Setup/tmp/build/skyscraper/Skyscraper not found)

mitu

@ByteThis Can you post the complete error log on pastebin.com - you should find the complete log file in ~/RetroPie-Setup/logs.

ByteThis

@mitu Sure here is the one from trying to install via Retropie Setup : https://pastebin.com/r3Sc4CXX

I deleted the one from the command line but I will reproduce the error and paste it here.

Here is the second log : https://pastebin.com/TeGYj0bD

muldjord

@ByteThis Looks really odd. Seems like it is missing a qt5 dependency. It can't find the QStorageInfo headers. This works just fine on my own Pi 3B+. Just for the heck of it, try running:

$ sudo apt-get install qt5-default

And then try installing it again.

mitu

@ByteThis Ugh, it looks like your Raspbian version doesn't have an up-to-date QT5 install (well, what @muldjord said :) ). Are you running on Raspbian Jessie or older ?

ByteThis

@mitu This build still on jessie. I will try muldjord's suggestion.

@muldjord This is what the output after running that command :
https://pastebin.com/UqrXU2bB

mitu

@ByteThis I don't think it will help - the install script already installs that package and it's probably already installed from the first time you added Skyscraper.

ByteThis

@mitu I was running Skyscraper fine with jessie until the mishap with the Screenscraper API that @muldjord fixed..lol.

muldjord

@ByteThis Yeah, I have no idea why this would happen... Only thing that springs to mind is a failing SD card. I haven't seen this error before and, as I mentioned, it compiles just fine on my own Pi.

ByteThis

@muldjord Weird..my sd card is fine as it is only about a month old and have been adding roms and such fine with it. Is your newest version of Skyscraper compatible with jessie ? (I imagine it is)

mitu

No, your QT5 is too old.
Debian Jessie has Qt5.3.2 (https://packages.debian.org/jessie/qt5-default), however @muldjord added a space checking feature recently which requires QStorageInfo. QStorageInfo has been added in Qt 5.4 (https://doc.qt.io/qt-5/qstorageinfo.html), so it's obviously missing on Jessie - there's no card corruption happening.

muldjord

Ah, yes, that's the reason then. I had no idea the Qt5 version on Jessie was that old.

mitu

@muldjord Oh, man, you killed jessie (sorry, couldn't resist).

ByteThis

@muldjord Are you able to implement a workaround for those of us that are still using jessie ?

muldjord

@ByteThis said in Versatile C++ game scraper: Skyscraper:

@muldjord Are you able to implement a workaround for those of us that are still using jessie ?

Already done so. I've included a check for the Qt version so it only includes the space check if the user has Qt5.4.0 or later. It will be in 3.0.4.

muldjord

@ByteThis 3.0.4 out now. Please update and test.