VICE problem launching VIC20 cartridges

[BuZz]

@greg_king You are correct about the apostrophes causing an issue, however, the script also expects the rom as parameter 2. It will need another fix (I'm working on it).

[BuZz]

removing the quotes around the $BIN in the second to last line in the vice.sh script should sort it but will test.

from

"$BIN" -chdir "$romdir" "$ROM"

to

$BIN -chdir "$romdir" "$ROM"

[BuZz]

Needs more than this due to parameter ordering etc. Going to swap some stuff around.

[BuZz]

Please update the RetroPie-Setup script then update vice from binary and see if that resolves it for you.

https://github.com/RetroPie/RetroPie-Setup/commit/a63a32fe2e51dae84f4b784917d8192c0f14866b

[UDb23]

@greg_king ok, thanks.

[UDb23]

Thanks @buzz. Will Check your fix tomorrow morning and let you know.

What about the vic expanded launch command (emulators.cfg for c64 mentioned before) not calling vice.sh but xvic directly? Is there a specific reason or just a typo?

[BuZz]

@udb23 RetroPie doesn't come with any vic-expanded entry.

[UDb23]

@buzz Huh, I see.
That's quite strange... wondering if it comes from a previous config I made but I'm quite sure I never knew or saw that RATIO=1.33 setting used in that launch command.

The xvic expanded launch command is mentioned in this old post.
Maybe worth adding to Retropie.

[BuZz]

@udb23 the ratio thing was part of an older retropie when we used sdl1 - since that post was made it was removed. Your expanded line should be updated to use the vice.sh if you want to have archive unpacking etc. I will consider adding that line (Although we already have many launch items, and I'm not sure how common it is to use that).

[UDb23]

@buzz Updated setup script and vice from binary; xvic now launched correctly with specific parameters. Also edited emulators.cfg for expanded as suggested.

Runcommand.log is here.
It shows some errors, probably just minor as cartridges seem to work perfectly.

Thanks for the fix ! Really appreciated.