Crash: Removing favourite

Srdrgz

@pjft said in Crash: Removing favourite:

@steeeb I've seen reports of this also happening in 2.6.5, so it might be that those bisect instructions that I provided have a flawed assumption.

Did u happen to read what pjft posted regarding his bisect instructions...

pjft

@mitu thank you for taking the time and sorry for making you go through that!

I happened to take a look at it this afternoon and submitted a fix for it. It's been accepted in the development branch.

If you're curious about what happened, you can read here:

https://github.com/RetroPie/EmulationStation/pull/323

Sorry for the trouble. There's still a minor outstanding issue regarding ES not showing empty collections on startup, which cropped up in some recent changes, but I'm also looking through that.

In the meantime if per chance you have a collection that's empty and doesn't show after you add something to it, either restart ES or change the collections settings so it refreshes them.

Sorry about the inconvenience!

mitu

@pjft Great - thank you for the fix !

pjft

@mitu not a problem. If anyone wants to test that out though, by all means. It'd be nice to confirm it's fixed:)

Srdrgz

@pjft

I tested your fix and can confirm that it does work. ES no longer crashes when removing the last favorite game. It works in all situations ie: favorites menu, last played menu, emulator menu.

Thank you, much appreciated.

mitu

@pjft Yep, it works - compiled the latest from master and doesn't crash anymore.I can go back to getting beaten by Ghosts 'n Goblins now.

dylosaur

@mitu Sorry to be a bother, but I'm having this same problem and found your thread. I'm new to this so I wasn't exactly sure how I would go about fixing the problem? What's this about compiling from master? I updated from source today but it didn't fix the problem. Thanks in advance.

BuZz

@dylosaur it should be fixed in the latest binaries built earlier.

mitu

@buzz I updated ES from binary, but I still get the crash when removing the last favorite. Maybe the re-built is still from stable branch, where the fix might not be applied.

dylosaur

@buzz Yeah, I updated from the binaries and the crash is still occurring unfortunately.

BuZz

@mitu I think I may have forgotten to push the branch back to github. I am rebuilding binaries now (or try to build from source and see if that sorts it).

dylosaur

@buzz Just updated from source and can confirm that it worked. Thanks for the fix!