MK_ARCADE_JOYSTICK_RPI install fails

MaMikee

Fresh install to be sure nothing I had previously done messed things up...

RPIE 3 A+ with Retropie 4.19.50-v7+

From Rpie-setup -> manage packages -> driver: 818 mkarcadejoystick. Logs show this error:

Log started at: Wed 24 Jul 19:26:21 BST 2019

RetroPie-Setup version: 4.5 (f0ef1271)
System: Linux retropie 4.19.50-v7+ #896 SMP Thu Jun 20 16:11:44 BST 2019 armv7l GNU/Linux

= = = = = = = = = = = = = = = = = = = = =
Installing dependencies for 'mkarcadejoystick' : Raspberry Pi GPIO Joystick Driver
= = = = = = = = = = = = = = = = = = = = =

/home/pi/RetroPie-Setup/tmp/build/mkarcadejoystick /home/pi

= = = = = = = = = = = = = = = = = = = = =
Getting sources for 'mkarcadejoystick' : Raspberry Pi GPIO Joystick Driver
= = = = = = = = = = = = = = = = = = = = =

git clone --recursive --depth 1 "https://github.com/recalbox/mk_arcade_joystick_rpi" "/opt/retropie/supplementary/mkarcadejoystick"
Cloning into '/opt/retropie/supplementary/mkarcadejoystick'...
HEAD is now in branch 'master' at commit '39b0094335a1bb9667b7c04cb6a6d3e9a951dda2'
/home/pi

= = = = = = = = = = = = = = = = = = = = =
Building 'mkarcadejoystick' : Raspberry Pi GPIO Joystick Driver
= = = = = = = = = = = = = = = = = = = = =

Creating symlink /var/lib/dkms/mk_arcade_joystick_rpi/0.1.5/source ->
/usr/src/mk_arcade_joystick_rpi-0.1.5

DKMS: add completed.

Kernel preparation unnecessary for this kernel. Skipping...

Building module:
cleaning build area....
make -j4 KERNELRELEASE=4.19.50-v7+ all KVERSION=4.19.50-v7+....(bad exit status: 2)
Error! Bad return status for module build on kernel: 4.19.50-v7+ (armv7l)
Consult /var/lib/dkms/mk_arcade_joystick_rpi/0.1.5/build/make.log for more information.
/opt/retropie/supplementary/mkarcadejoystick /home/pi

= = = = = = = = = = = = = = = = = = = = =
Configuring 'mkarcadejoystick' : Raspberry Pi GPIO Joystick Driver
= = = = = = = = = = = = = = = = = = = = =

modprobe: FATAL: Module mk_arcade_joystick_rpi not found in directory /lib/modules/4.19.50-v7+
/home/pi

Log ended at: Wed 24 Jul 19:26:38 BST 2019
Total running time: 0 hours, 0 mins, 17 secs

mitu

@MaMikee said in MK_ARCADE_JOYSTICK_RPI install fails:

/var/lib/dkms/mk_arcade_joystick_rpi/0.1.5/build/make.log

Can you post the contents of this log ?

EDIT: Also, can you post the information asked in https://retropie.org.uk/forum/topic/3/read-this-first ?

MaMikee

DKMS make.log for mk_arcade_joystick_rpi-0.1.5 for kernel 4.19.50-v7+ (armv7l)
Wed 24 Jul 19:26:31 BST 2019
make -C /lib/modules/4.19.50-v7+/build M=/var/lib/dkms/mk_arcade_joystick_rpi/0.1.5/build modules
make[1]: Entering directory '/usr/src/linux-headers-4.19.50-v7+'
CC [M] /var/lib/dkms/mk_arcade_joystick_rpi/0.1.5/build/mk_arcade_joystick_rpi.o
/var/lib/dkms/mk_arcade_joystick_rpi/0.1.5/build/mk_arcade_joystick_rpi.c:152:1: warning: no semicolon at end of struct or union
};
^
/var/lib/dkms/mk_arcade_joystick_rpi/0.1.5/build/mk_arcade_joystick_rpi.c: In function ‘i2c_read’:
/var/lib/dkms/mk_arcade_joystick_rpi/0.1.5/build/mk_arcade_joystick_rpi.c:272:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
unsigned short bufidx;
^~~~~~~~
In file included from ./include/linux/printk.h:7:0,
from ./include/linux/kernel.h:14,
from /var/lib/dkms/mk_arcade_joystick_rpi/0.1.5/build/mk_arcade_joystick_rpi.c:29:
/var/lib/dkms/mk_arcade_joystick_rpi/0.1.5/build/mk_arcade_joystick_rpi.c: In function ‘mk_setup_pad’:
./include/linux/kern_levels.h:5:18: warning: too many arguments for format [-Wformat-extra-args]
#define KERN_SOH "\001" /* ASCII Start Of Header /
^
./include/linux/kern_levels.h:11:18: note: in expansion of macro ‘KERN_SOH’
#define KERN_ERR KERN_SOH "3" / error conditions */
^~~~~~~~
./include/linux/printk.h:308:9: note: in expansion of macro ‘KERN_ERR’
printk(KERN_ERR pr_fmt(fmt), ##VA_ARGS)
^~~~~~~~
/var/lib/dkms/mk_arcade_joystick_rpi/0.1.5/build/mk_arcade_joystick_rpi.c:426:14: note: in expansion of macro ‘pr_err’
pr_err("Invalid gpio argument\n", pad_type);
^~~~~~
/var/lib/dkms/mk_arcade_joystick_rpi/0.1.5/build/mk_arcade_joystick_rpi.c:458:5: warning: this ‘for’ clause does not guard... [-Wmisleading-indentation]
for (i = 0; i < 2; i++)
^~~
/var/lib/dkms/mk_arcade_joystick_rpi/0.1.5/build/mk_arcade_joystick_rpi.c:460:2: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘for’
if (pad_type != MK_ARCADE_MCP23017)
^~
/var/lib/dkms/mk_arcade_joystick_rpi/0.1.5/build/mk_arcade_joystick_rpi.c: In function ‘mk_probe’:
/var/lib/dkms/mk_arcade_joystick_rpi/0.1.5/build/mk_arcade_joystick_rpi.c:548:5: error: implicit declaration of function ‘setup_timer’ [-Werror=implicit-function-declaration]
setup_timer(&mk->timer, mk_timer, (long) mk);
^~~~~~~~~~~
/var/lib/dkms/mk_arcade_joystick_rpi/0.1.5/build/mk_arcade_joystick_rpi.c: In function ‘mk_setup_pad’:
/var/lib/dkms/mk_arcade_joystick_rpi/0.1.5/build/mk_arcade_joystick_rpi.c:467:32: warning: iteration 12 invokes undefined behavior [-Waggressive-loop-optimizations]
__set_bit(mk_arcade_gpio_btn[i], input_dev->keybit);
~~~~~~~~~~~~~~^
/var/lib/dkms/mk_arcade_joystick_rpi/0.1.5/build/mk_arcade_joystick_rpi.c:466:3: note: within this loop
for (i = 0; i < mk_max_mcp_arcade_buttons; i++)
^
cc1: some warnings being treated as errors
scripts/Makefile.build:309: recipe for target '/var/lib/dkms/mk_arcade_joystick_rpi/0.1.5/build/mk_arcade_joystick_rpi.o' failed
make[2]: *** [/var/lib/dkms/mk_arcade_joystick_rpi/0.1.5/build/mk_arcade_joystick_rpi.o] Error 1
Makefile:1517: recipe for target 'module/var/lib/dkms/mk_arcade_joystick_rpi/0.1.5/build' failed
make[1]: *** [module/var/lib/dkms/mk_arcade_joystick_rpi/0.1.5/build] Error 2
make[1]: Leaving directory '/usr/src/linux-headers-4.19.50-v7+'
Makefile:9: recipe for target 'all' failed
make: *** [all] Error 2

BuZz

Update your RetroPie. You're not on latest. Including system packages (second option).

MaMikee

That did it, my homemade joystick is working now direct into the CPU.

I do find it disturbing though that an official release is internally inconsistent. With any open project my next move should be to volunteer to fix it. I'm not there yet but learning every day.

Thanks for all the help!

mcb