lr-mame2016: fails to compile: 01_disable_bgfx.diff failed to apply

vbs

Happens on Lubuntu 18.04 on an Intel NUC with latest setup script:

root@wz-retro:/home/vbs/RetroPie-Setup/logs# cat rps_2019-07-28_151515.log
Log started at: So 28. Jul 15:15:15 CEST 2019

RetroPie-Setup version: 4.5.1 (c8f6cfdf)
System: Ubuntu 18.04.2 LTS - Linux wz-retro 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
/home/vbs/RetroPie-Setup/tmp/build/lr-mame2016 /home/vbs/RetroPie-Setup

= = = = = = = = = = = = = = = = = = = = =
Getting sources for 'lr-mame2016' : MAME emulator - MAME 0.174 port for libretro
= = = = = = = = = = = = = = = = = = = = =

git clone --recursive --depth 1 --branch master "https://github.com/libretro/mame2016-libretro.git" "/home/vbs/RetroPie-Setup/tmp/build/lr-mame2016"
Klone nach '/home/vbs/RetroPie-Setup/tmp/build/lr-mame2016' ...
Checke Dateien aus: 100% (21877/21877), Fertig.
HEAD is now in branch 'master' at commit 'efc37c9968fe24af8d91d9ce6022e080a1fd90c3'
patching file Makefile.libretro
Hunk #1 succeeded at 57 with fuzz 2 (offset 2 lines).
patching file scripts/genie.lua
Hunk #1 FAILED at 387.
1 out of 1 hunk FAILED -- saving rejects to file scripts/genie.lua.rej
patching file scripts/src/3rdparty.lua
Hunk #1 FAILED at 716.
Hunk #2 FAILED at 872.
2 out of 2 hunks FAILED -- saving rejects to file scripts/src/3rdparty.lua.rej
patching file scripts/src/main.lua
Hunk #1 FAILED at 294.
1 out of 1 hunk FAILED -- saving rejects to file scripts/src/main.lua.rej
/home/vbs/RetroPie-Setup
lr-mame2016 patch /home/vbs/RetroPie-Setup/scriptmodules/libretrocores/lr-mame2016/01_disable_bgfx.diff failed to apply

Log ended at: So 28. Jul 15:15:44 CEST 2019
Total running time: 0 hours, 0 mins, 29 secs

mitu

Thanks for the report - it looks like upstream integrated the a patch that RetroPie applied locally and that's why the build fails. It will be modified in the RetroPie repo in an update.

mitu

Update your RetroPie-Setup script and try again building lr-mame2016, it should work now.

vbs

@mitu
Thank you, works!

fredianelli

Hello everyone!
This post is old and I don't know if it's better create another one or if it's better post here.
This issue happens again on Ubuntu 20.04.1 LTS as follows:

Log started at: dom 18 out 2020 13:41:01 -03

RetroPie-Setup version: 4.6.9 (102e25a)
System: x86 (x86_64) - Ubuntu 20.04.1 LTS - Linux xxxxx-ubuntu 5.4.0-51-generic #56-Ubuntu SMP Mon Oct 5 14:28:49 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
/home/xxxxx/RetroPie-Setup/tmp/build/lr-mess2016 /home/xxxxx/RetroPie-Setup

= = = = = = = = = = = = = = = = = = = = =
Getting sources for 'lr-mess2016' : MESS emulator - MESS Port for libretro
= = = = = = = = = = = = = = = = = = = = =

git clone --recursive --depth 1 --branch master "https://github.com/libretro/mame2016-libretro.git" "/home/xxxxx/RetroPie-Setup/tmp/build/lr-mess2016"
Cloning into '/home/xxxxx/RetroPie-Setup/tmp/build/lr-mess2016'...
Updating files:  51% (11189/21876)
Updating files:  52% (11376/21876)
Updating files:  53% (11595/21876)
Updating files:  54% (11814/21876)
Updating files:  55% (12032/21876)
Updating files:  56% (12251/21876)
Updating files:  57% (12470/21876)
Updating files:  58% (12689/21876)
Updating files:  59% (12907/21876)
Updating files:  60% (13126/21876)
Updating files:  61% (13345/21876)
Updating files:  62% (13564/21876)
Updating files:  63% (13782/21876)
Updating files:  64% (14001/21876)
Updating files:  65% (14220/21876)
Updating files:  66% (14439/21876)
Updating files:  67% (14657/21876)
Updating files:  68% (14876/21876)
Updating files:  69% (15095/21876)
Updating files:  70% (15314/21876)
Updating files:  71% (15532/21876)
Updating files:  72% (15751/21876)
Updating files:  73% (15970/21876)
Updating files:  74% (16189/21876)
Updating files:  75% (16407/21876)
Updating files:  76% (16626/21876)
Updating files:  77% (16845/21876)
Updating files:  78% (17064/21876)
Updating files:  79% (17283/21876)
Updating files:  80% (17501/21876)
Updating files:  81% (17720/21876)
Updating files:  82% (17939/21876)
Updating files:  83% (18158/21876)
Updating files:  84% (18376/21876)
Updating files:  85% (18595/21876)
Updating files:  86% (18814/21876)
Updating files:  87% (19033/21876)
Updating files:  88% (19251/21876)
Updating files:  89% (19470/21876)
Updating files:  90% (19689/21876)
Updating files:  91% (19908/21876)
Updating files:  92% (20126/21876)
Updating files:  93% (20345/21876)
Updating files:  94% (20564/21876)
Updating files:  95% (20783/21876)
Updating files:  96% (21001/21876)
Updating files:  97% (21220/21876)
Updating files:  98% (21439/21876)
Updating files:  99% (21658/21876)
Updating files: 100% (21876/21876)
Updating files: 100% (21876/21876), done.
HEAD is now in branch 'master' at commit 'd53c379892b0bd91b4a52fc2de491e1199f03e32'
/home/xxxxx/RetroPie-Setup/scriptmodules/helpers.sh: linha 977: /home/xxxxx/RetroPie-Setup/scriptmodules/libretrocores/lr-mame2016/01_disable_bgfx.diff: Arquivo ou diretório não encontrado
/home/xxxxx/RetroPie-Setup
lr-mess2016 patch /home/xxxxx/RetroPie-Setup/scriptmodules/libretrocores/lr-mame2016/01_disable_bgfx.diff failed to apply

Log ended at: dom 18 out 2020 13:41:34 -03
Total running time: 0 hours, 0 mins, 33 secs

I hope this information can help to fix the issue!

mitu

Thanks for the report, we'll see how it can be fixed.