ScummVM 2.1.0

GeekOB

Hi all,
ScummVM 2.1.0 was officially released this weekend by the ScummVM team. I have compiled from the github source on my RPi3b running RetroPie 2.5.1 and it works beautifully.
The only downside is that when running RetroPie updates it reverts back to the latest binary which is 2.0.
Is there anyway to prevent this from happening?
I don't like to ask for timelines but how long does it usually take to update the binary when a stable version of an emulator has been released?
Many thanks in advance

hhromic

How did you compile it? Manually or using RetroPie and changing the version number to pull from?

Can you share the exact things you did?

A good way to help us is to do the testing and find out the requiried changes to the scriptmodule.

GeekOB

Of course @hhromic ,
I did it from RetroPie, I just changed the branch to pull:

Modified the scummvm.sh within ~/RetroPie-Setup/scriptmodules/emulators
Changed the line that has "gitPullOrClone..." change "branch-2-0" to "branch-2-1-0".
This new version supports lots of new games (Blade Runner is now playable!!) and cool features like cloud-based savegames, and they work as intended after compiled.
Thanks!!

hhromic

@GeekOB that sounds great! Thanks for testing and confirming is an easy upgrade.

I'll help pushing the update to the RetroPie repository shortly.

hhromic

@GeekOB is there any reason why you used branch-2-1-0 instead of branch-2-1 ? The latter seems to be the proper one.

Can you re-test building and playing with branch-2-1 ?

GeekOB

@hhromic honestly, I first tried with master and it worked perfectly fine as well. I'll compile branch-2-1 and let you know how it runs.
Is that the one you'd turn into binary?

hhromic

@GeekOB once you confirm it working, I'll send a PR to update the version. Then soon the binary should be updated from there.

GeekOB

@hhromic I can confirm branch-2-1 compiled and installed succesfully on RetroPie 4.5.1
So far Blade Runner, Versailles 1685, Codename: Iceman and Broken Sword 1 run properly.
I'll continue to test more games but I think it's a good idea to consider updating the binary.

hhromic

@GeekOB thanks for all the testing, appreciated!

I sent a PR now to RetroPie for updating ScummVM: https://github.com/RetroPie/RetroPie-Setup/pull/2873

Note that after merged, you have to wait a bit more for the binary to be updated manually in the repository. The more feedback you give on testing games the faster we can update the binary. Cheers!

GeekOB

Thanks @hhromic . I'm curious, why is branch-2-1 the right one and not branch-2-1-0? I thought the stable one was the best choice? What's the difference/impact for the RetroPie project?

mitu

@GeekOB I'm not 100% sure, but 2.1 could mean it's a 'rolling stable' branch, which will include all the fixes in the 2.1.x series, while 2-1-0 is just for that particular version/release. So if any 2.1.x version is released, with fixes or improvements, you'll get that version automatically and you don't have to switch to the 2-1-x branch to reach that version.

hhromic

@GeekOB what @mitu said :)

As you can see in the branches status on GitHub, 2-1 actively fixes bugs for 2.1, while 2-1-0 is a point release.

Also, is the branching model that the scriptmodule used before, i.e. 2-0 :)

GeekOB

Thanks for the clarification @mitu and @hhromic , crystal clear now!
Just waiting for the binary to be updated :)

BuZz

I have built them but haven't uploaded yet. You can build from source in the meantime :-)

GeekOB

Thanks for the heads up @BuZz . Can you post here when it's been uploaded?

BuZz

@GeekOB uploaded. had to rebuild the sdl1 binary also (I forgot about that).

Darksavior

@hhromic So no libretro dev wants to do the task to port this new version over? I miss using the crt-pi shader with scummvm.

GeekOB

Confirmed, @BuZz . Thank you!

The ScummVM development team has asked me to emphasize the following:

This build is not 2.1.0, but build of the stable branch.
This build is not official and not supported by the ScummVM team.

hhromic

@BuZz thanks!

@Darksavior good news!
https://github.com/libretro/scummvm/pull/150

@GeekOB great it worked for you now.
Cheers!

GeekOB

Hi @buzz @mitu and @hhromic

I updated ScummVM using the new binary which is displayed in the port as 2.1.1pre (Oct 15 2019) and I noticed one of the key new features for the 2.1.0 release, Cloud Saves, was missing from the main menu:
ScummVM 2.1.1pre (Oct 15 2019).png

I had seen it before when I compiled from source using branch-2-1-0, master and even branch-2-1. I tried compiling again using the official point release from branch-2-1-0 and the option appeared again:
ScummVM 2.1.0.png

I reached out to the ScummVM Project team and they told me branch-2-1 shouldn't be used for ports as it uses not well-tested features. Also, enabling all engines will enable the experimental ones and users may get wrong the impression that the games get registered, and then do not work. Basing a release port not on the release branch (branch-2-1-0) is very close with making it unpredictable as well because it is being slowly expanded, and version 2.1.1 may not even be released at all.

The ScummVM devs offered their help to review, suggest needed fixes and improve the port to ensure it works as intended so everyone is happy :)
You can reach their project lead at sev@scummvm.org

I hope this is useful, as a fan of both ScummVM and RetroPie I want to help in making the user experience as good as possible and minimize annoying bugs for the devs to deal with.

Thanks,