new scriptmodules (lr-vice-xvic, gsplus, proper lr-mess integration!)

Folly

I hope I can install your artwork soon. :-)

Here an update on my script :

I keep my stable version online.

Today I finished my test version.
It took me about 14 hours to take it this far and I am quite happy about it.
If all goes to plan, I will put it on github this evening.
I will call it :
generate-lr-mess-systems-1v3-alpha.sh

I think I have made a quite unique function to match MESS/MAME names to RetroPie names.
I am quite impressed on how this works. ;-)
I have only tested this with single system creations,
but I think it will do most with no problem.
(or at least I hope so)

Only the system name "PC" is a problem and perhaps I forgot some system.
That is why it's in an alha testing state.
Perhaps more problems arise.

It will output names (a bit shorter, for now I keep "gen" in it, to distingquish between original valerino and my generated versions):
gen-lr-mess-<RetroPiename>-<MESSname><-media>.sh

Can you test this version a bit for me ?

DTEAM

@folly said in new scriptmodules (lr-vice-xvic, gsplus, proper lr-mess integration!):

Can you test this version a bit for me ?

with generate-desired-systems.sh

I had an issue with SVMU artwork. I'll try to fix It. It works on a 5inch screen but not on a regular TV

Folly

@dteam

Did a fix on neogeo :
Added memc media in the filter for detecting neogeo.

DTEAM

@folly said in new scriptmodules (lr-vice-xvic, gsplus, proper lr-mess integration!):

ps. updated the script : now the .zip extension is always added in the generated script. So .zip files will appear in emulationstation.

.7z extension could be also add to es_systems.cfg.

It works. The names are doubled like:

lr-mess-snes-snes-cart or
lr-mess-a5200-a5200-cart

Not the purpose, but just to know:

Nes (good performance)
SNES won't load (BIOS issue)
a2600 (good performance)
a5200 (screen view to set)
N64 run at 25 FPS (really slow)
32x (won't load , probably bad romset)
3DO (stop on 3DO screen, but not freeze)

I confirm, the names are matching between Retropie and MAME. It works!

Folly

@dteam said in new scriptmodules (lr-vice-xvic, gsplus, proper lr-mess integration!):

@folly said in new scriptmodules (lr-vice-xvic, gsplus, proper lr-mess integration!):

ps. updated the script : now the .zip extension is always added in the generated script. So .zip files will appear in emulationstation.

7z. ext. could be also add.

Indeed, was thinking about that. I can implement this.
EDIT : .7z is added in the scripts now.

It works. The names are doubled like:

lr-mess-snes-snes-cart or

lr-mess-a5200-a5200-cart

EDIT : I see now Atari 5200 does not have the right name, will try to fix this
(EDIT: checked it, I have a good file (no issue): gen-lr-mess-atari5200-a5200-cart.sh)

Yes that is correct. Both names are in the filemame :
gen-lr-mess-<RetroPiename>-<MESSname><-media>.sh
Perhaps there is a better way of naming.
We can discuss that.
For now I did this to check The RetroPie names against the MESS name.
(EDIT: now it was already usefull to detect an issue with a5200)
(EDIT: checked it, I have a good file (no issue): gen-lr-mess-atari5200-a5200-cart.sh)
In these examples they are both the same.
But with others they aren't.
With msx you get something like this :
msx-hbf700p-flop1 quite usefull, I think.

Not the purpose, but just to know:

Nes (good performance)
SNES won't load (BIOS issue)
a2600 (good performance)
a5200 (screen view to set)
N64 run at 25 FPS (really slow)
32x (won't load , probably bad romset)
3DO (stop on 3DO screen, but not freeze)

I confirm, the names are matching between Retropie and MAME.

Thanks for already testing a bit !

I downloaded the artwork and tested it on gameboy.
The artwork works oob. Nice job.

Only my space ship was toooo fast, Game over ^^

Folly

@dteam said in new scriptmodules (lr-vice-xvic, gsplus, proper lr-mess integration!):

bash generate-lr-mess-systems-1v3-alpha.sh nes
bash generate-lr-mess-systems-1v3-alpha.sh a2600
bash generate-lr-mess-systems-1v3-alpha.sh a5200
....

Perhaps you know. Perhaps others don't.
But this is also nice in the terminal.

Just copy and past the multiple lines will do the job also.
Isn't that great. ;-)

TPR

I'm trying to install GSPlus but I'm running into the following error. Any ideas? Thank you.
GSplus error.jpg

Folly

@tpr said in new scriptmodules (lr-vice-xvic, gsplus, proper lr-mess integration!):

I'm trying to install GSPlus but I'm running into the following error. Any ideas? Thank you.

You did not add much info to your problem.
But it seems like you are installing the standalone gsplus from source (original valerino)

Tried this for you now, I have the same error (using Raspberry Pi OS Buster on pi4)
You have to read your specific/latest log in to find out more :
/home/pi/RetroPie-Setup/logs
In my log => fatal error: readline/readline.h file does not exist.
So it seems to be a fault in the source code.
So the compilation is terminated and thats why the binary isn't found.

The script gets his sourcode from :
https://github.com/digarok/gsplus

Folly

@DTEAM

I want to discuss the BIOS directory for my generated scripts.

For my script I was thinking to change the BIOS directory so all lr-mess bios files go in there. Just to seperate them from the others. What do you think of that idea ?

So the lr-mess-bios directory is going to be something like :
/home/pi/RetroPie/BIOS/lr-mess
(perhaps there is a better way)

I think it's also possible to separate them on mess names, so we get a be view on what is where. Like this :
/home/pi/RetroPie/BIOS/lr-mess/<MESSsystem>

I don't know if I change it in the script, if this will work directly.
But if it works, what do you think of this idea ?

TPR

@folly I have added that file from the source but I'm still getting errors. This is what my log currently tells me:

[ 16%] Building C object bin/atbridge/CMakeFiles/atbridge.dir/port.c.o
[ 18%] Linking C static library libatbridge.a
[ 18%] Built target atbridge
[ 20%] Linking C executable to_pro
[ 20%] Built target to_pro
make: *** [Makefile:84: all] Error 2
/home/pi
Could not successfully build gsplus - Apple II/GS emulator (/home/pi/RetroPie-Setup/tmp/build/gsplus/bin/GSplus not found).

Any further help would be appreciated. Thank you.

TPR

@roslof I've been trying to get GSplus up and running and have everything you've mentioned in this post except for this: GSOS6.0.1.img

I can't seem to find any reference to this or videos on how to make one by Googling it. Any help would be appreciated. Thank you.

I'm trying to run something like "Thexder" and I have the gsp and the 2mg files in the correct place according to the gsp file but I don't have that .img file that you mention.

Folly

@TRP

Just found the solution.

The package depends on libreadline-dev (GNU readline)
If installed on linux it will find the readline.h on your computer.
I manually compiled gsplus and this worked.

I checked also some gsplus forks.
This fork has updated the apt install <dependancies> in the readme.md :
https://github.com/daehahn/gsplus

Add these in the script on line 19 (/home/pi/RetroPie-Setup/scriptmodules/emulators/gsplus.sh) :

getDepends libsdl2-dev libsdl2-image-dev re2c libfreetype6-dev libpcap0.8-dev libreadline-dev

Try to install again.
It should work now.

If this works someone could do a pull request or send an issue on valerino's github.

ps. When you have it working , can you share some info here?
How to run images etc. or get Thexder to run. I am also new to gsplus.
(It boots but I don't know how to load things)

TPR

@folly Thanks. I don't have a script editor to tell me what line 19 is but in Wordpad I counted the lines and I added it here:

rp_module_flags=""

function depends_gsplus() {
getDepends libsdl2-dev libsdl2-image-dev re2c libfreetype6-dev libpcap0.8-dev libreadline-dev
}

function sources_gsplus() {
gitPullOrClone "$md_build" https://github.com/digarok/gsplus
}

Wish me luck!

TPR

This post is deleted!

TPR

@folly Yeah, I think Retropie-Setup really didn't like that and I'm still getting the same error...

TPR

@folly Can you post your version of gsplus.sh somewhere so I can try it?

Folly

EDIT : (22-12-2020) Problem has been solved now in the original fork of @valerino.

@tpr said in new scriptmodules (lr-vice-xvic, gsplus, proper lr-mess integration!):

@folly Can you post your version of gsplus.sh somewhere so I can try it?

I pushed the file to my github, so you can try.
Hope it works for you.

cd /home/pi/RetroPie-Setup/scriptmodules/emulators
wget --backups=1 https://raw.githubusercontent.com/FollyMaddy/RetroPie-Share/main/00-scriptmodules-00/emulators/gsplus.sh

(EDIT: fixed above line, now it will overwrite the gsplus.sh and make a backup of the old file)

or download this repository and extract the file :
https://github.com/FollyMaddy/RetroPie-Share

TPR

@folly I seem to still be getting an error using your version. Here's what my log file says:

= = = = = = = = = = = = = = = = = = = = =
Building 'gsplus' : Apple II/GS emulator v
= = = = = = = = = = = = = = = = = = = = =

-- The C compiler identification is GNU 8.3.0
-- The CXX compiler identification is GNU 8.3.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.29")
-- Check if the system is big endian
-- Searching 16 bit integer
-- Looking for sys/types.h
-- Looking for sys/types.h - found
-- Looking for stdint.h
-- Looking for stdint.h - found
-- Looking for stddef.h
-- Looking for stddef.h - found
-- Check size of unsigned short
-- Check size of unsigned short - done
-- Using unsigned short
-- Check if the system is big endian - little endian
-- Checking for module 'sdl2'
-- Found sdl2, version 2.0.10
-- Checking for module 'freetype2'
-- Found freetype2, version 22.1.16
-- Configuring done
-- Generating done
-- Build files have been written to: /home/pi/RetroPie-Setup/tmp/build/gsplus
Scanning dependencies of target x_readline
Scanning dependencies of target partls
Scanning dependencies of target to_pro
Scanning dependencies of target atbridge
[ 5%] Building C object bin/CMakeFiles/to_pro.dir/to_pro.c.o
[ 5%] Building C object bin/CMakeFiles/x_readline.dir/readline.c.o
[ 5%] Building C object bin/CMakeFiles/partls.dir/partls.c.o
[ 6%] Building C object bin/atbridge/CMakeFiles/atbridge.dir/aarp.c.o
/home/pi/RetroPie-Setup/tmp/build/gsplus/src/readline.c:90:10: fatal error: readline/readline.h: No such file or directory
#include <readline/readline.h>
^~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [bin/CMakeFiles/x_readline.dir/build.make:63: bin/CMakeFiles/x_readline.dir/readline.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:102: bin/CMakeFiles/x_readline.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 8%] Building C object bin/atbridge/CMakeFiles/atbridge.dir/atbridge.c.o
[ 10%] Linking C executable partls
[ 11%] Building C object bin/atbridge/CMakeFiles/atbridge.dir/elap.c.o
[ 13%] Building C object bin/atbridge/CMakeFiles/atbridge.dir/llap.c.o
[ 13%] Built target partls
[ 15%] Building C object bin/atbridge/CMakeFiles/atbridge.dir/pcap_delay.c.o
/home/pi/RetroPie-Setup/tmp/build/gsplus/src/to_pro.c: In function â€˜format_memdiskâ€™:
/home/pi/RetroPie-Setup/tmp/build/gsplus/src/to_pro.c:370:3: warning: â€˜strncpyâ€™ specified bound depends on the length of the source argument [-Wstringop-overflow=]
strncpy((char *)vol_hdr->vol_name, name, strlen(name));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ 16%] Building C object bin/atbridge/CMakeFiles/atbridge.dir/port.c.o
[ 18%] Linking C static library libatbridge.a
[ 18%] Built target atbridge
[ 20%] Linking C executable to_pro
[ 20%] Built target to_pro
make: *** [Makefile:84: all] Error 2
/home/pi/RetroPie-Setup/scriptmodules/emulators
Could not successfully build gsplus - Apple II/GS emulator v (/home/pi/RetroPie-Setup/tmp/build/gsplus/bin/GSplus not found).

Log ended at: Fri 11 Dec 18:46:43 GMT 2020
Total running time: 0 hours, 0 mins, 15 secs

Folly

EDIT : (22-12-2020) Problem has been solved now in the original fork of @valerino.

@tpr

Try to install the package manually.

sudo apt install libreadline-dev

Then try to reinstall gsplus again.

TPR

@folly Yay! That seemed to at least build without any errors. Thank you!

Now I just need to spend some time to see if I can get it running. Do you happen to know what BIOS files I need and what folders they go in?