new scriptmodules (lr-vice-xvic, gsplus, proper lr-mess integration!)

valerino

added MSX2, MSX2+, MSX2Turbo-R to lr-bluemsx.

Zering

@valerino said in new scriptmodules (lr-vice-xvic, gsplus, proper lr-mess integration!):

i suggest you all to update from my repo and reinstall all lr-mess scripts (or, if you prefer, do it messing with each generated emulators.cfg directly).

Sorry for asking what you guys are probably going to think is a noob question, but how do I do that?

valerino

@Zering uhm .... i assume you cloned my repo and replaced RetroPie-Setup.

so, simply

cd RetroPie-Setup
git pull

# then reinstall each of the lr-mess-blabla emulators, they will fix everything
~/RetroPie/retropie_setup.sh

or, alternatively you can do all in one shot (this will reconfigure all lr-mess-xxx it finds).

cd ~/RetroPie-Setup/scriptmodules/libretrocores
for s in lr-mess-*.sh; do sudo ~/RetroPie-Setup/retropie_packages.sh ${s%.*} configure; done

valerino

added lr-mess-m5.sh and lr-mess-gameduck.sh.

also fixed run_mess.sh to correctly support saving retroarch content directory overrides, and fixed a bug in lr-mess-ti994a.sh (need to be reinstalled). i added a note in the first post for whoever wants to add MESS systems using my scripts :)

Zering

@valerino said in new scriptmodules (lr-vice-xvic, gsplus, proper lr-mess integration!):

@Zering uhm .... i assume you cloned my repo and replaced RetroPie-Setup.

Thanks for that. But actually it's cloning your repo and replacing RetroPie-Script I don't know how to do. ^^

roslof

@valerino said in new scriptmodules (lr-vice-xvic, gsplus, proper lr-mess integration!):

added lr-mess-m5.sh and lr-mess-gameduck.sh.

also fixed run_mess.sh to correctly support saving retroarch content directory overrides, and fixed a bug in lr-mess-ti994a.sh (need to be reinstalled). i added a note in the first post for whoever wants to add MESS systems using my scripts :)

Understood (about location of %ROM%). Curious, what was the side-effect?

valerino

@roslof i need it to be the last parameter so i can extract the rom directory from it, which is needed to support saving content directory overrides. if not, i would have needed to add another parameter to run_mess.sh and change all scripts in turn.

valerino

@Zering make a backup of your original RetroPie-Setup, then in /home/pi:

git clone http://github.com/valerino/RetroPie-Setup

then follow my above post.

unfortunately, until all this is properly added to official retropie this is the easier way ..... i'm keeping my repo updated with the upstream repo, anyway, don't worry.

dmmarti

One thing I've noticed, your script creates 2 files in the /opt/retropie/configs/xxx folders being owned by user 'root'.

-rw-r--r-- 1 root root 106 Apr 27 20:44 custom-core-options.cfg
-rw-r--r-- 1 root root 76 Apr 27 20:44 retroarch.cfg.add

Is there a specific reason for this instead of having them be "pi:pi"?

If any updates are done within the Retroarch GUI (like mame_mouse_enable, etc), the changes are not saved since 'pi' does not own the file.

valerino

@dmmarti uhm no, you're right. gonna fix that in the next commit. thanks!

valerino

new systems:

lr-mess-supervision.sh (Watara Supervision)

updated cores:

lr-atari800 (added Atari XEGS)
lr-snes9x (added Sufami Turbo and Satellaview)

also fixed the bug reported by @dmmarti , you need to reinstall all scripts as specified here: https://retropie.org.uk/forum/post/217946 (hope it's the last time this is needed eheheh).

Zering

@valerino said in new scriptmodules (lr-vice-xvic, gsplus, proper lr-mess integration!):

@Zering make a backup of your original RetroPie-Setup, then in /home/pi:
git clone http://github.com/valerino/RetroPie-Setup

And I take it this writes over my current RetroPie setup? And replaces it with yours, essentially?

valerino

@Zering yep, make a backup copy if you want. or, you can take all the files you need from my repo but beware: you need to overwrite the original RetroPie-Setup/packages.sh and RetroPie-Setup/helpers.sh with mine.

in the end, it's really easier to just do as i said and clone mine directly until a better solution (=integrated in the official distro) is found.

Zering

I think I may hold off then, I've just completed a new, quite involved setup and I don't feel like going through all the motions again quite so soon if something does go wrong.
Thanks for taking the time to talk me through this though, I'll get around to it eventually and that will be very helpful. And I'll keep on the lookout for new modules, your work is amazing.

valerino

@Zering there's no reason things may go wrong, it's just a script, nothing gets overwritten of your pre-existing config files :)
but .... as you prefer! thanks!

valerino

uhm ... looking here: https://github.com/RetroPie/RetroPie-Setup/pull/3109 (my old pull request) seems there's no intention to integrate this is in the main repo.

so well, i'll continue with just my fork so. anyone who need it, is welcome to use my repo, i'll keep it updated with the main at least until i've completed the mess systems and minor fixes.

mitu

@valerino said in new scriptmodules (lr-vice-xvic, gsplus, proper lr-mess integration!):

uhm ... looking here: https://github.com/RetroPie/RetroPie-Setup/pull/3109 (my old pull request) seems there's no intention to integrate this is in the main repo.

I don't know why you got that impression, you're more than welcome to add something new to RetroPie. Any PR might receive correction, comments - you've received already quite a few.

valerino

@mitu indeed i replied to that PR. ok for lr-vice (that was just an experiment), but for lr-mess there's no other way to currently integrate it easily, my solution seems easy enough (fact) and without side effects.
probably yes, a separate menu without polluting the 'exp' section is needed. i'm working on it.

mitu

@valerino said in new scriptmodules (lr-vice-xvic, gsplus, proper lr-mess integration!):

lr-mess there's no other way to currently integrate it easily, my solution seems easy enough (fact) and without side effects.

What exactly is the issue with lr-mess ? Maybe there is an alternate solution.

valerino

@mitu ah, don't ask me :)

https://github.com/RetroPie/RetroPie-Setup/pull/3109#issuecomment-620490323

of course there will be other solutions. i proposed mine, implemented it and it seems enough stable, easy to add other systems, isolated each one, and safe to use. that's why i'm sharing it.