Input needed: ES theming improvements

lilbud

@Zigurana should I grab the fire extinguisher

robertybob

@lilbud Because he's on fire?

lilbud

No, probably attempting to compile it on the pi will cause it to be set ablaze.

Zigurana

@lilbud aww man that's harsh. I mean, releasing the magic pixie smoke, sure. But actual fire? Come on.

Rookervik

I couldn't get the windows build to run. Tried copying the files over an older, complete, version of ES and it still wouldn't run. It's missing a lot of DLLs.

fieldofcows

@Zigurana I've ported your commit to my local branch and built it for raspberry pi. It seems to work fine although I haven't done exhaustive testing yet.

I've noticed that the default logo size is different to the normal ES - if I don't include a <systemcarousel> tag then the carousel icons are smaller than the icons used in the stock ES:

Original

With carousel modification but no theme elements

I think it would probably be sensible to set the defaults to work exactly as the original carousel did to ensure existing themes work correctly.

I used your sample config and added 5 different system types and the carousel configuration seems to work nicely.

I'll give the code a review tomorrow and let you know my comments :) Looking good :D

Nismo

@fieldofcows Or there is some error there, or you have exactly the same amount of games in mame than nes...

fieldofcows

@Nismo said in Input needed: ES theming improvements:

@fieldofcows Or there is some error there, or you have exactly the same amount of games in mame than nes...

No bug. I only have mame games on my pi so I duplicated the mame gamelist for each system just to have something to test.

Zigurana

@Rookervik
<sigh> it just never ends... </sigh>
I'll build again tonight, but then release version. Maybe that will clear things up.

mediamogul

@Zigurana said in Input needed: ES theming improvements:

<sigh> it just never ends... </sigh>

alt text

Zigurana

Ok, Ive updated the archive, now based on the Release build, and tried it on another PC, so this time anyone with a windows machine should be able to try this out.

Get it here

If I remember well, this should also include a better default behaviour (closer to current ES).

For Rpi, you'll need to build this yourself atm, but that way you are sure to get the latest version!

Nismo

@Zigurana Has this fork video support?

Zigurana

@Nismo This was rebased dec 15th, with the RetroPie Master, so video is in.

But please note, this is not meant to be used in your 'production' setup, I supply this solely for testing.
I do not think this new feature impacts anything on the video snaps side, as it acts only on the systemView objects, not the gameListViews.

Once testing and straightening out of the code has taken place, I will create a PR, and once it is accepted into RetroPie/master, people will be able to use it proper.

Nismo

@Zigurana Thanks a lot, it's a nice commit, i'll try to find some time to test and comment here, I'm a little busy lately because the christmas.

Rookervik

@Zigurana Ok this version works. I will test it out some when I have a little more time.

Rookervik

I do not think video preview is working in this build of ES. I tried setting it up for 3 days and couldn't get it to work. I downloaded fieldofcow's ES and it worked right away.

I will test the carousel bar next.

Zigurana

@Rookervik / anyone else :
Did you manage to try out the theming of the carousel bar?
If there are no open bugs, I'll prepare a PR for this.

jdrassa

@Zigurana

I haven't had a chance to test your changes, but I did look over your code and had a couple of suggestions.

Make element names camel case. This would make it consistent with how the other elements are named.
Merge logosizex and logosizey into a single logoSize element. This is how size is specified everywhere else in the theme.

Here is an example of the theme with these changes.

 <systemcarousel name = "carousel">
    <yPos>0.80</yPos>
    <height>0.1</height>
    <color>f0f0f000</color>
    <infobarColor>90909060</infobarColor>
    <infobarFontPath>./art/font.ttf</infobarFontPath>
    <infobarFontSize>0.033</infobarFontSize>
    <infobarFontColor>ffffffff</infobarFontColor>
    <logoScale>1.2</logoscale>
    <logoSize>0.22 0.24</logoSize>
    <maxLogoCount>5</maxLogoCount>
</systemcarousel>

Also, I believe that you mentioned that you fixed the default sizes, but it doesn't look like that change made it into your branch on github.

It is all nitpicky, but I figured I would mention it. Great job though. Can't wait to see this change land.

Nismo

@Zigurana I like a lot the commit you did, and it's very nice to theming carousel bar, it was something that I always thinking that must be themable, i'm glad with you for this commit, but unfortunately i need to compile it for windows to test it, because I don't have money to buy a Rpi, and I'm very busy with other things, I don't have time to do tests or try to compile it for windows.

Anyway I'm here for helping the forum and contribute with everything I can, so if I can help you on anything else, please tell me, I'll be glad to help you.

I hope you understand me welll, sorry for my poor english.

Regards mate.

mattrixk

@Nismo there is a pre-compiled version here (you can find it a bit further up this thread). I haven't had the chance to test it yet as I'm on mobile, but Rook said it works.