PICO-8: Retroarch lr-retro8 core installation script
-
@benmclean said in PICO-8: Retroarch lr-retro8 core installation script:
@folly Wow, that looks great! I say let's go with it. :D
What would be the next steps?
It should also have that controller.svg .
As the carbon theme is the default it should certainly be added to that theme.
You have to make a fork of :
https://github.com/RetroPie/es-theme-carbon
Then add your theme and do a pull request so it can be added.I have learned now that they want everything in one commit.
Before doing a pull request ask Mitu or Buzz if the commit is enough otherwise you get tangled in pull request without knowing what to do next.
Read this and you know what I mean :
https://github.com/RetroPie/RetroPie-Setup/pull/3400 -
@folly it's pretty standard for projects wanting changes grouped into single commits, but squashing commits is a 1 minute job in the command line once you know how. i know it's a pain but i encourage you to learn git on the command line: https://git-scm.com/docs/gittutorial - it's a useful skill these days!
-
@dankcushions said in PICO-8: Retroarch lr-retro8 core installation script:
@folly it's pretty standard for projects wanting changes grouped into single commits, but squashing commits is a 1 minute job in the command line once you know how. i know it's a pain but i encourage you to learn git on the command line: https://git-scm.com/docs/gittutorial - it's a useful skill these days!
If I get a good or at least reasonable pull request put in for adding pico8 to Carbon, will it take months or years to be merged in? I see other PRs sitting there a long time.
-
@dankcushions said in PICO-8: Retroarch lr-retro8 core installation script:
@folly it's pretty standard for projects wanting changes grouped into single commits, but squashing commits is a 1 minute job in the command line once you know how. i know it's a pain but i encourage you to learn git on the command line: https://git-scm.com/docs/gittutorial - it's a useful skill these days!
Well it seems I did manage the squashing part, but the pushing part did't work
Thanks for giving me the link, I will look into it deeper.
Hopefully I will get the picture ;-) -
@benmclean said in PICO-8: Retroarch lr-retro8 core installation script:
@dankcushions said in PICO-8: Retroarch lr-retro8 core installation script:
@folly it's pretty standard for projects wanting changes grouped into single commits, but squashing commits is a 1 minute job in the command line once you know how. i know it's a pain but i encourage you to learn git on the command line: https://git-scm.com/docs/gittutorial - it's a useful skill these days!
If I get a good or at least reasonable pull request put in for adding pico8 to Carbon, will it take months or years to be merged in? I see other PRs sitting there a long time.
Please, do continue, otherwise we don't get any further and that would be a shame as we are almost there.
I think the pico-8 will be accepted much sooner than other systems. -
@folly said in PICO-8: Retroarch lr-retro8 core installation script:
@dankcushions said in PICO-8: Retroarch lr-retro8 core installation script:
@folly it's pretty standard for projects wanting changes grouped into single commits, but squashing commits is a 1 minute job in the command line once you know how. i know it's a pain but i encourage you to learn git on the command line: https://git-scm.com/docs/gittutorial - it's a useful skill these days!
Well it seems I did manage the squashing part, but the pushing part did't work
Thanks for giving me the link, I will look into it deeper.
Hopefully I will get the picture ;-)You have to force push like a Jedi in order to rewrite history like that.
-
This is what happens when I try to load emulationstation on Windows.
So I guess something about how the Windows version draws SVGs is messed up.
-
Can you share your controller.svg ?
Let me see how it looks on Linux. -
@folly said in PICO-8: Retroarch lr-retro8 core installation script:
Can you share your controller.svg ?
Let me see how it looks on Linux.I tried it on RetroPie and it looks correct on there. Just not on Windows. Weird.
-
Not sure what the problem is.
I had a look at the system.svg .
I can pop out all objects so it seems to be a pure .svg .
Nevertheless vector images and inkscape can be a pain.Are the other systems looking good on windows ?
-
@folly said in PICO-8: Retroarch lr-retro8 core installation script:
Not sure what the problem is.
I had a look at the system.svg .
I can pop out all objects so it seems to be a pure .svg .
Nevertheless vector images and inkscape can be a pain.Are the other systems looking good on windows ?
The Windows version I set up only had SEGA Genesis and Super Mario War which looked OK.
-
@benmclean are you running retropie on windows or is it just emulationstation ?
-
@unknown said in PICO-8: Retroarch lr-retro8 core installation script:
@benmclean are you running retropie on windows or is it just emulationstation ?
It was just the emulationstation portable build for Windows provided in the tutorial of how to make your own themes.
-
The hold-up at this point is the controller.svg. I'm going to try a few different things to decide what looks best before submitting the PR.
I might also want to do TIC-80 and LowRes NX soon-ish.
-
@benmclean lr-tic80 has now been merged to Retropie-Setup so having a TIC-80 icon would be great! TIC-80 already has icons in the Cygnus Blue Flames theme, so it'd be good to have on Carbon as well.
-
PICO-8 has been merged too ;-)
@dmmarti can you add this information in your first post ?
Lowres-nx should be the next one.
-
I'll try to get to this soon!
-
-
Some quick notes: I got in touch with the LowRes NX guy via email to get his vector artwork and also have discovered that TIC-80 uses this font.
-
Cool !
Contributions to the project are always appreciated, so if you would like to support us with a donation you can do so here.
Hosting provided by Mythic-Beasts. See the Hosting Information page for more information.