[solved] Skyscraper usage script doesn't work after package update

[sleve_mcdichael]

Using Skyscraper v3.8.1.2309, with the current scriptmodule version (after update setup-script but before update Skyscraper) works fine.

After update Skyscraper to 3.9.0 (and still in 3.9.1), attempt to gather data or generate gamelist using scriptmodule returns error:

The version of Skyscraper you currently have installed is incompatible with options used by this script. Please update Skyscraper to the latest version to continue.

This is confusing to me because the command used by function _get_ver still seems to return the expected value 3.9.0:

$ Skyscraper -h | grep 'Running Skyscraper' | cut -d' ' -f 3 | tr -d v 2>/dev/null
3.9.0

...so I'm not sure why this isn't passing the check in function _check_ver for 3.5 or greater.

After revert to Skyscraper 3.8.1.2309, gather data works again:

$ Skyscraper -h | grep 'Running Skyscraper' | cut -d' ' -f 3 | tr -d v 2>/dev/null
3.8.1.2309

[mitu]

It's because the _get_ver_skyscraper function is busted. Looks like the new version errors out even with --version if the user running it doesn't have the configuration files in $HOME/.skyscraper.

[sleve_mcdichael]

@mitu said in Skyscraper usage script doesn't work after package update:

if the user running it doesn't have the configuration files in $HOME/.skyscraper.

...but I do have the config files
Ahh, but that's not "me," it's run as root.

So then, https://github.com/RetroPie/RetroPie-Setup/pull/3793 seems to fix it. Does that look right?

[mitu]

@sleve_mcdichael said in [solved] Skyscraper usage script doesn't work after package update:

So then, https://github.com/RetroPie/RetroPie-Setup/pull/3793 seems to fix it.

Indeed. Thank you for the fix.

[Lolonois]

Thank you both for catching and fixing this. It escaped me.