New ES Feature: Random Collection - Testers and Theme makers needed

mrmadcatz

Any advice on how to add an icon for a theme like snes-mini? I can't figure out how to add one for an automated collection. I forked the original repo and was going to work on adding an icon, but I'm not sure where to put it or how to implement it.

Actually, I think I've figured out how to add an icon to the es-theme-snes-mini theme. What would be the best way to submit this? I know ruckage no longer seems to be active with this theme, so a PR of my fork to the original repo may not be the best here.

pjft

@mrmadcatz Hm. You may submit a PR to the original repo, but certainly feel free to commit it to your fork, if you'd like to maintain it.

mrmadcatz

@pjft Will do. Here is the icon I came up with. It's as close to the "theme" as I could get, but I think I did alright:

This is an alternate:

And one more:

pjft

@mrmadcatz Wow, this looks cool! Thanks for putting it together :)

mrmadcatz

@pjft Okay, these are the finals that I landed on. I think I imitated the actual icons & logos in the original with 99% accuracy.
for art/icons and art/icons_usa:

and for art/nes_icons and art/nes_icons_usa:

I also updated the various folders in the backgrounds folder to ensure that however the user has their theme configured via the config.xml used to customize the theme, a corresponding background will be present.

I created a pull request to the original ruckage/es-theme-snes-mini upstream repo. Not sure if it'll get accepted, but here's to hoping. Otherwise, I can share my personal Fork of the repo with you that has these icons in it if you'd like (or if you can direct me where to submit them for RetroPie in general, it would be much appreciated).

Either way, cheers and thanks for the awesome new auto-collection.

pjft

@mrmadcatz Thanks! I don't know know the exact process to submit a new theme to be included on RetroPie.

@mitu is there a process to get a theme added to esthemes? Couldn't find much in the Themes docs.

mitu

@pjft said in New ES Feature: Random Collection - Testers and Theme makers needed:

@mitu is there a process to get a theme added to esthemes? Couldn't find much in the Themes docs.

Yes, it's a PR to add a line to the esthemes module, like this.

In this case though, @ruckage's theme readme asks for not redistributing modifications of their theme, so I'll ty to respect that and maybe not approve any forks to be included. However, if you can add it just as a patch/diff to the existing theme, (like this), then I'm ok with it.

EDIT: fixed the PR example link.

pjft

@mitu of course! Thanks for the context and guidance.

mrmadcatz

@pjft @mitu Thank you both! Anything needed from me for this?

mitu

@mrmadcatz for now, can you post a link to https://retropie.org.uk/forum/topic/8391 or (again) the image, just for reference ? Thank you.

mrmadcatz

@mitu @pjft
Here is the reply on the post as requested by mitu.

I submitted a PR for my fork to ruckage's upstream repo, but doubt I'll hear back. Otherwise, here are the rest of the images I added. I created, copied and renamed background files in each necessary directory to go along with these:

background/bg_tron/auto-random.png

background/bg_tron_blur/auto-random.png

background/bg_tron_blur_usa/auto-random.png

background/bg_tron_usa/auto-random.png

background/blurred_shots/auto-random.png

background/nes_mini/auto-random.png

pjft

@mrmadcatz Cool - thank you! These look great :)

mrmadcatz

@mitu @pjft Sorry to have posted these so many times, but this is the last update (I felt I could get the icons even closer to the style of ruckage's originals, and believe that I have). I will update the other thread as well. Here are ALL of the assets I've adjusted for the ruckage/es-theme-snesn-mini theme for RetroPie. This includes backgrounds, labels and icons for the auto-random list that goes with all the different configurations of this theme that are available by editing config.xml that comes with the theme. They are as follows:

Icons
es-theme-snes-mini/art/icons and es-theme-snes-mini/art/icons_usa

es-theme-snes-mini/art/nes_icons and es-theme-snes-mini/art/nes_icons_usa

Logos
es-theme-snes-mini/art/logos and es-theme-snes-mini/art/logos_usa

Backgrounds
es-theme-snes-mini/background/bg_tron/auto-random.png

es-theme-snes-mini/background/bg_tron_blur/auto-random.png

es-theme-snes-mini/background/bg_tron_blur_usa/auto-random.png

es-theme-snes-mini/background/bg_tron_usa/auto-random.png

es-theme-snes-mini/background/blurred_shots/auto-random.png

es-theme-snes-mini/background/nes_mini/auto-random.png

3Draco

@pjft
Today I had time to make a copy of the system and test your new function. So far everything is going well and I think the settings you can make are great! thank you for the fantastic work!

pjft

@3Draco Why, thank you for the feedback. Glad you find it helpful and fun!

3Draco

Just for your Information ->Updated the Random for the New Comic Book Theme!

[https://retropie.org.uk/forum/post/294674]

pjft

@3Draco Thank you!

mingaldrichgan

I submitted a PR for RetroHursty69's Supersweet theme.