new pull request retropie-setup

phillip_benoit

I added NAOMI and Atomiswave support to the available platforms.

platforms.cfg can now be tagged with all attributes that are relevant in es_systems.cfg (added support for cmd and path)

https://github.com/RetroPie/RetroPie-Setup/pull/3926

BuZz

@phillip_benoit thank you.

txop_planet

@phillip_benoit It is very useful, thank you.

phillip_benoit

@txop_planet unfortunately, I had to roll back most of my changes. Once I get NAOMI in, I can work on putting them back.
https://github.com/RetroPie/RetroPie-Setup/pull/3928

phillip_benoit

@phillip_benoit My pull request is waiting in limbo still. It looks like no one wants to fix all the problems with the folder / emulator assignments.

ExarKunIv

@phillip_benoit it takes time for them to accept a pull request. I have a pull request open for months and it's still pending

They get to it when they do. Sorry don't have a better reason

phillip_benoit

@ExarKunIv From the looks of things, the PR requests just stack up and they're ignored. Are you sure anyone is even looking at them?

sleve_mcdichael

@phillip_benoit said in new pull request retropie-setup:

PR requests just stack up and they're ignored. Are you sure anyone is even looking at them?

There are many more closed PR's, than open ones. I suppose the unsolicited requests from forum goers like ourselves are given less priority than what the devs have identified as issues that currently need attention, but yes, someone is still looking at them. For example cmitu looked at this one and commented that it probably wasn't necessary to include NAOMI as a separate system.

ExarKunIv

@phillip_benoit said in new pull request retropie-setup:

Are you sure anyone is even looking at them?

Yes they are. Both of them have chimed in on my PR and had me fix a few things.

phillip_benoit

@sleve_mcdichael it is necessary. That's the problem. If a gatekeeper who is just going to stand in the way is the only person then nothing is ever going to get fixed. I guess that explains why things have gone down hill.

The closed requests are the same people over and over. Like they're only approving requests for themselves and ignoring everyone else.

retropieuser555

edit: Looking at your pull request you just need to squash and merge? Nobody is saying it's not a good idea to have NAOMI as a system on Retropie? You should be able to do that from desktop app (https://docs.github.com/en/desktop/managing-commits/squashing-commits-in-github-desktop) or from the web browsers.

But yeah, please do that, as it's useful splitting up dreamcast and Naomi and it's something I always do manually anyway when setting up RetroPie

Protocultor

@phillip_benoit I've been doing PRs to a respectable number of open source projects for a few years now, and from all of them, only one of the projects has consistently reviewed my PRs in under 3 weeks. If the project is popular and is handled by few people, you should be accustomed for them to take several months to look at your PR.
I would rate RetroPie as one of the most decent projects I've contributed to, in terms of pull requests accepted and time taken to evaluate them, especially considering the small number of people working on it.
My point is: you can change projects, but it's no guarantee that you won't be ignored on the other side as well. "Occupational hazards" I guess.