RetroPie version check

[ExarKunIv]

so we are working on a way to have the install script for Retropie extras to check what version of Retropie is running, since are are trying to keep the scripts inline with the changes that are being made in the main Retropie. if they are running a old Retropie then the scripts would not work

we tried

if ! git log --format=format:%H | grep 18c2b43000ec54d74ba016e0b8de654122377dba; then
        echo -e "Error: Your RetroPie-Setup directory is too old

this did work for me, but others even through their system showed 4.8.9 it would not work and they would get the warning

how do i go about having it look at the version number in the retropie_setup.sh
i cant seem to wrap my head around how to have it check that

[mitu]

Version is stored in /opt/retropie/VERSION, why not check there ?
Don't check the git log for a specific commit, since the user may do a shallow clone (git --depth 1) and that commit will be missing in this case.

[ExarKunIv]

@mitu said in RetroPie version check:

Don't check the git log

yes i did find that out, as it did work in testing. its not a sure thing

@mitu said in RetroPie version check:

/opt/retropie/VERSION,

we will use that. now to figure out the programming part, lol

[mitu]

@ExarKunIv said in RetroPie version check:

we will use that. now to figure out the programming part, lol

RetroPie already keeps the version in $__version, see here how it's printed in RetroPie-Setup. I think you don't even need to read the VERSION file when your script is executed from RetroPie-Setup.

[ExarKunIv]

@mitu said in RetroPie version check:

executed from RetroPie-Setup

unfortunately its not. you have to run it from command line and pick the scripts that are then installed to the ext folder

i would like for a way to run the installer from the Retropie-setup. i just have not messed with it yet
but good to know once i do figure that out.

for now i think looking at the version file might be the way to go.