Configuring <CODE_NOT> Control Mapping in lr-MAME2003?

caver01

@dankcushions I don't think this is a fiddly thing related to sensitivity etc. I think it must be how I am configured in some way.

Just so we can compare apples to apples:
When I first setup my RetroPie image (3.6 image) I setup my configuration in Emulation Station using my arcade buttons (via IPAC4). Of course, ES saw this as a keyboard. Everything went fine.

I have all of my buttons setup in configs/all/retroarch.cfg so that all four players are mapped to joystick directions and buttons like so:

input_player1_a = alt
input_player1_b = ctrl
input_player1_y = shift
input_player1_x = space
input_player1_start = num1
input_player1_select = num5
input_player1_l = z
input_player1_r = x
input_player1_left = left
input_player1_right = right
input_player1_up = up
input_player1_down = down

and so on with players 2,3,4.

No other input configs apply in configs/arcade/retroarch.cfg (nor mame-libretro).

If I launch Vindicators with lr-mame2003, press TAB on my external keyboard, then configure inputs (this game), then arrow down to "P1 Left/Up".
ENTER
press UP, Left, Left in sequence, wait a moment for it to save, I get this written in the box:

UP RetroPad1 Up LEFT RetroPad1 Left LEFT RetroPad1 Left

Which is a bummer. No "not LEFT" like I would expect. What do you get when you do it?

This "UP RetroPad1 Up" reads as though everything is a double-entry on my end. Like it can't do a NOT because it is detecting both a LEFT and a RetroPad Left at the same time.

Ideas?

dankcushions

@caver01 ok that makes sense - what I think is happening is that mame2003 handles keyboard and joystick/gampad presses independently. eg, you can bind your keyboard's LEFT ARROW to RetroPad1 Left (within retroarch global configs), but when you press it in mame2003 it will read both the keyboard LEFT ARROW press, AND RetroPad1 Left in the same input poll. this appears to be messing with the CODE_NOT stuff.

i can see some code related to this in https://github.com/libretro/mame2003-libretro/blob/dfea13cbb7a3ece51e84e8e02b87a486ab181beb/src/input.c so i will try and find a way to ignore duplicate presses somehow.

Riverstorm

@caver01 said in Configuring <CODE_NOT> Control Mapping in lr-MAME2003?:

If I launch Vindicators with lr-mame2003, press TAB on my external keyboard, then configure inputs (this game), then arrow down to "P1 Left/Up".
ENTER
press UP, Left, Left in sequence, wait a moment for it to save, I get this written in the box:

UP RetroPad1 Up LEFT RetroPad1 Left LEFT RetroPad1 Left

Which is a bummer. No "not LEFT" like I would expect. What do you get when you do it?

This "UP RetroPad1 Up" reads as though everything is a double-entry on my end. Like it can't do a NOT because it is detecting both a LEFT and a RetroPad Left at the same time.

Ideas?

I have an IPAC 2 which I can test tonight which would be similar.

If I remember right the way MAME works is you would press Enter, Up and let it register. Then without leaving the line (if you leave the line with an up/down arrow and go back it will start over erasing everything). Then press Enter, Left, Left and it will register the NOT Left. Which would be up-but-not-left. If that's what you're trying to do?

What I usually do is like for player 1 coin in on a XBOX controller is press Enter, Keyboard 1 and let it register. Then press Enter, Joystick 1 Select and let it register. That way I can use my IPAC/Keyboard button 1 for coin in and also Joystick 1 Select on the controller. I can basically use keyboard or joystick.

For player 2 I press Enter, Keyboard 2, let it register. Then Enter, Joystick 2 Select, let it register. Then Enter, Joystick 1 Select+Joystick Left, let it register. What this does is allows me to use the IPAC/keyboard button 2 for coin in for player 2, joystick 2 Select for coin in and also joystick 1 Select+joystick left.

Basically it allows player 2 to fully use their joystick but also I can add coins from joystick 1 too. For player 3 it's Keyboard 3 & Joystick 3 Select & Joystick 1 Select+Down and for player 4 it's Keyboard 4 & Joystick 4 Select & Joystick 1 Select+Right.

I repeat the same process with Start, Start+Left, Start+Down, Start+Right for players 1-4 start. That way when playing games like Gauntlet in addition to their own controllers working I can also start and add coins from joystick 1. Joystick 1 is kind of like the master joystick in a sense.

caver01

@Riverstorm What you are describing is how MAME does <CODE_OR> mapping. Waiting for it to register, then, without leaving the line, hitting enter and doing another keymap will <OR> them together (either one will register the input). I can't get it to recognize an intentional double-tap under any circumstance--only the ones done in error, and I can't tell what causes that (I suspect a flakey microswitch).

The thing is, I can do these mappings just fine in AdvanceMAME, so it's not like I am inept with this process.

Hearing your success with this makes me think I have something going on with my configuration. By that, I mean, something could be amiss with my base retroarch.cfg. I shouldn't be seeing "LEFT RetroPad Left" when I map to the left arrow on a keyboard. That just reads like two separate inputs. It makes sense that it won't allow me to do a <CODE_NOT> because it thinks I am pressing two keys at once (the raw keyboard key and the RetroPad virtual).

It makes me wonder what might happen if I try mapping all of my player controls to "nul" in retroarch.cfg. MAME should then just see the raw keyboard inputs. But I am curious how your IPAC is setup.

One thing I will say is that I haven't been getting double inputs. Dropping a coin, for example, doesn't give me two credits.

Riverstorm

@caver01 said in Configuring <CODE_NOT> Control Mapping in lr-MAME2003?:

But I am curious how your IPAC is setup.

No I never thought you to be inept at all. If there's any files or information I can pass along just let me know. I will test it out tonight. I have a Pi but not the IPAC with me as it's in the case. :)

caver01

@Riverstorm Tests with an external keyboard interest me. Thinking this through, I suspect anyone who uses handheld controllers and hooks up a USB keyboard to do this test does NOT have the keyboard setup in retroarch.cfg (lines with inputs mapped to keyboard keys). Maybe I am wrong, but I am still thinking mame2003 is recognizing both the virtual retropad and the raw key being pressed, as revealed by the resulting line displayed (compare mine to @dankcushions notes).

caver01

@dankcushions @Riverstorm Ok, PROGRESS HAS BEEN MADE! Yippee!

Here's what I discovered:

If I remove all of my player input bindings from retroarch.cfg, I can do some <CODE_NOT> bindings in MAME2003 GUI. However, it fails when I try to map the Player1 joystick and buttons. For those, it is still recognizing double-inputs. For example, LEFT on the player 1 joystick (which the IPAC sends as the left arrow key) is coming in as LEFT RetroPad1 Left. Whereas, outside of Player one controls, keys come as they are. For example, LEFT on the Player 2 joystick registers as d and has none of this RetroPad2 Left virtual input attached.

If I re-edit retroarch.cfg and force-bind all of my Player1 inputs to "nul" I can do <CODE_NOT> bindings in MAME2003 GUI and even regular bindings show up as only the key inputs (i.e. pushing LEFT on the P1 joystick binds in the GUI as LEFT and doesn't include the virtual RetroPad Left.

So, here are my initial conclusions about what is going on:

RetroArch sends the virtual inputs (via RetroPads) to MAME2003, as it should, but when the RetroPads happen to be KEYBOARD keys, MAME2003 "hears" both the RetroPad input and the raw key input. This is why TAB works, even though I don't have it bound anywhere in retroarch.cfg. It's also why the inputs I DO have setup in retroarch.cfg show up as both the raw key and the RetroPad input TOGETHER which prevents issuing a <CODE_NOT> (because it is already capturing a <CODE_AND>. Finally, it explains why folks who use handheld controllers don't have this problem. Their virtual inputs aren't raw keypresses, so MAME only sees the RetroPad.
Even if I remove the Player1 bindings in retroarch.cfg, MAME still sees a RetroPad on Player 1 controls. I am thinking there's some kind of EmulationStation-to-RetroArch thing happening here where the initial setup in ES is automatically configured in the cores. The only recourse is to force-bind "nul" to the same.

So. . . I think I have uncovered a bit of a mess. MAME should not be allowed to see both the RAW input and the virtual one at the same time IF THEY ARE BOTH THE SAME RAW KEY. I don't know how one would correct for this programatically. Maybe it has been dealt with in other cores. The only folks affected are those of us who use keyboard controllers as these create raw inputs that MAME sees by default.

We don't want to block the RAW keyboard inputs since not everything has an equivalent input on the RetroArch side. I could just bind everything to "nul" but this seems messy. Moreover, how would I handle that configuration when I want to keep the bindings for FBA (it looks like the lr-mame2003 uses the retroarch.cfg in the Arcade folder--what about FBA?) Does anyone know about a way to BLOCK the Virtual RetroPad inputs for one emulator core? That would be preferred approach.

dankcushions

@caver01 nice job! sounds like my theory earlier was right.

Does anyone know about a way to BLOCK the Virtual RetroPad inputs for one emulator core? That would be preferred approach.

my plan before was to block the raw keyboard inputs IF they match the RetroPad inputs. i need to break through the code i linked to earlier to see if that's viable.. maybe this could be logged as an issue against lr-mame2003?

caver01

@dankcushions Yes. That would do the trick! Sorry, I completely missed your reply, but your interpretation is proving to be correct. And, because two inputs are detected, the double-taps are ignored--each attempt looks like two buttons pressed simultaneously.

Would you like me to try to post the issue against lr-mame2003? I've never done that.

dankcushions

@caver01 please do! it's https://github.com/libretro/mame2003-libretro/issues - you could link to this thread if you don't want to repeat your findings there. i'll have a play over the weekend hopefully

caver01

In the mean time, I can't really tell if the current state is having an affect on gameplay. I suspect it creates unnecessary overhead--with every input generated the emulator process simultaneous inputs--but I don't get a sense that there is a timing issue or delay.But now that I know what is happening, I tried a workaround on a single ROM using a per-rom config vindictr.zip.cfg where I force-bind every input represented configs/all/retroarch.cfg to "nul". This, temporarily, at least, lets me build single joystick "tank stick" configurations with the <CODE_NOT> key maps described in the original post. Lo and behold. . .I can play Vindicators with lr-mame2003 in all of its CRT-PI shader glory!

I consider this workaround temporary, as it will become unnecessary if double-inputs gets resolved the way you describe.

caver01

@dankcushions Issue added.

Riverstorm

@caver01 @dankcushions

It looks like the same here. I have an IPAC 2 and my global retroarch.cfg configured exactly as you do which looks like the MAME defaults using the A&B swap?

input_player1_a = alt
input_player1_b = ctrl
input_player1_y = shift
input_player1_x = space
input_player1_start = num1
input_player1_select = num5
input_player1_l = z
input_player1_r = x
input_player1_left = left
input_player1_right = right
input_player1_up = up
input_player1_down = down

Input lr-mame2003 (Keyboard):
"Up Arrow - Right Arrow - Right Arrow"

Output:
UP Retropad1 Up RIGHT RetroPad1 Right RIGHT RetroPad1 Right

Input lr-mame2003 (IPAC 2):
"Up Arrow - Right Arrow - Right Arrow"

Output:
UP Retropad1 Up RIGHT RetroPad1 Right RIGHT RetroPad1 Right

Input lr-mame2003 (XBOX 360 Joystick):
"Up Arrow - Right Arrow - Right Arrow"

Output:
RetroPad3 Up not RetroPad3 Right

If you break it down it looks like it's not recording the NOT but sees it as 6 keys pressed when in actuality only 3 were used whereas the joystick combines them as a NOT.

Is there two issues here? One being the double output (RAW and virtual) and other being not combining NOT statements?

Keyboard & IPAC:

UP
Retropad1 Up
RIGHT
RetroPad1 Right
RIGHT
RetroPad1 Right

Joystick:

RetroPad3 Up
not RetroPad3 Right

caver01

@Riverstorm said in Configuring <CODE_NOT> Control Mapping in lr-MAME2003?:

Input lr-mame2003 (Keyboard):
"Up Arrow - Right Arrow - Right Arrow"

Output:
UP Retropad1 Up RIGHT RetroPad1 Right RIGHT RetroPad1 Right

If you break it down it looks like it's not recording the NOT but see it as 3 key-presses for that one action whereas the joystick combines them as a NOT.

I would contend that it's actually seeing six (6) keypresses not three (3):

UP (raw)
RetroPad1 Up (virtual)
RIGHT (raw)
RetroPad1 Right (virtual)
RIGHT (raw)
RetroPad1 Right (virtual)

which are all <AND>ed together. Also, because they come in pairs (raw+virtual at the same time) it prevents <CODE_NOT> from working--already seeing two different inputs not the same one in succession.

Riverstorm

@caver01 said in Configuring <CODE_NOT> Control Mapping in lr-MAME2003?:

I would contend that it's actually seeing six (6) keypresses not three (3):

You beat me to it! ;) I revised my post after reading the issue.

Riverstorm

@caver01 said in Configuring <CODE_NOT> Control Mapping in lr-MAME2003?:

which are all <AND>ed together. Also, because they come in pairs (raw+virtual at the same time) it prevents <CODE_NOT> from working--already seeing two different inputs not the same one in succession.

Right, would it be considered two issues going on or do you think correcting one will fix both? It also exhibits the same behavior when pressing buttons too such as CTRL, ALT, etc.

caver01

@Riverstorm I think this is a single problem with the core implementation.

The fact that we can block the RetroPad inputs with "nul" bindings allowing MAME to just receive raw double keypresses that it correctly interprets as <CODE_NOT>, combined with the fact that non-keyboard inputs (RetroPads defined by joypads/handheld controllers) are also able to generate <CODE_NOT> mapping makes me think that MAME is behaving exactly like it should. It's the Libretro implementation of inputs that seems to be the problem. It's uniquely affecting KEYBOARD input since that is the only way a RAW input gets to the emulator outside of the RetroPads.

The most desirable fix would be the one @dankcushions suggests--filter out the RAW inputs if they match an existing key mapped in RetroArch. I hope the most practical way to fix it isn't an "all or nothing" proposition. In other words, I'd hate shut off RAW inputs completely, as we would lose the ability to press tab and bring up the MAME GUI (which is needed to define <CODE_NOT> in the first place!).

I'd like to check other LR-emulators to see if they behave the same way. For instance, I haven't checked, but I wonder if lr-mame2010 does the same thing.

Riverstorm

@caver01 said in Configuring <CODE_NOT> Control Mapping in lr-MAME2003?:

makes me think that MAME is behaving exactly like it should. It's the Libretro implementation of inputs that seems to be the problem. It's uniquely affecting KEYBOARD input since that is the only way a RAW input gets to the emulator outside of the RetroPads.

I don't know if it helps but I did test mame4all-pi and it does work as it should with both keyboard and joystick so that does make sense that it's the Libretro core.

caver01

@Riverstorm Yeah, I think we are only dealing with a RetroArch/Libretro core issue here.

I tested lr-mame2010 and I could create <CODE_NOT> mappings in the MAME GUI whether I have P1 controls mapped in retroarch.cfg or bound to "nul". It works both ways. However, I cannot map ANYTHING in 2010 besides Player1 inputs (in both cases). I don't know if that's an issue with 2010 or what (I don't use it), but I could not setup coins, start, or any joystick/buttons from other player locations on my control panel.

Still, there may be something to learn from how inputs are captured in lr-mame2010. I don't see double entries like I do in 2003. Instead, a key mapped in the GUI to Player 1 left, for example, shows up as Kbd P1 JoyL
I am not sure what the logic is there, but it doesn't read like two inputs captured, and it does pickup the AND, OR and NOT mapping just fine, so something inside there is working like it should.

caver01

An interesting observation worth mentioning here is that while it took a complete set of "nul" bindings in lr-mame2003 to setup Vindicators (using <CODE_NOT> mappings for RAW keyboard inputs), once MAME has the inputs mapped for the game, you can remove the custom retroarch.cfg (vindictr.zip.cfg). It was only needed to do the mapping. The game plays fine because it is configured to only watch for the RAW inputs. When the regular RetroArch bindings are restored, the game still works. This is further evidence that the keyboard inputs are sending both RAW and RetroPad to MAME.