Deleting last rom from GUI quits ES to terminal

daeks

Pi Model: 3 B
RetroPie Version Used: latest
Built From:Pre made SD Image on RetroPie website
USB Devices connected: -
Controller used: NES30 Pro
Error messages received: -
Log found in /dev/shm/runcommand.log (if relevant): -
How to replicate the problem:

Put 1 rom into one game folder, restart ES to have it displayed in ES
Press select and Use "Edit Metadata"
Select the "delete" option
ES quits if it is the last rom and Pi is on a terminal session -> unable to proceed with controller

Zigurana

So, once you've deleted all available items for a system, there is nothing more to show. In effect the system becomes invalid, and ES chokes on that.

What would you expect as a reasonable behavior?

Lyle_JP

@Zigurana A reasonable behavior would be that the System (emulator type) disappear as the last rom is deleted. Not a crash.

daeks

@Zigurana I would expect that ES goes back to the main menu.

markyh444

I genuinely don't see how this is a fault. Just don't delete the metadata of the last ROM. I agree that it probably shouldn't crash, but in the same way who needs to remove metadata like this anyway?

daeks

@markyh444 the question can be also answered very easily: it deletes the rom as well.
If I am playing/trying some games and recognizing a faulty one (or i dont like it or it exists twice by mistake), I just delete it quickly with that method. Esp. if you are not connected by wifi or dont have access to the share right now.

Zigurana

@daeks & @Lyle_JP : I get what you are saying, of course the system should not crash.
The behavior you describe - returning to system overview and removing the empty system from the list - seems reasonable to me as well.
Thus far, this not implemented. There is not even a way for ES to return to the system overview (which is why it crashes).

What would be necessary is to trigger a complete rebuild of the systemlists (and corresponding re-parsing of available games), just as happens upon initial startup.

I've been struggling with very similar behavior for the kids/favorites branch, where one can easily remove all favorites from a favorite-only list, resulting in an invalid system.

markyh444

@daeks Sorry, I misunderstood and wasn't aware that was how you were using it. I have never managed it like this, hence why I didn't see it as an issue. I always have access to the shares and this is how I manage the Pi or I drop into a prompt or SSH to the device.