Updated EmulationStation for Windows
-
@f-caruso Sorry, I did not hit the pull request button. hahahaha
You will tell me if it has been possible
-
@jero I merged your translation file. Had to move the po file in the good folder....
@LiveFreeDead, @jero I managed to automate build on appveyor like jrassa does.
You can download my latest changes as my development progresses on Github Release page. (not in my full pack which I have to update manually) -
@hhromic said in Updated EmulationStation for Windows:
If @f-caruso 's fork does build and work fine on RPI devices, perhaps a good idea to integrate it (for now) could be to create a scriptmodule for it alongside the stock EmulationStation shipped with RetroPie. Similar to
mehstationandpegasus-fefor example. So users can have an option to install let's sayemulationstation-fcamodsimilarly to what they can do with the existingemulationstation-dev. In other words, just another flavour of EmulationStation.And because @f-caruso 's fork is still ES, it shouldn't be that difficult to do. What do you think?
I certainly don't have the final say on this, but I am not sure that we would want to do this. With the
emulationstation-devscript module, there is an understanding that the new features that are added there will eventually make it to stable. We can't give the same guarantee for any changes added to external forks. It also provides less incentive for those features to be implemented into the RetroPie repository.@f-caruso said in Updated EmulationStation for Windows:
So, I propose to you :
Either look at my changelist and tell me things you want and I'll see according to the effort needed. For the features that will not take too much effort, I'll try do it.
Either test & play with my version, and tell me exactly what you want me to fix or modify and take the whole package for Retropie... (honestly, now : the second solution will be easier to do and you'll have a real big new version for the next retropie release, containing many things people are waiting for, for so long)I can say with confidence that we will not just be accepting your changes as is. It is not how we accept changes and it is not how most open source projects accept changes either. We want PRs that consist of individual features/changes. That makes it easier to review and test as well as isolate the cause of any regression that is missed during the initial review.
I will look through your changelist and can identify the changes that I think are most wanted/beneficial. Obviously, you are under no obligation to put in the effort to push them to RetroPie, but if eventually we may accept conflicting changes which will make it difficult to stay in sync with RetroPie.
-
@f-caruso thanks again for your continued work on this one. The latest build is causing some issues on my system (the older Xeon system that had no issues with the last build). The startup problem has returned, but this time it seems to crash out when loading favorites (at least that's what is shown on the screen when it crashes). No messages in the error logs, just crashes. Like last time, it works once every few tries, but seems to be specific to this new build as the last one was working fine on this machine.
-
@drcnyc said in Updated EmulationStation for Windows:
The latest build
" The latest build" which one did u take ? the automated build one ? I don't reproduce with this one.
-
@f-caruso I updated (replaced) all of the ES files with the 2.10.0.5 distrubution
-
@f-caruso Huge thank you for your time/efforts, it is now working better then the 2.9 release, it's faster, feature packed and bug free (so far ;)) I'll be taking this across to the kids arcade finally to give it a full work out. Hopefully I have nothing new to report :D
-
@f-caruso I see you have added a key on the screen, I really liked that. An idea has thought about changing language on keyboard? I could also use several forms of Qwuerty distribution and in order. Well they are ideas if they can be good. Of course I understand that time is important.
The keys change shape when pressing shift or X button. Another thing that happens to me is that I can not load your fabz-theme, I do not know why when loading it closes ES. I tried to launch it from start with file es_settings.cfg, only with the lines
<? xml version = "1.0"?>
<string name = "ThemeSet" value = "fabz-theme" />and it does not start. with other themes if it works. I've also seen with another configuration of xml list that I have in folders to group type of game or type of arcade no longer works in the previous ES without working. Its version is now faster and more stable. Good job
-
@jero Hi. The Onscreen keyboard layout is only en or fr, depending on the selected language. I don't know the layouts for the other countries...
About the random crash, it's not related to the theme but the threaded loading and has been solved, in the continuous build.
Just download the latest Continuous build on my github. -
@f-caruso Perfect I have already tried it and its theme works for me. On the on-screen keyboard it may change according to language, but not everything is there. It is possible, a text file for custom keyboard. The "X" button does not do anything just the first press, if you press again it does not do anything on the keyboard.
Here I pass an idea to him if he likes it, I prepare the icons if you wants.
-
Any chance of adding the new smooth carousel grid to the current grid view for the pi please?
-
Your Continuous build says:
"Bad management of folders containing only one game 41
9 hours ago by Fabrice CARUSO
continuous-master 5d049dd2
Failed 9 hours ago in 1 min 14 sec"Meaning no .exe to try, just the source code is there. I failed to build it myself in Windows and in Linux, I guess I am just really bad at this kind of development, sorry about that. I will test new build once it's ready, I noticed my main PC's ES wouldn't load last night when I had time to use it, so I reverted to 2.9 to get some roms sorted. Glad it's a known bug that should be fixed.
-
@LiveFreeDead According to the build log, freetype repo was not available yesterday night ( http://download.savannah.gnu.org/releases/freetype/freetype-2.7.tar.gz - Unable to connect to the remote server )... But you always can access build history on appveyor and download the latest successful builds.
-
@f-caruso
Redraw exiting game BUG:This shows the re-draw bug when I exit any game, using any theme. The only reason it comes back at 21 seconds is due to me manually moving the window using the mouse, once I do this it fades the collection wallpaper and icon back in.
BTW I can actually exit from one Collection and enter another and the wallpaper/icon is still missing until the 3rd or 3th time I enter a collection then it also redraws properly after fading back in.
I have always had this bug since your first 2.10 release, it has changed a bit (improved) as it used to lose some collection icons and the main wallpapers on the carousel .
Doesn't matter if I use windowed mode or full screen.
I just noticed if I run a 2nd rom once it's messed up, once it returns from that it is fine again. and the next exit is broken - so I am thinking a flag/toggle is set wrong or checked to be a value >1 instead of =1 or something.
I have tried transitions set to fade, slide and none, always does this glitch.
jdrassa's version does not do this.
I have NVidia GTX 550Ti, but this bug also affected my nVidia 610m on my laptop. I have tried this with 1 rom on a clean release and it still happens.
-
@LiveFreeDead Hi Glenn, from Austalia ;-) (dawn it is far from France...), I don't reproduce the problem, but you don't provide a lot of informations.
To be in 1.9 release condition, you should try setting the option "HIDE WHEN LAUNCH..." to ON ? This option is not available in 1.9 releases, and loading/unloading is a bit different when disabled. Does the problem still occur ?
Image loosing/reloading is caused by not enough VRAM. Your theme is HD and needs a lot of VRAM. Maybe your scapped images are very big too. Using your theme & preloading, it would require > 3Gb VRAM (yes 3Gb !!!) you can see it enabling the option "show framerate"- to keep everything in memory. There is a mecanism to unload/reload resources (which, honestly, should be rewritten too, but I didn't touch it yet). I have flickerings issues too when I set VRAM too low and it occurs in the 1.9 release too -> Try increase VRAM limit - On Windows with an NVIDIA card, you can set it to 500 without any problem.
Are you using a powersave mode ? When using powersave, Mouse/Keyb events are the only way to redraw the screen... Maybe it is related too -> Try disable powersave modes.
-
Yeah, I have lived in Tasmania all my life, most I done was make LastOS (Windows mods) since early 2000's until today, it's a lot slower since Windows 10 came and killed off modding. I guess that is why I switched to Emulation, it's always gonna be appreciated.
Increasing VRAM fixed it, Do you have the ability to detect how much vRam is available, because my system has 1023 MB Physical Memory and seeing as the default ram size is 100mb it might be worth checking this in a Windows OS quickly each boot so it can change the default 100mb (if detected as 100mb to be more by default (not Pi's default)).
If I enable "Hide when Running Game" it will crash ES entirely when I exit back to ES, I have to close with TaskMGR, I use a dual screen setup, this might cause a issue).
I use Power saving mode disabled since mentioning the issues with scraping with it set to anything else making it abort scraping. Since you made it drop usage I had no need to enable it, like you said then, you can disable it for Windows machines ;)
I thought the 200MB Vram would have been fine, thanks again for simple fix, but maybe we can force a dual reload when returning from a ROM, like i said every 2nd time you returned from a game it would work perfect again, so it is possible to get it to draw correct every time even with low vram? not important now it's fixed tho. Good run on bug fixes, that's 3 for 3 now.
-
@LiveFreeDead Tasmania... 17.125,97 kilometers from Paris... 20 hours by plane... Never went so far ;-) Don't know if I ever will... But it must be beautiful compared to where I live...
"Detect how much vRam is available" -> Can't find a portable way to determine that. Furthermore, Windows has no unique way to do that. Different methods are needed according to the kind of video card. Better not change anything, and let the user do.
The VRAM manager doesn't care about what's on the current screen. It flickers because it loads the image, it needs room, it unload the image. Then, it needs to display the image and reload it, it needs room, it unload the image again, and so on... It would need a complete rewrite, but it is a very big work... For now : Either use a low VRAM theme, either increase VRAM preference. I usually use around 250 Mb and it work pretty fine with all themes.
"Hide when Running Game" : Thanks, I do crash too, it is a bug, due to the CPU use hack I added for WIN32 . It is now solved, I'll commit it next hour.
I really hope this is the last bug !!!
EDIT : Commited
-
@f-caruso Bad news, after loading about 20 or so games in a row, the graphics glitch comes back - regardless of what I set the vRam too, it must not be clearing the pre-allocated memory and creating a new one every time until it runs out, then my guess is it does some garbage collection and it works again until the very next game where it will glitch/flicker. As you never wrote those routines, I don't expect a fix, just be aware it will happen eventually when loading and exiting a set number of games.
BTW Hide when running will show it on the default display and not the display it was currently on (when using dual monitors like I do), I'll just work around this little things as they are not too bad compared to the load/crash bug you fixed.
-
@LiveFreeDead Hi. For the flickering, it was my mistake, I just committed a fix.
I don't understand the dual screen problem -> be more specific. -
@f-caruso
Dual Screen Test:
1.I run ES in a window (defaults to screen 1)
2.I drag it to the 2nd screen (Screen 2),so I can manage my rom folders on my main screen.
3.I run a game with the Hide when running enabled, which it hides fine. (Hidden on both screens)
4.When I exit my game and ES is shown again it is on (Screen 1) again (over the folders).The new Raspberry Pi 4b has dual screen, so I am sure there will be fixes in the pi code sooner or later, doubt it will be compatible with windows tho. I don't mind if this bug is fixed, I just don't hide it currently and the loading screen is under the retroarch etc (so no desktop shown anyway).
Contributions to the project are always appreciated, so if you would like to support us with a donation you can do so here.
Hosting provided by Mythic-Beasts. See the Hosting Information page for more information.